* [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config [not found] <20210402090042.2020627-1-jamie@kwiius.com> @ 2021-04-02 9:04 ` Jamie McClymont 2021-04-02 15:35 ` Alyssa Ross 2021-04-02 9:04 ` [RFC PATCH 1/8] chromiumOSPackages: update 83->89 Jamie McClymont ` (6 subsequent siblings) 7 siblings, 1 reply; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont The ANALOGIX_ANX7625 option no longer exists, but VIDEO_INTEL_IPU6 is now a source of build errors. --- pkgs/os-specific/linux/kernel/linux-cros.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/os-specific/linux/kernel/linux-cros.nix b/pkgs/os-specific/linux/kernel/linux-cros.nix index 789a9fb6fd2..d292fe2c54a 100644 --- a/pkgs/os-specific/linux/kernel/linux-cros.nix +++ b/pkgs/os-specific/linux/kernel/linux-cros.nix @@ -29,6 +29,10 @@ buildLinux (args // rec { # Enabling this (the default) caused a build failure. If you can # archieve a successful build with this enabled, go ahead and # enable it. - ANALOGIX_ANX7625 = no; + VIDEO_INTEL_IPU6 = no; + + # RTW88_8822*E were being selected as Y when N/m/? are the only valid options + RTW88_8822BE = lib.mkForce no; + RTW88_8822CE = lib.mkForce no; } // (args.structuredExtraConfig or {}); } // (args.argsOverride or {})) -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config 2021-04-02 9:04 ` [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config Jamie McClymont @ 2021-04-02 15:35 ` Alyssa Ross 0 siblings, 0 replies; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 15:35 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel [-- Attachment #1: Type: text/plain, Size: 1291 bytes --] Jamie McClymont <jamie@kwiius.com> writes: > The ANALOGIX_ANX7625 option no longer exists, but VIDEO_INTEL_IPU6 is > now a source of build errors. > --- > pkgs/os-specific/linux/kernel/linux-cros.nix | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/pkgs/os-specific/linux/kernel/linux-cros.nix b/pkgs/os-specific/linux/kernel/linux-cros.nix > index 789a9fb6fd2..d292fe2c54a 100644 > --- a/pkgs/os-specific/linux/kernel/linux-cros.nix > +++ b/pkgs/os-specific/linux/kernel/linux-cros.nix > @@ -29,6 +29,10 @@ buildLinux (args // rec { > # Enabling this (the default) caused a build failure. If you can > # archieve a successful build with this enabled, go ahead and > # enable it. > - ANALOGIX_ANX7625 = no; > + VIDEO_INTEL_IPU6 = no; > + > + # RTW88_8822*E were being selected as Y when N/m/? are the only valid options > + RTW88_8822BE = lib.mkForce no; > + RTW88_8822CE = lib.mkForce no; What do you think about setting these to "modules" instead of "no"? It looks like that's what we do in Nixpkgs for more recent kernels that behave the same way (not allowing Y). > } // (args.structuredExtraConfig or {}); > } // (args.argsOverride or {})) > -- > 2.31.1 Patch LGTM other than that. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* [RFC PATCH 1/8] chromiumOSPackages: update 83->89 [not found] <20210402090042.2020627-1-jamie@kwiius.com> 2021-04-02 9:04 ` [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config Jamie McClymont @ 2021-04-02 9:04 ` Jamie McClymont 2021-04-02 14:58 ` Alyssa Ross 2021-04-02 9:04 ` [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches Jamie McClymont ` (5 subsequent siblings) 7 siblings, 1 reply; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont --- .../linux/chromium-os/upstream-info.json | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/pkgs/os-specific/linux/chromium-os/upstream-info.json b/pkgs/os-specific/linux/chromium-os/upstream-info.json index 7755c48239c..cec5a21b1e4 100644 --- a/pkgs/os-specific/linux/chromium-os/upstream-info.json +++ b/pkgs/os-specific/linux/chromium-os/upstream-info.json @@ -1,66 +1,66 @@ { - "version": "83.13020.0.0-rc1", + "version": "89.13729.0.0-rc1", "components": { "src/aosp/external/minijail": { "name": "minijail", "url": "https://android.googlesource.com/platform/external/minijail", - "rev": "84ffabcf488bf0935f00930a9a23bbce1f34d79f", - "sha256": "0yhbklwmgqws4cb098hpaky4w8if5snpkdabridcc5hk5d7vgild" + "rev": "b49291144e126662b8c7d1551fd1dc572e1d55da", + "sha256": "19z0qrfyh7p2kmsgvm4k053vrzz2w6zysqh3bm2rx0irsdv0pnqm" }, "src/platform/crosvm": { "name": "crosvm", "url": "https://chromium.googlesource.com/chromiumos/platform/crosvm", - "rev": "664cc3ca49cb58d5bf7d936686fd211d6dd728bf", - "sha256": "0rms1hkb3r4w6j3l71gavky6ylc7gi9sfr2rq4dr82v6vc8zxbjx" + "rev": "f35d2c43ff19520855cffee761dc8899c5a439a1", + "sha256": "0fahrcw7x33d21i6azgr787afrhp002f8mvz81ich5w7vk2xjzxr" }, "src/platform/minigbm": { "name": "minigbm", "url": "https://chromium.googlesource.com/chromiumos/platform/minigbm", - "rev": "bc4f023bfcc51cf9dcfcfec5bf4177b2e607dd68", - "sha256": "08ag207199xj5cw686386rmvr7sx2mzihdckm2pnvw743w03gipr" + "rev": "9fe8c20f05116869f86d91fc542a17b9badf9ec3", + "sha256": "0gr81qngfa1g58cz3v9dlms997ry3h5dh7vcv2ak1j53dzfdzckn" }, "src/platform2": { "name": "platform2", "url": "https://chromium.googlesource.com/chromiumos/platform2", - "rev": "e45d54bedee94e0121e12cc86fded46be8b3fa4e", - "sha256": "0ag01p8ch0wn7ds9ywasrdxkbibg19qzf5rldf8nr8irk1n851n7" + "rev": "e6e2faf2abb10fcbca3b6eccdcf7cf2506bcc212", + "sha256": "1g6kxmiffizqlxwakma1rp26p9mwpjbl3cv5hn7k5zd6cn8wixj7" }, "src/third_party/adhd": { "name": "adhd", "url": "https://chromium.googlesource.com/chromiumos/third_party/adhd", - "rev": "d3af897db5540cadc439463a0ffdde07f2b8898a", - "sha256": "1h0xxf338d7fwmfwjlpsjiml8d3v426a95x3ka7qfikdapgmav3d" + "rev": "0458a459ad51cc0b386835f5b909d0d04003ab16", + "sha256": "1y1g0h2dcmgpz9nk2hc6fcb0c53ip3mf27yyf7gg6syx764pr2gb" }, "src/third_party/chromiumos-overlay": { "name": "chromiumos-overlay", "url": "https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay", - "rev": "270f5c2cfb7eadc374638076c8fdee72360a6d66", - "sha256": "1d88xvnf0qc3v5hp9b2pafxhi83rph84y2sbk1nc46rhj63m8bwi" + "rev": "dd29be74a5c6fa492411ec7feed734004c6a1ea5", + "sha256": "0pbrbbr39j9zsc10dhhhmwx1c69a40nsv4cprh7biz1b8f840l1b" }, "src/third_party/kernel/v5.4": { "name": "v5.4", "url": "https://chromium.googlesource.com/chromiumos/third_party/kernel", - "rev": "36270ae817fb576debb80bce752addb3a4cc9886", - "sha256": "0h7fj3w9vwmq8a6cx96vjcyw29v7wfamxykh1nx3lmhxxkn120f4", - "version": "5.4.28" + "rev": "eb179ec7ef3e053acb48366e72299055b2b66ca8", + "sha256": "13i7f3742cnw7lm0b2zal4lxbqrkmniajqp5c1gllvrfvxcw4a45", + "version": "5.4.88" }, "src/third_party/libqmi": { "name": "libqmi", "url": "https://chromium.googlesource.com/chromiumos/third_party/libqmi", - "rev": "20726755e60d48c70f0189a1cfe9665a87a5e6c6", - "sha256": "0w04lyd459jgcag70kx6nq1i952fbhy32nmkh6r255xjf2wrliwr" + "rev": "072abd58da99c00b79dbf7e4642fa19fb791aed9", + "sha256": "1a6x5hwghkrvi82szhabxf2by4x7x9pfk6bvpgz0ipz8yqg8fwih" }, "src/third_party/modemmanager-next": { "name": "modemmanager-next", "url": "https://chromium.googlesource.com/chromiumos/third_party/modemmanager-next", - "rev": "988f572cc882a74209fba0f5c49cf0b01b9163a6", - "sha256": "1hiqz7wn1w461sd94v179q81yahisffnw033yix3dwfwagm9ndf8" + "rev": "3eba6678dfe0d7b35f128bb58b63e71d1a3a64d4", + "sha256": "0lviwkkqsv5zmajqdlc0s83yq12ikk0gf7wq9za58p92g0970i4l" }, "src/third_party/modp_b64": { "name": "modp_b64", "url": "https://chromium.googlesource.com/aosp/platform/external/modp_b64", - "rev": "ae26ad8516036774fd3b6e84a98a89955dcf5f61", - "sha256": "03ja5fkq3wk0qcnfnqcj09lciky6n6zdj544xs1jfssjhz9yj8hi" + "rev": "467734f4870d3ab23968f5ebdd461f6112e4103b", + "sha256": "1hlk9vzivy0n3xf9hm9bhj7i09yifirc1af6pli471m00v3s0zvg" } } } -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 1/8] chromiumOSPackages: update 83->89 2021-04-02 9:04 ` [RFC PATCH 1/8] chromiumOSPackages: update 83->89 Jamie McClymont @ 2021-04-02 14:58 ` Alyssa Ross 0 siblings, 0 replies; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 14:58 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel [-- Attachment #1: Type: text/plain, Size: 218 bytes --] Jamie McClymont <jamie@kwiius.com> writes: > --- > .../linux/chromium-os/upstream-info.json | 44 +++++++++---------- > 1 file changed, 22 insertions(+), 22 deletions(-) Reviewed-by: Alyssa Ross <hi@alyssa.is> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches [not found] <20210402090042.2020627-1-jamie@kwiius.com> 2021-04-02 9:04 ` [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config Jamie McClymont 2021-04-02 9:04 ` [RFC PATCH 1/8] chromiumOSPackages: update 83->89 Jamie McClymont @ 2021-04-02 9:04 ` Jamie McClymont 2021-04-02 15:47 ` Alyssa Ross 2021-04-02 9:04 ` [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch Jamie McClymont ` (4 subsequent siblings) 7 siblings, 1 reply; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont --- ...ommon-mk-don-t-leak-source-absolute-paths.patch | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch b/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch index 4b7a2f34779..244ba8f7521 100644 --- a/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch +++ b/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch @@ -38,13 +38,11 @@ diff --git a/common-mk/pkg_config.gni b/common-mk/pkg_config.gni index af3c3fb4c..151c49e56 100644 --- a/common-mk/pkg_config.gni +++ b/common-mk/pkg_config.gni -@@ -81,12 +81,11 @@ template("generate_pkg_config") { +@@ -81,10 +81,11 @@ template("generate_pkg_config") { if (!defined(output_name)) { output_name = name } -- outputs = [ -- "${target_out_dir}/${output_name}.pc", -- ] +- outputs = [ "${target_out_dir}/${output_name}.pc" ] + lib_path = "${target_out_dir}/${output_name}.pc" + outputs = [ lib_path ] @@ -117,11 +115,11 @@ index 7fcb08341..692704288 100644 # Build protoc command line to run. script = "//common-mk/file_generator_wrapper.py" @@ -224,7 +225,7 @@ template("goproto_library") { - "--proto_path", - "${sysroot}/usr/share/proto", + args += [ "--go_out", -- "${go_out_prefix}${root_gen_dir}/${proto_out_dir}", -+ "${go_out_prefix}${proto_out_dir}", + # go_out_prefix can be empty, so we can always add a colon here. +- "${go_out_prefix}:${root_gen_dir}/${proto_out_dir}", ++ "${go_out_prefix}:${proto_out_dir}", ] foreach(source, sources) { args += [ rebase_path(source) ] -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches 2021-04-02 9:04 ` [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches Jamie McClymont @ 2021-04-02 15:47 ` Alyssa Ross 0 siblings, 0 replies; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 15:47 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel [-- Attachment #1: Type: text/plain, Size: 2098 bytes --] Jamie McClymont <jamie@kwiius.com> writes: > --- > ...ommon-mk-don-t-leak-source-absolute-paths.patch | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Alyssa Ross <hi@alyssa.is> Tested-by: Alyssa Ross <hi@alyssa.is> > diff --git a/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch b/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch > index 4b7a2f34779..244ba8f7521 100644 > --- a/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch > +++ b/pkgs/os-specific/linux/chromium-os/common-mk/0001-common-mk-don-t-leak-source-absolute-paths.patch > @@ -38,13 +38,11 @@ diff --git a/common-mk/pkg_config.gni b/common-mk/pkg_config.gni > index af3c3fb4c..151c49e56 100644 > --- a/common-mk/pkg_config.gni > +++ b/common-mk/pkg_config.gni > -@@ -81,12 +81,11 @@ template("generate_pkg_config") { > +@@ -81,10 +81,11 @@ template("generate_pkg_config") { > if (!defined(output_name)) { > output_name = name > } > -- outputs = [ > -- "${target_out_dir}/${output_name}.pc", > -- ] > +- outputs = [ "${target_out_dir}/${output_name}.pc" ] > + lib_path = "${target_out_dir}/${output_name}.pc" > + outputs = [ lib_path ] > > @@ -117,11 +115,11 @@ index 7fcb08341..692704288 100644 > # Build protoc command line to run. > script = "//common-mk/file_generator_wrapper.py" > @@ -224,7 +225,7 @@ template("goproto_library") { > - "--proto_path", > - "${sysroot}/usr/share/proto", > + args += [ > "--go_out", > -- "${go_out_prefix}${root_gen_dir}/${proto_out_dir}", > -+ "${go_out_prefix}${proto_out_dir}", > + # go_out_prefix can be empty, so we can always add a colon here. > +- "${go_out_prefix}:${root_gen_dir}/${proto_out_dir}", > ++ "${go_out_prefix}:${proto_out_dir}", > ] > foreach(source, sources) { > args += [ rebase_path(source) ] > -- > 2.31.1 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch [not found] <20210402090042.2020627-1-jamie@kwiius.com> ` (2 preceding siblings ...) 2021-04-02 9:04 ` [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches Jamie McClymont @ 2021-04-02 9:04 ` Jamie McClymont 2021-04-02 15:53 ` Alyssa Ross 2021-04-02 9:04 ` [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings Jamie McClymont ` (3 subsequent siblings) 7 siblings, 1 reply; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont The missing dependency has been added upstream --- ...03-vm_tools-proto-fix-parallel-build.patch | 39 ------------------- .../linux/chromium-os/vm_protos/default.nix | 2 - 2 files changed, 41 deletions(-) delete mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch b/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch deleted file mode 100644 index 93fa535ac7e..00000000000 --- a/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch +++ /dev/null @@ -1,39 +0,0 @@ -From dfed9458bf7abc1dc8f33a3e16ee179cde88e4e2 Mon Sep 17 00:00:00 2001 -From: Alyssa Ross <hi@alyssa.is> -Date: Tue, 2 Jun 2020 00:21:08 +0000 -Subject: [PATCH 3/6] vm_tools: proto: fix parallel build - -fuzzer-protos depends on vm-crash-rpcs, but this dependency wasn't -declared, causing build failures like the following: - -[26/52] CXX obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o -FAILED: obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o -c++ -MMD -MF obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Igen/include -I../../common-mk -I/usr/include -Igen -Igen -Igen -Igen -Wall -Wunused -Wno-unused-parameter -Wunreachable-code -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Wimplicit-fallthrough -Werror --sysroot= -fPIE -fvisibility=default -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -Wno-unreachable-code -std=gnu++14 -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Wno-psabi -c gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc -o obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o -In file included from gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc:5: -gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal error: vm_crash.pb.h: No such file or directory - 38 | #include "vm_crash.pb.h" - | ^~~~~~~~~~~~~~~ -compilation terminated. -ninja: build stopped: subcommand failed. - -Reported-by: Cole Helbling <cole.e.helbling@outlook.com> -Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com> ---- - vm_tools/proto/BUILD.gn | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/vm_tools/proto/BUILD.gn b/vm_tools/proto/BUILD.gn -index 713b81853..a25265cab 100644 ---- a/vm_tools/proto/BUILD.gn -+++ b/vm_tools/proto/BUILD.gn -@@ -70,6 +70,7 @@ proto_library("fuzzer-protos") { - deps = [ - ":container-rpcs", - ":tremplin-rpcs", -+ ":vm-crash-rpcs", - ] - sources = [ - "${proto_in_dir}/fuzzer.proto", --- -2.26.2 - diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix b/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix index 4f0aae3be38..e87d0c57e78 100644 --- a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix +++ b/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix @@ -12,8 +12,6 @@ common-mk { "-Wno-error=deprecated-declarations" ]; - platform2Patches = [ ./0003-vm_tools-proto-fix-parallel-build.patch ]; - postPatch = '' substituteInPlace common-mk/proto_library.gni \ --replace /usr/bin/grpc_cpp_plugin ${grpc}/bin/grpc_cpp_plugin -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch 2021-04-02 9:04 ` [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch Jamie McClymont @ 2021-04-02 15:53 ` Alyssa Ross 0 siblings, 0 replies; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 15:53 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel [-- Attachment #1: Type: text/plain, Size: 4272 bytes --] Jamie McClymont <jamie@kwiius.com> writes: > The missing dependency has been added upstream > --- > ...03-vm_tools-proto-fix-parallel-build.patch | 39 ------------------- > .../linux/chromium-os/vm_protos/default.nix | 2 - > 2 files changed, 41 deletions(-) > delete mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch Reviewed-by: Alyssa Ross <hi@alyssa.is> Tested-by: Alyssa Ross <hi@alyssa.is> FWIW, I had to apply patch 4/8 before I could get to the error this was causing. > diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch b/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch > deleted file mode 100644 > index 93fa535ac7e..00000000000 > --- a/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch > +++ /dev/null > @@ -1,39 +0,0 @@ > -From dfed9458bf7abc1dc8f33a3e16ee179cde88e4e2 Mon Sep 17 00:00:00 2001 > -From: Alyssa Ross <hi@alyssa.is> > -Date: Tue, 2 Jun 2020 00:21:08 +0000 > -Subject: [PATCH 3/6] vm_tools: proto: fix parallel build > - > -fuzzer-protos depends on vm-crash-rpcs, but this dependency wasn't > -declared, causing build failures like the following: > - > -[26/52] CXX obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o > -FAILED: obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o > -c++ -MMD -MF obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Igen/include -I../../common-mk -I/usr/include -Igen -Igen -Igen -Igen -Wall -Wunused -Wno-unused-parameter -Wunreachable-code -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Wimplicit-fallthrough -Werror --sysroot= -fPIE -fvisibility=default -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -Wno-unreachable-code -std=gnu++14 -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Wno-psabi -c gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc -o obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o > -In file included from gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc:5: > -gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal error: vm_crash.pb.h: No such file or directory > - 38 | #include "vm_crash.pb.h" > - | ^~~~~~~~~~~~~~~ > -compilation terminated. > -ninja: build stopped: subcommand failed. > - > -Reported-by: Cole Helbling <cole.e.helbling@outlook.com> > -Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com> > ---- > - vm_tools/proto/BUILD.gn | 1 + > - 1 file changed, 1 insertion(+) > - > -diff --git a/vm_tools/proto/BUILD.gn b/vm_tools/proto/BUILD.gn > -index 713b81853..a25265cab 100644 > ---- a/vm_tools/proto/BUILD.gn > -+++ b/vm_tools/proto/BUILD.gn > -@@ -70,6 +70,7 @@ proto_library("fuzzer-protos") { > - deps = [ > - ":container-rpcs", > - ":tremplin-rpcs", > -+ ":vm-crash-rpcs", > - ] > - sources = [ > - "${proto_in_dir}/fuzzer.proto", > --- > -2.26.2 > - > diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix b/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix > index 4f0aae3be38..e87d0c57e78 100644 > --- a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix > +++ b/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix > @@ -12,8 +12,6 @@ common-mk { > "-Wno-error=deprecated-declarations" > ]; > > - platform2Patches = [ ./0003-vm_tools-proto-fix-parallel-build.patch ]; > - > postPatch = '' > substituteInPlace common-mk/proto_library.gni \ > --replace /usr/bin/grpc_cpp_plugin ${grpc}/bin/grpc_cpp_plugin > -- > 2.31.1 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings [not found] <20210402090042.2020627-1-jamie@kwiius.com> ` (3 preceding siblings ...) 2021-04-02 9:04 ` [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch Jamie McClymont @ 2021-04-02 9:04 ` Jamie McClymont 2021-04-02 15:54 ` Alyssa Ross 2021-04-02 9:04 ` [RFC PATCH 8/8] chromiumOSPackages.crosvm: bump cargoSha256 Jamie McClymont ` (2 subsequent siblings) 7 siblings, 1 reply; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont --- pkgs/os-specific/linux/chromium-os/common-mk/default.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix b/pkgs/os-specific/linux/chromium-os/common-mk/default.nix index cc72aab5d15..d617401138f 100644 --- a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix +++ b/pkgs/os-specific/linux/chromium-os/common-mk/default.nix @@ -64,7 +64,11 @@ stdenv.mkDerivation ({ patchShebangs common-mk '' + (lib.optionalString (!stdenv.cc.isClang) '' substituteInPlace common-mk/BUILD.gn \ - --replace '"-Wno-c99-designator",' "" + --replace '"-Wno-c99-designator",' "" \ + --replace '"-Wstring-compare",' "" \ + --replace '"-Wstring-plus-int",' "" \ + --replace '"-Wxor-used-as-pow",' "" \ + --replace '"-Wunreachable-code-return",' "" '') + postPatch; nativeBuildInputs = [ gn pkgconfig python3 ninja ] ++ nativeBuildInputs; -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings 2021-04-02 9:04 ` [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings Jamie McClymont @ 2021-04-02 15:54 ` Alyssa Ross 0 siblings, 0 replies; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 15:54 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel [-- Attachment #1: Type: text/plain, Size: 1175 bytes --] Jamie McClymont <jamie@kwiius.com> writes: > --- > pkgs/os-specific/linux/chromium-os/common-mk/default.nix | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Alyssa Ross <hi@alyssa.is> Tested-by: Alyssa Ross <hi@alyssa.is> > diff --git a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix b/pkgs/os-specific/linux/chromium-os/common-mk/default.nix > index cc72aab5d15..d617401138f 100644 > --- a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix > +++ b/pkgs/os-specific/linux/chromium-os/common-mk/default.nix > @@ -64,7 +64,11 @@ stdenv.mkDerivation ({ > patchShebangs common-mk > '' + (lib.optionalString (!stdenv.cc.isClang) '' > substituteInPlace common-mk/BUILD.gn \ > - --replace '"-Wno-c99-designator",' "" > + --replace '"-Wno-c99-designator",' "" \ > + --replace '"-Wstring-compare",' "" \ > + --replace '"-Wstring-plus-int",' "" \ > + --replace '"-Wxor-used-as-pow",' "" \ > + --replace '"-Wunreachable-code-return",' "" > '') + postPatch; > > nativeBuildInputs = [ gn pkgconfig python3 ninja ] ++ nativeBuildInputs; > -- > 2.31.1 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* [RFC PATCH 8/8] chromiumOSPackages.crosvm: bump cargoSha256 [not found] <20210402090042.2020627-1-jamie@kwiius.com> ` (4 preceding siblings ...) 2021-04-02 9:04 ` [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings Jamie McClymont @ 2021-04-02 9:04 ` Jamie McClymont 2021-04-02 9:04 ` [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches Jamie McClymont 2021-04-02 9:04 ` [RFC PATCH 7/8] chromiumOSPackages.crosvm: add platform2 dep Jamie McClymont 7 siblings, 0 replies; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont --- pkgs/os-specific/linux/chromium-os/crosvm/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/os-specific/linux/chromium-os/crosvm/default.nix b/pkgs/os-specific/linux/chromium-os/crosvm/default.nix index ab5ac518ef7..1013e7817e4 100644 --- a/pkgs/os-specific/linux/chromium-os/crosvm/default.nix +++ b/pkgs/os-specific/linux/chromium-os/crosvm/default.nix @@ -42,7 +42,7 @@ in ./default-seccomp-policy-dir.diff ]; - cargoSha256 = "0wzqn2n4vyv3bk39079yg1zbnriagi5xns928bzdqmq9djdcj21i"; + cargoSha256 = "02y4wvm2l54f3y0dzcfyzay4hsy7b1q8x9kshqidi9pvh09if7x4"; nativeBuildInputs = [ pkgconfig ]; -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches [not found] <20210402090042.2020627-1-jamie@kwiius.com> ` (5 preceding siblings ...) 2021-04-02 9:04 ` [RFC PATCH 8/8] chromiumOSPackages.crosvm: bump cargoSha256 Jamie McClymont @ 2021-04-02 9:04 ` Jamie McClymont 2021-04-02 16:11 ` Alyssa Ross 2021-04-02 9:04 ` [RFC PATCH 7/8] chromiumOSPackages.crosvm: add platform2 dep Jamie McClymont 7 siblings, 1 reply; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont The xdg-shell thing has been integrated upstream, and the demos seem to no longer exist. --- ...melier-use-stable-xdg-shell-protocol.patch | 1748 ----------------- ...mmelier-make-building-demos-optional.patch | 100 - .../linux/chromium-os/sommelier/default.nix | 2 - 3 files changed, 1850 deletions(-) delete mode 100644 pkgs/os-specific/linux/chromium-os/sommelier/0005-sommelier-use-stable-xdg-shell-protocol.patch delete mode 100644 pkgs/os-specific/linux/chromium-os/sommelier/0006-sommelier-make-building-demos-optional.patch diff --git a/pkgs/os-specific/linux/chromium-os/sommelier/0005-sommelier-use-stable-xdg-shell-protocol.patch b/pkgs/os-specific/linux/chromium-os/sommelier/0005-sommelier-use-stable-xdg-shell-protocol.patch deleted file mode 100644 index 41a42df74fd..00000000000 --- a/pkgs/os-specific/linux/chromium-os/sommelier/0005-sommelier-use-stable-xdg-shell-protocol.patch +++ /dev/null @@ -1,1748 +0,0 @@ -From d3a8f6b49e35744e71271cab1eb9ea9a5c87854d Mon Sep 17 00:00:00 2001 -From: Puck Meerburg <puck@puckipedia.com> -Date: Tue, 3 Dec 2019 18:06:14 +0000 -Subject: [PATCH 5/6] sommelier: use stable xdg-shell protocol - -From https://github.com/wayland-project/weston/commit/d8d9f5e6e16c8f6a3c06763d5f56c27dc9a6e52e: - -> Some clients like the mpv video player now request the xdg_shell -> protocol so these will fail if the compositor only provides the -> xdg_shell_unstable_v6 protocol. Compositors like mir and gnome provide -> both protocols. ---- - vm_tools/sommelier/BUILD.gn | 2 +- - ...dg-shell-unstable-v6.xml => xdg-shell.xml} | 319 ++++++++++++------ - vm_tools/sommelier/sommelier-xdg-shell.c | 233 ++++++------- - vm_tools/sommelier/sommelier.c | 211 ++++++------ - vm_tools/sommelier/sommelier.h | 17 +- - 5 files changed, 447 insertions(+), 335 deletions(-) - rename vm_tools/sommelier/protocol/{xdg-shell-unstable-v6.xml => xdg-shell.xml} (79%) - -diff --git a/vm_tools/sommelier/BUILD.gn b/vm_tools/sommelier/BUILD.gn -index 5027628d2..4330560a1 100644 ---- a/vm_tools/sommelier/BUILD.gn -+++ b/vm_tools/sommelier/BUILD.gn -@@ -68,7 +68,7 @@ wayland_protocol_library("sommelier-protocol") { - "protocol/relative-pointer-unstable-v1.xml", - "protocol/text-input-unstable-v1.xml", - "protocol/viewporter.xml", -- "protocol/xdg-shell-unstable-v6.xml", -+ "protocol/xdg-shell.xml", - ] - } - -diff --git a/vm_tools/sommelier/protocol/xdg-shell-unstable-v6.xml b/vm_tools/sommelier/protocol/xdg-shell.xml -similarity index 79% -rename from vm_tools/sommelier/protocol/xdg-shell-unstable-v6.xml -rename to vm_tools/sommelier/protocol/xdg-shell.xml -index 1c0f92452..3a87a9ed6 100644 ---- a/vm_tools/sommelier/protocol/xdg-shell-unstable-v6.xml -+++ b/vm_tools/sommelier/protocol/xdg-shell.xml -@@ -1,11 +1,13 @@ - <?xml version="1.0" encoding="UTF-8"?> --<protocol name="xdg_shell_unstable_v6"> -+<protocol name="xdg_shell"> - - <copyright> - Copyright © 2008-2013 Kristian Høgsberg - Copyright © 2013 Rafael Antognolli - Copyright © 2013 Jasper St. Pierre - Copyright © 2010-2013 Intel Corporation -+ Copyright © 2015-2017 Samsung Electronics Co., Ltd -+ Copyright © 2015-2017 Red Hat Inc. - - Permission is hereby granted, free of charge, to any person obtaining a - copy of this software and associated documentation files (the "Software"), -@@ -27,18 +29,19 @@ - DEALINGS IN THE SOFTWARE. - </copyright> - -- <interface name="zxdg_shell_v6" version="1"> -+ <interface name="xdg_wm_base" version="2"> - <description summary="create desktop-style surfaces"> -- xdg_shell allows clients to turn a wl_surface into a "real window" -- which can be dragged, resized, stacked, and moved around by the -- user. Everything about this interface is suited towards traditional -- desktop environments. -+ The xdg_wm_base interface is exposed as a global object enabling clients -+ to turn their wl_surfaces into windows in a desktop environment. It -+ defines the basic functionality needed for clients and the compositor to -+ create windows that can be dragged, resized, maximized, etc, as well as -+ creating transient windows such as popup menus. - </description> - - <enum name="error"> - <entry name="role" value="0" summary="given wl_surface has another role"/> - <entry name="defunct_surfaces" value="1" -- summary="xdg_shell was destroyed before children"/> -+ summary="xdg_wm_base was destroyed before children"/> - <entry name="not_the_topmost_popup" value="2" - summary="the client tried to map or destroy a non-topmost popup"/> - <entry name="invalid_popup_parent" value="3" -@@ -50,11 +53,11 @@ - </enum> - - <request name="destroy" type="destructor"> -- <description summary="destroy xdg_shell"> -- Destroy this xdg_shell object. -+ <description summary="destroy xdg_wm_base"> -+ Destroy this xdg_wm_base object. - -- Destroying a bound xdg_shell object while there are surfaces -- still alive created by this xdg_shell object instance is illegal -+ Destroying a bound xdg_wm_base object while there are surfaces -+ still alive created by this xdg_wm_base object instance is illegal - and will result in a protocol error. - </description> - </request> -@@ -65,7 +68,7 @@ - surfaces relative to some parent surface. See the interface description - and xdg_surface.get_popup for details. - </description> -- <arg name="id" type="new_id" interface="zxdg_positioner_v6"/> -+ <arg name="id" type="new_id" interface="xdg_positioner"/> - </request> - - <request name="get_xdg_surface"> -@@ -82,14 +85,14 @@ - See the documentation of xdg_surface for more details about what an - xdg_surface is and how it is used. - </description> -- <arg name="id" type="new_id" interface="zxdg_surface_v6"/> -+ <arg name="id" type="new_id" interface="xdg_surface"/> - <arg name="surface" type="object" interface="wl_surface"/> - </request> - - <request name="pong"> - <description summary="respond to a ping event"> - A client must respond to a ping event with a pong request or -- the client may be deemed unresponsive. See xdg_shell.ping. -+ the client may be deemed unresponsive. See xdg_wm_base.ping. - </description> - <arg name="serial" type="uint" summary="serial of the ping event"/> - </request> -@@ -98,7 +101,7 @@ - <description summary="check if the client is alive"> - The ping event asks the client if it's still alive. Pass the - serial specified in the event back to the compositor by sending -- a "pong" request back with the specified serial. See xdg_shell.ping. -+ a "pong" request back with the specified serial. See xdg_wm_base.pong. - - Compositors can use this to determine if the client is still - alive. It's unspecified what will happen if the client doesn't -@@ -106,13 +109,13 @@ - try to respond in a reasonable amount of time. - - A compositor is free to ping in any way it wants, but a client must -- always respond to any xdg_shell object it created. -+ always respond to any xdg_wm_base object it created. - </description> - <arg name="serial" type="uint" summary="pass this to the pong request"/> - </event> - </interface> - -- <interface name="zxdg_positioner_v6" version="1"> -+ <interface name="xdg_positioner" version="2"> - <description summary="child surface positioner"> - The xdg_positioner provides a collection of rules for the placement of a - child surface relative to a parent surface. Rules can be defined to ensure -@@ -162,13 +165,13 @@ - Specify the anchor rectangle within the parent surface that the child - surface will be placed relative to. The rectangle is relative to the - window geometry as defined by xdg_surface.set_window_geometry of the -- parent surface. The rectangle must be at least 1x1 large. -+ parent surface. - - When the xdg_positioner object is used to position a child surface, the - anchor rectangle may not extend outside the window geometry of the - positioned child's parent surface. - -- If a zero or negative size is set the invalid_input error is raised. -+ If a negative size is set the invalid_input error is raised. - </description> - <arg name="x" type="int" summary="x position of anchor rectangle"/> - <arg name="y" type="int" summary="y position of anchor rectangle"/> -@@ -176,63 +179,54 @@ - <arg name="height" type="int" summary="height of anchor rectangle"/> - </request> - -- <enum name="anchor" bitfield="true"> -- <entry name="none" value="0" -- summary="the center of the anchor rectangle"/> -- <entry name="top" value="1" -- summary="the top edge of the anchor rectangle"/> -- <entry name="bottom" value="2" -- summary="the bottom edge of the anchor rectangle"/> -- <entry name="left" value="4" -- summary="the left edge of the anchor rectangle"/> -- <entry name="right" value="8" -- summary="the right edge of the anchor rectangle"/> -+ <enum name="anchor"> -+ <entry name="none" value="0"/> -+ <entry name="top" value="1"/> -+ <entry name="bottom" value="2"/> -+ <entry name="left" value="3"/> -+ <entry name="right" value="4"/> -+ <entry name="top_left" value="5"/> -+ <entry name="bottom_left" value="6"/> -+ <entry name="top_right" value="7"/> -+ <entry name="bottom_right" value="8"/> - </enum> - - <request name="set_anchor"> -- <description summary="set anchor rectangle anchor edges"> -- Defines a set of edges for the anchor rectangle. These are used to -- derive an anchor point that the child surface will be positioned -- relative to. If two orthogonal edges are specified (e.g. 'top' and -- 'left'), then the anchor point will be the intersection of the edges -- (e.g. the top left position of the rectangle); otherwise, the derived -- anchor point will be centered on the specified edge, or in the center of -- the anchor rectangle if no edge is specified. -- -- If two parallel anchor edges are specified (e.g. 'left' and 'right'), -- the invalid_input error is raised. -+ <description summary="set anchor rectangle anchor"> -+ Defines the anchor point for the anchor rectangle. The specified anchor -+ is used derive an anchor point that the child surface will be -+ positioned relative to. If a corner anchor is set (e.g. 'top_left' or -+ 'bottom_right'), the anchor point will be at the specified corner; -+ otherwise, the derived anchor point will be centered on the specified -+ edge, or in the center of the anchor rectangle if no edge is specified. - </description> - <arg name="anchor" type="uint" enum="anchor" -- summary="bit mask of anchor edges"/> -+ summary="anchor"/> - </request> - -- <enum name="gravity" bitfield="true"> -- <entry name="none" value="0" -- summary="center over the anchor edge"/> -- <entry name="top" value="1" -- summary="position above the anchor edge"/> -- <entry name="bottom" value="2" -- summary="position below the anchor edge"/> -- <entry name="left" value="4" -- summary="position to the left of the anchor edge"/> -- <entry name="right" value="8" -- summary="position to the right of the anchor edge"/> -+ <enum name="gravity"> -+ <entry name="none" value="0"/> -+ <entry name="top" value="1"/> -+ <entry name="bottom" value="2"/> -+ <entry name="left" value="3"/> -+ <entry name="right" value="4"/> -+ <entry name="top_left" value="5"/> -+ <entry name="bottom_left" value="6"/> -+ <entry name="top_right" value="7"/> -+ <entry name="bottom_right" value="8"/> - </enum> - - <request name="set_gravity"> - <description summary="set child surface gravity"> - Defines in what direction a surface should be positioned, relative to -- the anchor point of the parent surface. If two orthogonal gravities are -- specified (e.g. 'bottom' and 'right'), then the child surface will be -- placed in the specified direction; otherwise, the child surface will be -- centered over the anchor point on any axis that had no gravity -- specified. -- -- If two parallel gravities are specified (e.g. 'left' and 'right'), the -- invalid_input error is raised. -+ the anchor point of the parent surface. If a corner gravity is -+ specified (e.g. 'bottom_right' or 'top_left'), then the child surface -+ will be placed towards the specified gravity; otherwise, the child -+ surface will be centered over the anchor point on any axis that had no -+ gravity specified. - </description> - <arg name="gravity" type="uint" enum="gravity" -- summary="bit mask of gravity directions"/> -+ summary="gravity direction"/> - </request> - - <enum name="constraint_adjustment" bitfield="true"> -@@ -252,7 +246,7 @@ - <entry name="none" value="0"> - <description summary="don't move the child surface when constrained"> - Don't alter the surface position even if it is constrained on some -- axis, for example partially outside the edge of a monitor. -+ axis, for example partially outside the edge of an output. - </description> - </entry> - <entry name="slide_x" value="1"> -@@ -304,6 +298,10 @@ - surface is constrained, the gravity is 'bottom' and the anchor is - 'bottom', change the gravity to 'top' and the anchor to 'top'. - -+ The adjusted position is calculated given the original anchor -+ rectangle and offset, but with the new flipped anchor and gravity -+ values. -+ - If the adjusted position also ends up being constrained, the resulting - position of the flip_y adjustment will be the one before the - adjustment. -@@ -361,7 +359,7 @@ - </request> - </interface> - -- <interface name="zxdg_surface_v6" version="1"> -+ <interface name="xdg_surface" version="2"> - <description summary="desktop user interface surface base interface"> - An interface that may be implemented by a wl_surface, for - implementations that provide a desktop-style user interface. -@@ -388,11 +386,20 @@ - manipulate a buffer prior to the first xdg_surface.configure call must - also be treated as errors. - -- For a surface to be mapped by the compositor, the following conditions -- must be met: (1) the client has assigned a xdg_surface based role to the -- surface, (2) the client has set and committed the xdg_surface state and -- the role dependent state to the surface and (3) the client has committed a -- buffer to the surface. -+ Mapping an xdg_surface-based role surface is defined as making it -+ possible for the surface to be shown by the compositor. Note that -+ a mapped surface is not guaranteed to be visible once it is mapped. -+ -+ For an xdg_surface to be mapped by the compositor, the following -+ conditions must be met: -+ (1) the client has assigned an xdg_surface-based role to the surface -+ (2) the client has set and committed the xdg_surface state and the -+ role-dependent state to the surface -+ (3) the client has committed a buffer to the surface -+ -+ A newly-unmapped surface is considered to have met condition (1) out -+ of the 3 required conditions for mapping a surface if its role surface -+ has not been destroyed. - </description> - - <enum name="error"> -@@ -416,20 +423,23 @@ - See the documentation of xdg_toplevel for more details about what an - xdg_toplevel is and how it is used. - </description> -- <arg name="id" type="new_id" interface="zxdg_toplevel_v6"/> -+ <arg name="id" type="new_id" interface="xdg_toplevel"/> - </request> - - <request name="get_popup"> - <description summary="assign the xdg_popup surface role"> -- This creates an xdg_popup object for the given xdg_surface and gives the -- associated wl_surface the xdg_popup role. -+ This creates an xdg_popup object for the given xdg_surface and gives -+ the associated wl_surface the xdg_popup role. -+ -+ If null is passed as a parent, a parent surface must be specified using -+ some other protocol, before committing the initial state. - - See the documentation of xdg_popup for more details about what an - xdg_popup is and how it is used. - </description> -- <arg name="id" type="new_id" interface="zxdg_popup_v6"/> -- <arg name="parent" type="object" interface="zxdg_surface_v6"/> -- <arg name="positioner" type="object" interface="zxdg_positioner_v6"/> -+ <arg name="id" type="new_id" interface="xdg_popup"/> -+ <arg name="parent" type="object" interface="xdg_surface" allow-null="true"/> -+ <arg name="positioner" type="object" interface="xdg_positioner"/> - </request> - - <request name="set_window_geometry"> -@@ -442,6 +452,11 @@ - The window geometry is double buffered, and will be applied at the - time wl_surface.commit of the corresponding wl_surface is called. - -+ When maintaining a position, the compositor should treat the (x, y) -+ coordinate of the window geometry as the top left corner of the window. -+ A client changing the (x, y) window geometry coordinate should in -+ general not alter the position of the window. -+ - Once the window geometry of the surface is set, it is not possible to - unset it, and it will remain the same until set_window_geometry is - called again, even if a new subsurface or buffer is attached. -@@ -513,34 +528,50 @@ - </event> - </interface> - -- <interface name="zxdg_toplevel_v6" version="1"> -+ <interface name="xdg_toplevel" version="2"> - <description summary="toplevel surface"> - This interface defines an xdg_surface role which allows a surface to, - among other things, set window-like properties such as maximize, - fullscreen, and minimize, set application-specific metadata like title and - id, and well as trigger user interactive operations such as interactive - resize and move. -+ -+ Unmapping an xdg_toplevel means that the surface cannot be shown -+ by the compositor until it is explicitly mapped again. -+ All active operations (e.g., move, resize) are canceled and all -+ attributes (e.g. title, state, stacking, ...) are discarded for -+ an xdg_toplevel surface when it is unmapped. -+ -+ Attaching a null buffer to a toplevel unmaps the surface. - </description> - - <request name="destroy" type="destructor"> - <description summary="destroy the xdg_toplevel"> -- Unmap and destroy the window. The window will be effectively -- hidden from the user's point of view, and all state like -- maximization, fullscreen, and so on, will be lost. -+ This request destroys the role surface and unmaps the surface; -+ see "Unmapping" behavior in interface section for details. - </description> - </request> - - <request name="set_parent"> - <description summary="set the parent of this surface"> -- Set the "parent" of this surface. This window should be stacked -- above a parent. The parent surface must be mapped as long as this -- surface is mapped. -+ Set the "parent" of this surface. This surface should be stacked -+ above the parent surface and all other ancestor surfaces. - - Parent windows should be set on dialogs, toolboxes, or other - "auxiliary" surfaces, so that the parent is raised when the dialog - is raised. -+ -+ Setting a null parent for a child window removes any parent-child -+ relationship for the child. Setting a null parent for a window which -+ currently has no parent is a no-op. -+ -+ If the parent is unmapped then its children are managed as -+ though the parent of the now-unmapped parent has become the -+ parent of this surface. If no parent exists for the now-unmapped -+ parent then the children are managed as though they have no -+ parent surface. - </description> -- <arg name="parent" type="object" interface="zxdg_toplevel_v6" allow-null="true"/> -+ <arg name="parent" type="object" interface="xdg_toplevel" allow-null="true"/> - </request> - - <request name="set_title"> -@@ -573,6 +604,9 @@ - For example, "org.freedesktop.FooViewer" where the .desktop file is - "org.freedesktop.FooViewer.desktop". - -+ Like other properties, a set_app_id request can be sent after the -+ xdg_toplevel has been mapped to update the property. -+ - See the desktop-entry specification [0] for more details on - application identifiers and how they relate to well-known D-Bus - names and .desktop files. -@@ -693,12 +727,18 @@ - <description summary="the surface is maximized"> - The surface is maximized. The window geometry specified in the configure - event must be obeyed by the client. -+ -+ The client should draw without shadow or other -+ decoration outside of the window geometry. - </description> - </entry> - <entry name="fullscreen" value="2" summary="the surface is fullscreen"> - <description summary="the surface is fullscreen"> -- The surface is fullscreen. The window geometry specified in the configure -- event must be obeyed by the client. -+ The surface is fullscreen. The window geometry specified in the -+ configure event is a maximum; the client cannot resize beyond it. For -+ a surface to cover the whole fullscreened area, the geometry -+ dimensions must be obeyed by the client. For more details, see -+ xdg_toplevel.set_fullscreen. - </description> - </entry> - <entry name="resizing" value="3" summary="the surface is being resized"> -@@ -716,6 +756,30 @@ - keyboard or pointer focus. - </description> - </entry> -+ <entry name="tiled_left" value="5" since="2"> -+ <description summary="the surface is tiled"> -+ The window is currently in a tiled layout and the left edge is -+ considered to be adjacent to another part of the tiling grid. -+ </description> -+ </entry> -+ <entry name="tiled_right" value="6" since="2"> -+ <description summary="the surface is tiled"> -+ The window is currently in a tiled layout and the right edge is -+ considered to be adjacent to another part of the tiling grid. -+ </description> -+ </entry> -+ <entry name="tiled_top" value="7" since="2"> -+ <description summary="the surface is tiled"> -+ The window is currently in a tiled layout and the top edge is -+ considered to be adjacent to another part of the tiling grid. -+ </description> -+ </entry> -+ <entry name="tiled_bottom" value="8" since="2"> -+ <description summary="the surface is tiled"> -+ The window is currently in a tiled layout and the bottom edge is -+ considered to be adjacent to another part of the tiling grid. -+ </description> -+ </entry> - </enum> - - <request name="set_max_size"> -@@ -805,12 +869,11 @@ - Maximize the surface. - - After requesting that the surface should be maximized, the compositor -- will respond by emitting a configure event with the "maximized" state -- and the required window geometry. The client should then update its -- content, drawing it in a maximized state, i.e. without shadow or other -- decoration outside of the window geometry. The client must also -- acknowledge the configure when committing the new content (see -- ack_configure). -+ will respond by emitting a configure event. Whether this configure -+ actually sets the window maximized is subject to compositor policies. -+ The client must then update its content, drawing in the configured -+ state. The client must also acknowledge the configure when committing -+ the new content (see ack_configure). - - It is up to the compositor to decide how and where to maximize the - surface, for example which output and what region of the screen should -@@ -818,6 +881,10 @@ - - If the surface was already maximized, the compositor will still emit - a configure event with the "maximized" state. -+ -+ If the surface is in a fullscreen state, this request has no direct -+ effect. It may alter the state the surface is returned to when -+ unmaximized unless overridden by the compositor. - </description> - </request> - -@@ -826,13 +893,13 @@ - Unmaximize the surface. - - After requesting that the surface should be unmaximized, the compositor -- will respond by emitting a configure event without the "maximized" -- state. If available, the compositor will include the window geometry -- dimensions the window had prior to being maximized in the configure -- request. The client must then update its content, drawing it in a -- regular state, i.e. potentially with shadow, etc. The client must also -- acknowledge the configure when committing the new content (see -- ack_configure). -+ will respond by emitting a configure event. Whether this actually -+ un-maximizes the window is subject to compositor policies. -+ If available and applicable, the compositor will include the window -+ geometry dimensions the window had prior to being maximized in the -+ configure event. The client must then update its content, drawing it in -+ the configured state. The client must also acknowledge the configure -+ when committing the new content (see ack_configure). - - It is up to the compositor to position the surface after it was - unmaximized; usually the position the surface had before maximizing, if -@@ -840,24 +907,63 @@ - - If the surface was already not maximized, the compositor will still - emit a configure event without the "maximized" state. -+ -+ If the surface is in a fullscreen state, this request has no direct -+ effect. It may alter the state the surface is returned to when -+ unmaximized unless overridden by the compositor. - </description> - </request> - - <request name="set_fullscreen"> -- <description summary="set the window as fullscreen on a monitor"> -+ <description summary="set the window as fullscreen on an output"> - Make the surface fullscreen. - -- You can specify an output that you would prefer to be fullscreen. -- If this value is NULL, it's up to the compositor to choose which -- display will be used to map this surface. -+ After requesting that the surface should be fullscreened, the -+ compositor will respond by emitting a configure event. Whether the -+ client is actually put into a fullscreen state is subject to compositor -+ policies. The client must also acknowledge the configure when -+ committing the new content (see ack_configure). -+ -+ The output passed by the request indicates the client's preference as -+ to which display it should be set fullscreen on. If this value is NULL, -+ it's up to the compositor to choose which display will be used to map -+ this surface. - - If the surface doesn't cover the whole output, the compositor will - position the surface in the center of the output and compensate with -- black borders filling the rest of the output. -+ with border fill covering the rest of the output. The content of the -+ border fill is undefined, but should be assumed to be in some way that -+ attempts to blend into the surrounding area (e.g. solid black). -+ -+ If the fullscreened surface is not opaque, the compositor must make -+ sure that other screen content not part of the same surface tree (made -+ up of subsurfaces, popups or similarly coupled surfaces) are not -+ visible below the fullscreened surface. - </description> - <arg name="output" type="object" interface="wl_output" allow-null="true"/> - </request> -- <request name="unset_fullscreen" /> -+ -+ <request name="unset_fullscreen"> -+ <description summary="unset the window as fullscreen"> -+ Make the surface no longer fullscreen. -+ -+ After requesting that the surface should be unfullscreened, the -+ compositor will respond by emitting a configure event. -+ Whether this actually removes the fullscreen state of the client is -+ subject to compositor policies. -+ -+ Making a surface unfullscreen sets states for the surface based on the following: -+ * the state(s) it may have had before becoming fullscreen -+ * any state(s) decided by the compositor -+ * any state(s) requested by the client while the surface was fullscreen -+ -+ The compositor may include the previous window geometry dimensions in -+ the configure event, if applicable. -+ -+ The client must also acknowledge the configure when committing the new -+ content (see ack_configure). -+ </description> -+ </request> - - <request name="set_minimized"> - <description summary="set the window as minimized"> -@@ -913,7 +1019,7 @@ - </event> - </interface> - -- <interface name="zxdg_popup_v6" version="1"> -+ <interface name="xdg_popup" version="2"> - <description summary="short-lived, popup surfaces for menus"> - A popup surface is a short-lived, temporary surface. It can be used to - implement for example menus, popovers, tooltips and other similar user -@@ -931,9 +1037,6 @@ - surface of their own is clicked should dismiss the popup using the destroy - request. - -- The parent surface must have either the xdg_toplevel or xdg_popup surface -- role. -- - A newly created xdg_popup will be stacked on top of all previously created - xdg_popup surfaces associated with the same xdg_toplevel. - -diff --git a/vm_tools/sommelier/sommelier-xdg-shell.c b/vm_tools/sommelier/sommelier-xdg-shell.c -index ecd0fc647..a3ba0d6e1 100644 ---- a/vm_tools/sommelier/sommelier-xdg-shell.c -+++ b/vm_tools/sommelier/sommelier-xdg-shell.c -@@ -7,37 +7,37 @@ - #include <assert.h> - #include <stdlib.h> - --#include "xdg-shell-unstable-v6-client-protocol.h" --#include "xdg-shell-unstable-v6-server-protocol.h" -+#include "xdg-shell-client-protocol.h" -+#include "xdg-shell-server-protocol.h" - --struct sl_host_xdg_shell { -+struct sl_host_xdg_wm_base { - struct sl_context* ctx; - struct wl_resource* resource; -- struct zxdg_shell_v6* proxy; -+ struct xdg_wm_base* proxy; - }; - - struct sl_host_xdg_surface { - struct sl_context* ctx; - struct wl_resource* resource; -- struct zxdg_surface_v6* proxy; -+ struct xdg_surface* proxy; - }; - - struct sl_host_xdg_toplevel { - struct sl_context* ctx; - struct wl_resource* resource; -- struct zxdg_toplevel_v6* proxy; -+ struct xdg_toplevel* proxy; - }; - - struct sl_host_xdg_popup { - struct sl_context* ctx; - struct wl_resource* resource; -- struct zxdg_popup_v6* proxy; -+ struct xdg_popup* proxy; - }; - - struct sl_host_xdg_positioner { - struct sl_context* ctx; - struct wl_resource* resource; -- struct zxdg_positioner_v6* proxy; -+ struct xdg_positioner* proxy; - }; - - static void sl_xdg_positioner_destroy(struct wl_client* client, -@@ -52,7 +52,7 @@ static void sl_xdg_positioner_set_size(struct wl_client* client, - struct sl_host_xdg_positioner* host = wl_resource_get_user_data(resource); - double scale = host->ctx->scale; - -- zxdg_positioner_v6_set_size(host->proxy, width / scale, height / scale); -+ xdg_positioner_set_size(host->proxy, width / scale, height / scale); - } - - static void sl_xdg_positioner_set_anchor_rect(struct wl_client* client, -@@ -70,7 +70,7 @@ static void sl_xdg_positioner_set_anchor_rect(struct wl_client* client, - x2 = (x + width) / scale; - y2 = (y + height) / scale; - -- zxdg_positioner_v6_set_anchor_rect(host->proxy, x1, y1, x2 - x1, y2 - y1); -+ xdg_positioner_set_anchor_rect(host->proxy, x1, y1, x2 - x1, y2 - y1); - } - - static void sl_xdg_positioner_set_anchor(struct wl_client* client, -@@ -78,7 +78,7 @@ static void sl_xdg_positioner_set_anchor(struct wl_client* client, - uint32_t anchor) { - struct sl_host_xdg_positioner* host = wl_resource_get_user_data(resource); - -- zxdg_positioner_v6_set_anchor(host->proxy, anchor); -+ xdg_positioner_set_anchor(host->proxy, anchor); - } - - static void sl_xdg_positioner_set_gravity(struct wl_client* client, -@@ -86,7 +86,7 @@ static void sl_xdg_positioner_set_gravity(struct wl_client* client, - uint32_t gravity) { - struct sl_host_xdg_positioner* host = wl_resource_get_user_data(resource); - -- zxdg_positioner_v6_set_gravity(host->proxy, gravity); -+ xdg_positioner_set_gravity(host->proxy, gravity); - } - - static void sl_xdg_positioner_set_constraint_adjustment( -@@ -95,8 +95,8 @@ static void sl_xdg_positioner_set_constraint_adjustment( - uint32_t constraint_adjustment) { - struct sl_host_xdg_positioner* host = wl_resource_get_user_data(resource); - -- zxdg_positioner_v6_set_constraint_adjustment(host->proxy, -- constraint_adjustment); -+ xdg_positioner_set_constraint_adjustment(host->proxy, -+ constraint_adjustment); - } - - static void sl_xdg_positioner_set_offset(struct wl_client* client, -@@ -106,10 +106,10 @@ static void sl_xdg_positioner_set_offset(struct wl_client* client, - struct sl_host_xdg_positioner* host = wl_resource_get_user_data(resource); - double scale = host->ctx->scale; - -- zxdg_positioner_v6_set_offset(host->proxy, x / scale, y / scale); -+ xdg_positioner_set_offset(host->proxy, x / scale, y / scale); - } - --static const struct zxdg_positioner_v6_interface -+static const struct xdg_positioner_interface - sl_xdg_positioner_implementation = { - sl_xdg_positioner_destroy, - sl_xdg_positioner_set_size, -@@ -122,7 +122,7 @@ static const struct zxdg_positioner_v6_interface - static void sl_destroy_host_xdg_positioner(struct wl_resource* resource) { - struct sl_host_xdg_positioner* host = wl_resource_get_user_data(resource); - -- zxdg_positioner_v6_destroy(host->proxy); -+ xdg_positioner_destroy(host->proxy); - wl_resource_set_user_data(resource, NULL); - free(host); - } -@@ -139,19 +139,19 @@ static void sl_xdg_popup_grab(struct wl_client* client, - struct sl_host_xdg_popup* host = wl_resource_get_user_data(resource); - struct sl_host_seat* host_seat = wl_resource_get_user_data(seat_resource); - -- zxdg_popup_v6_grab(host->proxy, host_seat->proxy, serial); -+ xdg_popup_grab(host->proxy, host_seat->proxy, serial); - } - --static const struct zxdg_popup_v6_interface sl_xdg_popup_implementation = { -+static const struct xdg_popup_interface sl_xdg_popup_implementation = { - sl_xdg_popup_destroy, sl_xdg_popup_grab}; - - static void sl_xdg_popup_configure(void* data, -- struct zxdg_popup_v6* xdg_popup, -+ struct xdg_popup* xdg_popup, - int32_t x, - int32_t y, - int32_t width, - int32_t height) { -- struct sl_host_xdg_popup* host = zxdg_popup_v6_get_user_data(xdg_popup); -+ struct sl_host_xdg_popup* host = xdg_popup_get_user_data(xdg_popup); - double scale = host->ctx->scale; - int32_t x1, y1, x2, y2; - -@@ -160,23 +160,23 @@ static void sl_xdg_popup_configure(void* data, - x2 = (x + width) * scale; - y2 = (y + height) * scale; - -- zxdg_popup_v6_send_configure(host->resource, x1, y1, x2 - x1, y2 - y1); -+ xdg_popup_send_configure(host->resource, x1, y1, x2 - x1, y2 - y1); - } - - static void sl_xdg_popup_popup_done(void* data, -- struct zxdg_popup_v6* xdg_popup) { -- struct sl_host_xdg_popup* host = zxdg_popup_v6_get_user_data(xdg_popup); -+ struct xdg_popup* xdg_popup) { -+ struct sl_host_xdg_popup* host = xdg_popup_get_user_data(xdg_popup); - -- zxdg_popup_v6_send_popup_done(host->resource); -+ xdg_popup_send_popup_done(host->resource); - } - --static const struct zxdg_popup_v6_listener sl_xdg_popup_listener = { -+static const struct xdg_popup_listener sl_xdg_popup_listener = { - sl_xdg_popup_configure, sl_xdg_popup_popup_done}; - - static void sl_destroy_host_xdg_popup(struct wl_resource* resource) { - struct sl_host_xdg_popup* host = wl_resource_get_user_data(resource); - -- zxdg_popup_v6_destroy(host->proxy); -+ xdg_popup_destroy(host->proxy); - wl_resource_set_user_data(resource, NULL); - free(host); - } -@@ -193,8 +193,8 @@ static void sl_xdg_toplevel_set_parent(struct wl_client* client, - struct sl_host_xdg_toplevel* host_parent = - parent_resource ? wl_resource_get_user_data(parent_resource) : NULL; - -- zxdg_toplevel_v6_set_parent(host->proxy, -- host_parent ? host_parent->proxy : NULL); -+ xdg_toplevel_set_parent(host->proxy, -+ host_parent ? host_parent->proxy : NULL); - } - - static void sl_xdg_toplevel_set_title(struct wl_client* client, -@@ -202,7 +202,7 @@ static void sl_xdg_toplevel_set_title(struct wl_client* client, - const char* title) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_set_title(host->proxy, title); -+ xdg_toplevel_set_title(host->proxy, title); - } - - static void sl_xdg_toplevel_set_app_id(struct wl_client* client, -@@ -210,7 +210,7 @@ static void sl_xdg_toplevel_set_app_id(struct wl_client* client, - const char* app_id) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_set_app_id(host->proxy, app_id); -+ xdg_toplevel_set_app_id(host->proxy, app_id); - } - - static void sl_xdg_toplevel_show_window_menu(struct wl_client* client, -@@ -223,7 +223,7 @@ static void sl_xdg_toplevel_show_window_menu(struct wl_client* client, - struct sl_host_seat* host_seat = - seat_resource ? wl_resource_get_user_data(seat_resource) : NULL; - -- zxdg_toplevel_v6_show_window_menu( -+ xdg_toplevel_show_window_menu( - host->proxy, host_seat ? host_seat->proxy : NULL, serial, x, y); - } - -@@ -235,8 +235,8 @@ static void sl_xdg_toplevel_move(struct wl_client* client, - struct sl_host_seat* host_seat = - seat_resource ? wl_resource_get_user_data(seat_resource) : NULL; - -- zxdg_toplevel_v6_move(host->proxy, host_seat ? host_seat->proxy : NULL, -- serial); -+ xdg_toplevel_move(host->proxy, host_seat ? host_seat->proxy : NULL, -+ serial); - } - - static void sl_xdg_toplevel_resize(struct wl_client* client, -@@ -248,8 +248,8 @@ static void sl_xdg_toplevel_resize(struct wl_client* client, - struct sl_host_seat* host_seat = - seat_resource ? wl_resource_get_user_data(seat_resource) : NULL; - -- zxdg_toplevel_v6_resize(host->proxy, host_seat ? host_seat->proxy : NULL, -- serial, edges); -+ xdg_toplevel_resize(host->proxy, host_seat ? host_seat->proxy : NULL, -+ serial, edges); - } - - static void sl_xdg_toplevel_set_max_size(struct wl_client* client, -@@ -258,7 +258,7 @@ static void sl_xdg_toplevel_set_max_size(struct wl_client* client, - int32_t height) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_set_max_size(host->proxy, width, height); -+ xdg_toplevel_set_max_size(host->proxy, width, height); - } - - static void sl_xdg_toplevel_set_min_size(struct wl_client* client, -@@ -267,21 +267,21 @@ static void sl_xdg_toplevel_set_min_size(struct wl_client* client, - int32_t height) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_set_min_size(host->proxy, width, height); -+ xdg_toplevel_set_min_size(host->proxy, width, height); - } - - static void sl_xdg_toplevel_set_maximized(struct wl_client* client, - struct wl_resource* resource) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_set_maximized(host->proxy); -+ xdg_toplevel_set_maximized(host->proxy); - } - - static void sl_xdg_toplevel_unset_maximized(struct wl_client* client, - struct wl_resource* resource) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_unset_maximized(host->proxy); -+ xdg_toplevel_unset_maximized(host->proxy); - } - - static void sl_xdg_toplevel_set_fullscreen( -@@ -292,25 +292,25 @@ static void sl_xdg_toplevel_set_fullscreen( - struct sl_host_output* host_output = - output_resource ? wl_resource_get_user_data(output_resource) : NULL; - -- zxdg_toplevel_v6_set_fullscreen(host->proxy, -- host_output ? host_output->proxy : NULL); -+ xdg_toplevel_set_fullscreen(host->proxy, -+ host_output ? host_output->proxy : NULL); - } - - static void sl_xdg_toplevel_unset_fullscreen(struct wl_client* client, - struct wl_resource* resource) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_unset_fullscreen(host->proxy); -+ xdg_toplevel_unset_fullscreen(host->proxy); - } - - static void sl_xdg_toplevel_set_minimized(struct wl_client* client, - struct wl_resource* resource) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_set_minimized(host->proxy); -+ xdg_toplevel_set_minimized(host->proxy); - } - --static const struct zxdg_toplevel_v6_interface sl_xdg_toplevel_implementation = -+static const struct xdg_toplevel_interface sl_xdg_toplevel_implementation = - {sl_xdg_toplevel_destroy, sl_xdg_toplevel_set_parent, - sl_xdg_toplevel_set_title, sl_xdg_toplevel_set_app_id, - sl_xdg_toplevel_show_window_menu, sl_xdg_toplevel_move, -@@ -320,33 +320,33 @@ static const struct zxdg_toplevel_v6_interface sl_xdg_toplevel_implementation = - sl_xdg_toplevel_unset_fullscreen, sl_xdg_toplevel_set_minimized}; - - static void sl_xdg_toplevel_configure(void* data, -- struct zxdg_toplevel_v6* xdg_toplevel, -+ struct xdg_toplevel* xdg_toplevel, - int32_t width, - int32_t height, - struct wl_array* states) { - struct sl_host_xdg_toplevel* host = -- zxdg_toplevel_v6_get_user_data(xdg_toplevel); -+ xdg_toplevel_get_user_data(xdg_toplevel); - double scale = host->ctx->scale; - -- zxdg_toplevel_v6_send_configure(host->resource, width * scale, height * scale, -+ xdg_toplevel_send_configure(host->resource, width * scale, height * scale, - states); - } - - static void sl_xdg_toplevel_close(void* data, -- struct zxdg_toplevel_v6* xdg_toplevel) { -+ struct xdg_toplevel* xdg_toplevel) { - struct sl_host_xdg_toplevel* host = -- zxdg_toplevel_v6_get_user_data(xdg_toplevel); -+ xdg_toplevel_get_user_data(xdg_toplevel); - -- zxdg_toplevel_v6_send_close(host->resource); -+ xdg_toplevel_send_close(host->resource); - } - --static const struct zxdg_toplevel_v6_listener sl_xdg_toplevel_listener = { -+static const struct xdg_toplevel_listener sl_xdg_toplevel_listener = { - sl_xdg_toplevel_configure, sl_xdg_toplevel_close}; - - static void sl_destroy_host_xdg_toplevel(struct wl_resource* resource) { - struct sl_host_xdg_toplevel* host = wl_resource_get_user_data(resource); - -- zxdg_toplevel_v6_destroy(host->proxy); -+ xdg_toplevel_destroy(host->proxy); - wl_resource_set_user_data(resource, NULL); - free(host); - } -@@ -367,14 +367,15 @@ static void sl_xdg_surface_get_toplevel(struct wl_client* client, - - host_xdg_toplevel->ctx = host->ctx; - host_xdg_toplevel->resource = -- wl_resource_create(client, &zxdg_toplevel_v6_interface, 1, id); -+ wl_resource_create(client, &xdg_toplevel_interface, -+ wl_resource_get_version(resource), id); - wl_resource_set_implementation( - host_xdg_toplevel->resource, &sl_xdg_toplevel_implementation, - host_xdg_toplevel, sl_destroy_host_xdg_toplevel); -- host_xdg_toplevel->proxy = zxdg_surface_v6_get_toplevel(host->proxy); -- zxdg_toplevel_v6_set_user_data(host_xdg_toplevel->proxy, host_xdg_toplevel); -- zxdg_toplevel_v6_add_listener(host_xdg_toplevel->proxy, -- &sl_xdg_toplevel_listener, host_xdg_toplevel); -+ host_xdg_toplevel->proxy = xdg_surface_get_toplevel(host->proxy); -+ xdg_toplevel_set_user_data(host_xdg_toplevel->proxy, host_xdg_toplevel); -+ xdg_toplevel_add_listener(host_xdg_toplevel->proxy, -+ &sl_xdg_toplevel_listener, host_xdg_toplevel); - } - - static void sl_xdg_surface_get_popup(struct wl_client* client, -@@ -394,15 +395,16 @@ static void sl_xdg_surface_get_popup(struct wl_client* client, - - host_xdg_popup->ctx = host->ctx; - host_xdg_popup->resource = -- wl_resource_create(client, &zxdg_popup_v6_interface, 1, id); -+ wl_resource_create(client, &xdg_popup_interface, -+ wl_resource_get_version(resource), id); - wl_resource_set_implementation(host_xdg_popup->resource, - &sl_xdg_popup_implementation, host_xdg_popup, - sl_destroy_host_xdg_popup); -- host_xdg_popup->proxy = zxdg_surface_v6_get_popup( -+ host_xdg_popup->proxy = xdg_surface_get_popup( - host->proxy, host_parent->proxy, host_positioner->proxy); -- zxdg_popup_v6_set_user_data(host_xdg_popup->proxy, host_xdg_popup); -- zxdg_popup_v6_add_listener(host_xdg_popup->proxy, &sl_xdg_popup_listener, -- host_xdg_popup); -+ xdg_popup_set_user_data(host_xdg_popup->proxy, host_xdg_popup); -+ xdg_popup_add_listener(host_xdg_popup->proxy, &sl_xdg_popup_listener, -+ host_xdg_popup); - } - - static void sl_xdg_surface_set_window_geometry(struct wl_client* client, -@@ -420,7 +422,7 @@ static void sl_xdg_surface_set_window_geometry(struct wl_client* client, - x2 = (x + width) / scale; - y2 = (y + height) / scale; - -- zxdg_surface_v6_set_window_geometry(host->proxy, x1, y1, x2 - x1, y2 - y1); -+ xdg_surface_set_window_geometry(host->proxy, x1, y1, x2 - x1, y2 - y1); - } - - static void sl_xdg_surface_ack_configure(struct wl_client* client, -@@ -428,63 +430,64 @@ static void sl_xdg_surface_ack_configure(struct wl_client* client, - uint32_t serial) { - struct sl_host_xdg_surface* host = wl_resource_get_user_data(resource); - -- zxdg_surface_v6_ack_configure(host->proxy, serial); -+ xdg_surface_ack_configure(host->proxy, serial); - } - --static const struct zxdg_surface_v6_interface sl_xdg_surface_implementation = { -+static const struct xdg_surface_interface sl_xdg_surface_implementation = { - sl_xdg_surface_destroy, sl_xdg_surface_get_toplevel, - sl_xdg_surface_get_popup, sl_xdg_surface_set_window_geometry, - sl_xdg_surface_ack_configure}; - - static void sl_xdg_surface_configure(void* data, -- struct zxdg_surface_v6* xdg_surface, -+ struct xdg_surface* xdg_surface, - uint32_t serial) { -- struct sl_host_xdg_surface* host = zxdg_surface_v6_get_user_data(xdg_surface); -+ struct sl_host_xdg_surface* host = xdg_surface_get_user_data(xdg_surface); - -- zxdg_surface_v6_send_configure(host->resource, serial); -+ xdg_surface_send_configure(host->resource, serial); - } - --static const struct zxdg_surface_v6_listener sl_xdg_surface_listener = { -+static const struct xdg_surface_listener sl_xdg_surface_listener = { - sl_xdg_surface_configure}; - - static void sl_destroy_host_xdg_surface(struct wl_resource* resource) { - struct sl_host_xdg_surface* host = wl_resource_get_user_data(resource); - -- zxdg_surface_v6_destroy(host->proxy); -+ xdg_surface_destroy(host->proxy); - wl_resource_set_user_data(resource, NULL); - free(host); - } - --static void sl_xdg_shell_destroy(struct wl_client* client, -+static void sl_xdg_wm_base_destroy(struct wl_client* client, - struct wl_resource* resource) { - wl_resource_destroy(resource); - } - --static void sl_xdg_shell_create_positioner(struct wl_client* client, -+static void sl_xdg_wm_base_create_positioner(struct wl_client* client, - struct wl_resource* resource, - uint32_t id) { -- struct sl_host_xdg_shell* host = wl_resource_get_user_data(resource); -+ struct sl_host_xdg_wm_base* host = wl_resource_get_user_data(resource); - struct sl_host_xdg_positioner* host_xdg_positioner; - - host_xdg_positioner = malloc(sizeof(*host_xdg_positioner)); - assert(host_xdg_positioner); - - host_xdg_positioner->ctx = host->ctx; -- host_xdg_positioner->resource = -- wl_resource_create(client, &zxdg_positioner_v6_interface, 1, id); -+ host_xdg_positioner->resource = wl_resource_create( -+ client, &xdg_positioner_interface, -+ wl_resource_get_version(resource), id); - wl_resource_set_implementation( - host_xdg_positioner->resource, &sl_xdg_positioner_implementation, - host_xdg_positioner, sl_destroy_host_xdg_positioner); -- host_xdg_positioner->proxy = zxdg_shell_v6_create_positioner(host->proxy); -- zxdg_positioner_v6_set_user_data(host_xdg_positioner->proxy, -- host_xdg_positioner); -+ host_xdg_positioner->proxy = xdg_wm_base_create_positioner(host->proxy); -+ xdg_positioner_set_user_data(host_xdg_positioner->proxy, -+ host_xdg_positioner); - } - --static void sl_xdg_shell_get_xdg_surface(struct wl_client* client, -+static void sl_xdg_wm_base_get_xdg_surface(struct wl_client* client, - struct wl_resource* resource, - uint32_t id, - struct wl_resource* surface_resource) { -- struct sl_host_xdg_shell* host = wl_resource_get_user_data(resource); -+ struct sl_host_xdg_wm_base* host = wl_resource_get_user_data(resource); - struct sl_host_surface* host_surface = - wl_resource_get_user_data(surface_resource); - struct sl_host_xdg_surface* host_xdg_surface; -@@ -493,71 +496,75 @@ static void sl_xdg_shell_get_xdg_surface(struct wl_client* client, - assert(host_xdg_surface); - - host_xdg_surface->ctx = host->ctx; -- host_xdg_surface->resource = -- wl_resource_create(client, &zxdg_surface_v6_interface, 1, id); -+ host_xdg_surface->resource = wl_resource_create( -+ client, &xdg_surface_interface, -+ wl_resource_get_version(resource), id); - wl_resource_set_implementation(host_xdg_surface->resource, - &sl_xdg_surface_implementation, - host_xdg_surface, sl_destroy_host_xdg_surface); - host_xdg_surface->proxy = -- zxdg_shell_v6_get_xdg_surface(host->proxy, host_surface->proxy); -- zxdg_surface_v6_set_user_data(host_xdg_surface->proxy, host_xdg_surface); -- zxdg_surface_v6_add_listener(host_xdg_surface->proxy, -- &sl_xdg_surface_listener, host_xdg_surface); -+ xdg_wm_base_get_xdg_surface(host->proxy, host_surface->proxy); -+ xdg_surface_set_user_data(host_xdg_surface->proxy, host_xdg_surface); -+ xdg_surface_add_listener(host_xdg_surface->proxy, -+ &sl_xdg_surface_listener, host_xdg_surface); - host_surface->has_role = 1; - } - --static void sl_xdg_shell_pong(struct wl_client* client, -+static void sl_xdg_wm_base_pong(struct wl_client* client, - struct wl_resource* resource, - uint32_t serial) { -- struct sl_host_xdg_shell* host = wl_resource_get_user_data(resource); -+ struct sl_host_xdg_wm_base* host = wl_resource_get_user_data(resource); - -- zxdg_shell_v6_pong(host->proxy, serial); -+ xdg_wm_base_pong(host->proxy, serial); - } - --static const struct zxdg_shell_v6_interface sl_xdg_shell_implementation = { -- sl_xdg_shell_destroy, sl_xdg_shell_create_positioner, -- sl_xdg_shell_get_xdg_surface, sl_xdg_shell_pong}; -+static const struct xdg_wm_base_interface sl_xdg_wm_base_implementation = { -+ sl_xdg_wm_base_destroy, sl_xdg_wm_base_create_positioner, -+ sl_xdg_wm_base_get_xdg_surface, sl_xdg_wm_base_pong}; - --static void sl_xdg_shell_ping(void* data, -- struct zxdg_shell_v6* xdg_shell, -+static void sl_xdg_wm_base_ping(void* data, -+ struct xdg_wm_base* xdg_wm_base, - uint32_t serial) { -- struct sl_host_xdg_shell* host = zxdg_shell_v6_get_user_data(xdg_shell); -+ struct sl_host_xdg_wm_base* host = xdg_wm_base_get_user_data(xdg_wm_base); - -- zxdg_shell_v6_send_ping(host->resource, serial); -+ xdg_wm_base_send_ping(host->resource, serial); - } - --static const struct zxdg_shell_v6_listener sl_xdg_shell_listener = { -- sl_xdg_shell_ping}; -+static const struct xdg_wm_base_listener sl_xdg_wm_base_listener = { -+ sl_xdg_wm_base_ping}; - --static void sl_destroy_host_xdg_shell(struct wl_resource* resource) { -- struct sl_host_xdg_shell* host = wl_resource_get_user_data(resource); -+static void sl_destroy_host_xdg_wm_base(struct wl_resource* resource) { -+ struct sl_host_xdg_wm_base* host = wl_resource_get_user_data(resource); - -- zxdg_shell_v6_destroy(host->proxy); -+ xdg_wm_base_destroy(host->proxy); - wl_resource_set_user_data(resource, NULL); - free(host); - } - --static void sl_bind_host_xdg_shell(struct wl_client* client, -+static void sl_bind_host_xdg_wm_base(struct wl_client* client, - void* data, - uint32_t version, - uint32_t id) { - struct sl_context* ctx = (struct sl_context*)data; -- struct sl_host_xdg_shell* host; -+ struct sl_host_xdg_wm_base* host; - - host = malloc(sizeof(*host)); - assert(host); - host->ctx = ctx; -- host->resource = wl_resource_create(client, &zxdg_shell_v6_interface, 1, id); -- wl_resource_set_implementation(host->resource, &sl_xdg_shell_implementation, -- host, sl_destroy_host_xdg_shell); -+ host->resource = wl_resource_create(client, &xdg_wm_base_interface, -+ ctx->xdg_wm_base->id, id); -+ wl_resource_set_implementation(host->resource, &sl_xdg_wm_base_implementation, -+ host, sl_destroy_host_xdg_wm_base); - host->proxy = - wl_registry_bind(wl_display_get_registry(ctx->display), -- ctx->xdg_shell->id, &zxdg_shell_v6_interface, 1); -- zxdg_shell_v6_set_user_data(host->proxy, host); -- zxdg_shell_v6_add_listener(host->proxy, &sl_xdg_shell_listener, host); -+ ctx->xdg_wm_base->id, &xdg_wm_base_interface, -+ ctx->xdg_wm_base->version); -+ xdg_wm_base_set_user_data(host->proxy, host); -+ xdg_wm_base_add_listener(host->proxy, &sl_xdg_wm_base_listener, host); - } - --struct sl_global* sl_xdg_shell_global_create(struct sl_context* ctx) { -- return sl_global_create(ctx, &zxdg_shell_v6_interface, 1, ctx, -- sl_bind_host_xdg_shell); -+struct sl_global* sl_xdg_wm_base_global_create(struct sl_context* ctx) { -+ return sl_global_create(ctx, &xdg_wm_base_interface, -+ ctx->xdg_wm_base->version, ctx, -+ sl_bind_host_xdg_wm_base); - } -diff --git a/vm_tools/sommelier/sommelier.c b/vm_tools/sommelier/sommelier.c -index 98e101135..9a56f350d 100644 ---- a/vm_tools/sommelier/sommelier.c -+++ b/vm_tools/sommelier/sommelier.c -@@ -35,7 +35,7 @@ - #include "relative-pointer-unstable-v1-client-protocol.h" - #include "text-input-unstable-v1-client-protocol.h" - #include "viewporter-client-protocol.h" --#include "xdg-shell-unstable-v6-client-protocol.h" -+#include "xdg-shell-client-protocol.h" - - #define errno_assert(rv) \ - { \ -@@ -281,14 +281,14 @@ void sl_sync_point_destroy(struct sl_sync_point* sync_point) { - free(sync_point); - } - --static void sl_internal_xdg_shell_ping(void* data, -- struct zxdg_shell_v6* xdg_shell, -+static void sl_internal_xdg_wm_base_ping(void* data, -+ struct xdg_wm_base* xdg_wm_base, - uint32_t serial) { -- zxdg_shell_v6_pong(xdg_shell, serial); -+ xdg_wm_base_pong(xdg_wm_base, serial); - } - --static const struct zxdg_shell_v6_listener sl_internal_xdg_shell_listener = { -- sl_internal_xdg_shell_ping}; -+static const struct xdg_wm_base_listener sl_internal_xdg_wm_base_listener = { -+ sl_internal_xdg_wm_base_ping}; - - static void sl_send_configure_notify(struct sl_window* window) { - xcb_configure_notify_event_t event = { -@@ -451,8 +451,8 @@ int sl_process_pending_configure_acks(struct sl_window* window, - } - - if (window->xdg_surface) { -- zxdg_surface_v6_ack_configure(window->xdg_surface, -- window->pending_config.serial); -+ xdg_surface_ack_configure(window->xdg_surface, -+ window->pending_config.serial); - } - window->pending_config.serial = 0; - -@@ -463,8 +463,8 @@ int sl_process_pending_configure_acks(struct sl_window* window, - } - - static void sl_internal_xdg_surface_configure( -- void* data, struct zxdg_surface_v6* xdg_surface, uint32_t serial) { -- struct sl_window* window = zxdg_surface_v6_get_user_data(xdg_surface); -+ void* data, struct xdg_surface* xdg_surface, uint32_t serial) { -+ struct sl_window* window = xdg_surface_get_user_data(xdg_surface); - - window->next_config.serial = serial; - if (!window->pending_config.serial) { -@@ -485,16 +485,16 @@ static void sl_internal_xdg_surface_configure( - } - } - --static const struct zxdg_surface_v6_listener sl_internal_xdg_surface_listener = -+static const struct xdg_surface_listener sl_internal_xdg_surface_listener = - {sl_internal_xdg_surface_configure}; - - static void sl_internal_xdg_toplevel_configure( - void* data, -- struct zxdg_toplevel_v6* xdg_toplevel, -+ struct xdg_toplevel* xdg_toplevel, - int32_t width, - int32_t height, - struct wl_array* states) { -- struct sl_window* window = zxdg_toplevel_v6_get_user_data(xdg_toplevel); -+ struct sl_window* window = xdg_toplevel_get_user_data(xdg_toplevel); - int activated = 0; - uint32_t* state; - int i = 0; -@@ -524,21 +524,21 @@ static void sl_internal_xdg_toplevel_configure( - - window->allow_resize = 1; - wl_array_for_each(state, states) { -- if (*state == ZXDG_TOPLEVEL_V6_STATE_FULLSCREEN) { -+ if (*state == XDG_TOPLEVEL_STATE_FULLSCREEN) { - window->allow_resize = 0; - window->next_config.states[i++] = - window->ctx->atoms[ATOM_NET_WM_STATE_FULLSCREEN].value; - } -- if (*state == ZXDG_TOPLEVEL_V6_STATE_MAXIMIZED) { -+ if (*state == XDG_TOPLEVEL_STATE_MAXIMIZED) { - window->allow_resize = 0; - window->next_config.states[i++] = - window->ctx->atoms[ATOM_NET_WM_STATE_MAXIMIZED_VERT].value; - window->next_config.states[i++] = - window->ctx->atoms[ATOM_NET_WM_STATE_MAXIMIZED_HORZ].value; - } -- if (*state == ZXDG_TOPLEVEL_V6_STATE_ACTIVATED) -+ if (*state == XDG_TOPLEVEL_STATE_ACTIVATED) - activated = 1; -- if (*state == ZXDG_TOPLEVEL_V6_STATE_RESIZING) -+ if (*state == XDG_TOPLEVEL_STATE_RESIZING) - window->allow_resize = 0; - } - -@@ -554,8 +554,8 @@ static void sl_internal_xdg_toplevel_configure( - } - - static void sl_internal_xdg_toplevel_close( -- void* data, struct zxdg_toplevel_v6* xdg_toplevel) { -- struct sl_window* window = zxdg_toplevel_v6_get_user_data(xdg_toplevel); -+ void* data, struct xdg_toplevel* xdg_toplevel) { -+ struct sl_window* window = xdg_toplevel_get_user_data(xdg_toplevel); - xcb_client_message_event_t event = { - .response_type = XCB_CLIENT_MESSAGE, - .format = 32, -@@ -572,21 +572,21 @@ static void sl_internal_xdg_toplevel_close( - XCB_EVENT_MASK_NO_EVENT, (const char*)&event); - } - --static const struct zxdg_toplevel_v6_listener -+static const struct xdg_toplevel_listener - sl_internal_xdg_toplevel_listener = {sl_internal_xdg_toplevel_configure, - sl_internal_xdg_toplevel_close}; - - static void sl_internal_xdg_popup_configure(void* data, -- struct zxdg_popup_v6* xdg_popup, -+ struct xdg_popup* xdg_popup, - int32_t x, - int32_t y, - int32_t width, - int32_t height) {} - - static void sl_internal_xdg_popup_done(void* data, -- struct zxdg_popup_v6* zxdg_popup_v6) {} -+ struct xdg_popup* xdg_popup) {} - --static const struct zxdg_popup_v6_listener sl_internal_xdg_popup_listener = { -+static const struct xdg_popup_listener sl_internal_xdg_popup_listener = { - sl_internal_xdg_popup_configure, sl_internal_xdg_popup_done}; - - static void sl_window_set_wm_state(struct sl_window* window, int state) { -@@ -654,15 +654,15 @@ void sl_window_update(struct sl_window* window) { - window->aura_surface = NULL; - } - if (window->xdg_toplevel) { -- zxdg_toplevel_v6_destroy(window->xdg_toplevel); -+ xdg_toplevel_destroy(window->xdg_toplevel); - window->xdg_toplevel = NULL; - } - if (window->xdg_popup) { -- zxdg_popup_v6_destroy(window->xdg_popup); -+ xdg_popup_destroy(window->xdg_popup); - window->xdg_popup = NULL; - } - if (window->xdg_surface) { -- zxdg_surface_v6_destroy(window->xdg_surface); -+ xdg_surface_destroy(window->xdg_surface); - window->xdg_surface = NULL; - } - window->realized = 0; -@@ -673,8 +673,8 @@ void sl_window_update(struct sl_window* window) { - assert(host_surface); - assert(!host_surface->has_role); - -- assert(ctx->xdg_shell); -- assert(ctx->xdg_shell->internal); -+ assert(ctx->xdg_wm_base); -+ assert(ctx->xdg_wm_base->internal); - - if (window->managed) { - if (window->transient_for != XCB_WINDOW_NONE) { -@@ -736,11 +736,11 @@ void sl_window_update(struct sl_window* window) { - } - - if (!window->xdg_surface) { -- window->xdg_surface = zxdg_shell_v6_get_xdg_surface( -- ctx->xdg_shell->internal, host_surface->proxy); -- zxdg_surface_v6_set_user_data(window->xdg_surface, window); -- zxdg_surface_v6_add_listener(window->xdg_surface, -- &sl_internal_xdg_surface_listener, window); -+ window->xdg_surface = xdg_wm_base_get_xdg_surface( -+ ctx->xdg_wm_base->internal, host_surface->proxy); -+ xdg_surface_set_user_data(window->xdg_surface, window); -+ xdg_surface_add_listener(window->xdg_surface, -+ &sl_internal_xdg_surface_listener, window); - } - - if (ctx->aura_shell) { -@@ -770,50 +770,50 @@ void sl_window_update(struct sl_window* window) { - // window is closed. - if (ctx->xwayland || !parent) { - if (!window->xdg_toplevel) { -- window->xdg_toplevel = zxdg_surface_v6_get_toplevel(window->xdg_surface); -- zxdg_toplevel_v6_set_user_data(window->xdg_toplevel, window); -- zxdg_toplevel_v6_add_listener(window->xdg_toplevel, -+ window->xdg_toplevel = xdg_surface_get_toplevel(window->xdg_surface); -+ xdg_toplevel_set_user_data(window->xdg_toplevel, window); -+ xdg_toplevel_add_listener(window->xdg_toplevel, - &sl_internal_xdg_toplevel_listener, window); - } - if (parent) -- zxdg_toplevel_v6_set_parent(window->xdg_toplevel, parent->xdg_toplevel); -+ xdg_toplevel_set_parent(window->xdg_toplevel, parent->xdg_toplevel); - if (window->name) -- zxdg_toplevel_v6_set_title(window->xdg_toplevel, window->name); -+ xdg_toplevel_set_title(window->xdg_toplevel, window->name); - if (window->size_flags & P_MIN_SIZE) { -- zxdg_toplevel_v6_set_min_size(window->xdg_toplevel, -+ xdg_toplevel_set_min_size(window->xdg_toplevel, - window->min_width / ctx->scale, - window->min_height / ctx->scale); - } - if (window->size_flags & P_MAX_SIZE) { -- zxdg_toplevel_v6_set_max_size(window->xdg_toplevel, -+ xdg_toplevel_set_max_size(window->xdg_toplevel, - window->max_width / ctx->scale, - window->max_height / ctx->scale); - } - if (window->maximized) { -- zxdg_toplevel_v6_set_maximized(window->xdg_toplevel); -+ xdg_toplevel_set_maximized(window->xdg_toplevel); - } - } else if (!window->xdg_popup) { -- struct zxdg_positioner_v6* positioner; -+ struct xdg_positioner* positioner; - -- positioner = zxdg_shell_v6_create_positioner(ctx->xdg_shell->internal); -+ positioner = xdg_wm_base_create_positioner(ctx->xdg_wm_base->internal); - assert(positioner); -- zxdg_positioner_v6_set_anchor( -+ xdg_positioner_set_anchor( - positioner, -- ZXDG_POSITIONER_V6_ANCHOR_TOP | ZXDG_POSITIONER_V6_ANCHOR_LEFT); -- zxdg_positioner_v6_set_gravity( -+ XDG_POSITIONER_ANCHOR_TOP | XDG_POSITIONER_ANCHOR_LEFT); -+ xdg_positioner_set_gravity( - positioner, -- ZXDG_POSITIONER_V6_GRAVITY_BOTTOM | ZXDG_POSITIONER_V6_GRAVITY_RIGHT); -- zxdg_positioner_v6_set_anchor_rect( -+ XDG_POSITIONER_GRAVITY_BOTTOM | XDG_POSITIONER_GRAVITY_RIGHT); -+ xdg_positioner_set_anchor_rect( - positioner, (window->x - parent->x) / ctx->scale, - (window->y - parent->y) / ctx->scale, 1, 1); - -- window->xdg_popup = zxdg_surface_v6_get_popup( -+ window->xdg_popup = xdg_surface_get_popup( - window->xdg_surface, parent->xdg_surface, positioner); -- zxdg_popup_v6_set_user_data(window->xdg_popup, window); -- zxdg_popup_v6_add_listener(window->xdg_popup, -+ xdg_popup_set_user_data(window->xdg_popup, window); -+ xdg_popup_add_listener(window->xdg_popup, - &sl_internal_xdg_popup_listener, window); - -- zxdg_positioner_v6_destroy(positioner); -+ xdg_positioner_destroy(positioner); - } - - if ((window->size_flags & (US_POSITION | P_POSITION)) && parent && -@@ -1177,22 +1177,23 @@ static void sl_registry_handler(void* data, - data_device_manager->host_global = - sl_data_device_manager_global_create(ctx); - } -- } else if (strcmp(interface, "zxdg_shell_v6") == 0) { -- struct sl_xdg_shell* xdg_shell = malloc(sizeof(struct sl_xdg_shell)); -- assert(xdg_shell); -- xdg_shell->ctx = ctx; -- xdg_shell->id = id; -- xdg_shell->internal = NULL; -- xdg_shell->host_global = NULL; -- assert(!ctx->xdg_shell); -- ctx->xdg_shell = xdg_shell; -+ } else if (strcmp(interface, "xdg_wm_base") == 0) { -+ struct sl_xdg_wm_base* xdg_wm_base = malloc(sizeof(struct sl_xdg_wm_base)); -+ assert(xdg_wm_base); -+ xdg_wm_base->ctx = ctx; -+ xdg_wm_base->id = id; -+ xdg_wm_base->version = MIN(2, version); -+ xdg_wm_base->internal = NULL; -+ xdg_wm_base->host_global = NULL; -+ assert(!ctx->xdg_wm_base); -+ ctx->xdg_wm_base = xdg_wm_base; - if (ctx->xwayland) { -- xdg_shell->internal = -- wl_registry_bind(registry, id, &zxdg_shell_v6_interface, 1); -- zxdg_shell_v6_add_listener(xdg_shell->internal, -- &sl_internal_xdg_shell_listener, NULL); -+ xdg_wm_base->internal = -+ wl_registry_bind(registry, id, &xdg_wm_base_interface, 1); -+ xdg_wm_base_add_listener(xdg_wm_base->internal, -+ &sl_internal_xdg_wm_base_listener, NULL); - } else { -- xdg_shell->host_global = sl_xdg_shell_global_create(ctx); -+ xdg_wm_base->host_global = sl_xdg_wm_base_global_create(ctx); - } - } else if (strcmp(interface, "zaura_shell") == 0) { - if (version >= MIN_AURA_SHELL_VERSION) { -@@ -1299,13 +1300,13 @@ static void sl_registry_remover(void* data, - ctx->data_device_manager = NULL; - return; - } -- if (ctx->xdg_shell && ctx->xdg_shell->id == id) { -- if (ctx->xdg_shell->host_global) -- sl_global_destroy(ctx->xdg_shell->host_global); -- if (ctx->xdg_shell->internal) -- zxdg_shell_v6_destroy(ctx->xdg_shell->internal); -- free(ctx->xdg_shell); -- ctx->xdg_shell = NULL; -+ if (ctx->xdg_wm_base && ctx->xdg_wm_base->id == id) { -+ if (ctx->xdg_wm_base->host_global) -+ sl_global_destroy(ctx->xdg_wm_base->host_global); -+ if (ctx->xdg_wm_base->internal) -+ xdg_wm_base_destroy(ctx->xdg_wm_base->internal); -+ free(ctx->xdg_wm_base); -+ ctx->xdg_wm_base = NULL; - return; - } - if (ctx->aura_shell && ctx->aura_shell->id == id) { -@@ -1467,11 +1468,11 @@ static void sl_destroy_window(struct sl_window* window) { - } - - if (window->xdg_popup) -- zxdg_popup_v6_destroy(window->xdg_popup); -+ xdg_popup_destroy(window->xdg_popup); - if (window->xdg_toplevel) -- zxdg_toplevel_v6_destroy(window->xdg_toplevel); -+ xdg_toplevel_destroy(window->xdg_toplevel); - if (window->xdg_surface) -- zxdg_surface_v6_destroy(window->xdg_surface); -+ xdg_surface_destroy(window->xdg_surface); - if (window->aura_surface) - zaura_surface_destroy(window->aura_surface); - -@@ -1915,15 +1916,15 @@ static void sl_handle_configure_request(struct sl_context* ctx, - // that matching contents will arrive. - if (window->xdg_toplevel) { - if (window->pending_config.serial) { -- zxdg_surface_v6_ack_configure(window->xdg_surface, -- window->pending_config.serial); -+ xdg_surface_ack_configure(window->xdg_surface, -+ window->pending_config.serial); - window->pending_config.serial = 0; - window->pending_config.mask = 0; - window->pending_config.states_length = 0; - } - if (window->next_config.serial) { -- zxdg_surface_v6_ack_configure(window->xdg_surface, -- window->next_config.serial); -+ xdg_surface_ack_configure(window->xdg_surface, -+ window->next_config.serial); - window->next_config.serial = 0; - window->next_config.mask = 0; - window->next_config.states_length = 0; -@@ -2044,23 +2045,23 @@ static void sl_handle_configure_notify(struct sl_context* ctx, - static uint32_t sl_resize_edge(int net_wm_moveresize_size) { - switch (net_wm_moveresize_size) { - case NET_WM_MOVERESIZE_SIZE_TOPLEFT: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_TOP_LEFT; -+ return XDG_TOPLEVEL_RESIZE_EDGE_TOP_LEFT; - case NET_WM_MOVERESIZE_SIZE_TOP: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_TOP; -+ return XDG_TOPLEVEL_RESIZE_EDGE_TOP; - case NET_WM_MOVERESIZE_SIZE_TOPRIGHT: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_TOP_RIGHT; -+ return XDG_TOPLEVEL_RESIZE_EDGE_TOP_RIGHT; - case NET_WM_MOVERESIZE_SIZE_RIGHT: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_RIGHT; -+ return XDG_TOPLEVEL_RESIZE_EDGE_RIGHT; - case NET_WM_MOVERESIZE_SIZE_BOTTOMRIGHT: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_BOTTOM_RIGHT; -+ return XDG_TOPLEVEL_RESIZE_EDGE_BOTTOM_RIGHT; - case NET_WM_MOVERESIZE_SIZE_BOTTOM: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_BOTTOM; -+ return XDG_TOPLEVEL_RESIZE_EDGE_BOTTOM; - case NET_WM_MOVERESIZE_SIZE_BOTTOMLEFT: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_BOTTOM_LEFT; -+ return XDG_TOPLEVEL_RESIZE_EDGE_BOTTOM_LEFT; - case NET_WM_MOVERESIZE_SIZE_LEFT: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_LEFT; -+ return XDG_TOPLEVEL_RESIZE_EDGE_LEFT; - default: -- return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_NONE; -+ return XDG_TOPLEVEL_RESIZE_EDGE_NONE; - } - } - -@@ -2107,15 +2108,15 @@ static void sl_handle_client_message(struct sl_context* ctx, - return; - - if (event->data.data32[2] == NET_WM_MOVERESIZE_MOVE) { -- zxdg_toplevel_v6_move(window->xdg_toplevel, seat->proxy, -+ xdg_toplevel_move(window->xdg_toplevel, seat->proxy, - seat->seat->last_serial); - } else { - uint32_t edge = sl_resize_edge(event->data.data32[2]); - -- if (edge == ZXDG_TOPLEVEL_V6_RESIZE_EDGE_NONE) -+ if (edge == XDG_TOPLEVEL_RESIZE_EDGE_NONE) - return; - -- zxdg_toplevel_v6_resize(window->xdg_toplevel, seat->proxy, -+ xdg_toplevel_resize(window->xdg_toplevel, seat->proxy, - seat->seat->last_serial, edge); - } - } -@@ -2134,24 +2135,24 @@ static void sl_handle_client_message(struct sl_context* ctx, - - if (changed[ATOM_NET_WM_STATE_FULLSCREEN]) { - if (action == NET_WM_STATE_ADD) -- zxdg_toplevel_v6_set_fullscreen(window->xdg_toplevel, NULL); -+ xdg_toplevel_set_fullscreen(window->xdg_toplevel, NULL); - else if (action == NET_WM_STATE_REMOVE) -- zxdg_toplevel_v6_unset_fullscreen(window->xdg_toplevel); -+ xdg_toplevel_unset_fullscreen(window->xdg_toplevel); - } - - if (changed[ATOM_NET_WM_STATE_MAXIMIZED_VERT] && - changed[ATOM_NET_WM_STATE_MAXIMIZED_HORZ]) { - if (action == NET_WM_STATE_ADD) -- zxdg_toplevel_v6_set_maximized(window->xdg_toplevel); -+ xdg_toplevel_set_maximized(window->xdg_toplevel); - else if (action == NET_WM_STATE_REMOVE) -- zxdg_toplevel_v6_unset_maximized(window->xdg_toplevel); -+ xdg_toplevel_unset_maximized(window->xdg_toplevel); - } - } - } else if (event->type == ctx->atoms[ATOM_WM_CHANGE_STATE].value && - event->data.data32[0] == WM_STATE_ICONIC) { - struct sl_window* window = sl_lookup_window(ctx, event->window); - if (window && window->xdg_toplevel) { -- zxdg_toplevel_v6_set_minimized(window->xdg_toplevel); -+ xdg_toplevel_set_minimized(window->xdg_toplevel); - } - } - } -@@ -2164,7 +2165,7 @@ static void sl_handle_focus_in(struct sl_context* ctx, - // window was realized. - struct sl_window* parent = sl_lookup_window(ctx, window->transient_for); - if (parent && parent->xdg_toplevel && window->xdg_toplevel) -- zxdg_toplevel_v6_set_parent(window->xdg_toplevel, parent->xdg_toplevel); -+ xdg_toplevel_set_parent(window->xdg_toplevel, parent->xdg_toplevel); - } - } - -@@ -2381,9 +2382,9 @@ static void sl_handle_property_notify(struct sl_context* ctx, - return; - - if (window->name) { -- zxdg_toplevel_v6_set_title(window->xdg_toplevel, window->name); -+ xdg_toplevel_set_title(window->xdg_toplevel, window->name); - } else { -- zxdg_toplevel_v6_set_title(window->xdg_toplevel, ""); -+ xdg_toplevel_set_title(window->xdg_toplevel, ""); - } - } else if (event->atom == XCB_ATOM_WM_CLASS) { - struct sl_window* window = sl_lookup_window(ctx, event->window); -@@ -2435,19 +2436,19 @@ static void sl_handle_property_notify(struct sl_context* ctx, - return; - - if (window->size_flags & P_MIN_SIZE) { -- zxdg_toplevel_v6_set_min_size(window->xdg_toplevel, -+ xdg_toplevel_set_min_size(window->xdg_toplevel, - window->min_width / ctx->scale, - window->min_height / ctx->scale); - } else { -- zxdg_toplevel_v6_set_min_size(window->xdg_toplevel, 0, 0); -+ xdg_toplevel_set_min_size(window->xdg_toplevel, 0, 0); - } - - if (window->size_flags & P_MAX_SIZE) { -- zxdg_toplevel_v6_set_max_size(window->xdg_toplevel, -+ xdg_toplevel_set_max_size(window->xdg_toplevel, - window->max_width / ctx->scale, - window->max_height / ctx->scale); - } else { -- zxdg_toplevel_v6_set_max_size(window->xdg_toplevel, 0, 0); -+ xdg_toplevel_set_max_size(window->xdg_toplevel, 0, 0); - } - } else if (event->atom == XCB_ATOM_WM_HINTS) { - struct sl_window* window = sl_lookup_window(ctx, event->window); -@@ -3535,7 +3536,7 @@ int main(int argc, char** argv) { - .shm = NULL, - .shell = NULL, - .data_device_manager = NULL, -- .xdg_shell = NULL, -+ .xdg_wm_base = NULL, - .aura_shell = NULL, - .viewporter = NULL, - .linux_dmabuf = NULL, -diff --git a/vm_tools/sommelier/sommelier.h b/vm_tools/sommelier/sommelier.h -index b851b5c8d..7e6daf773 100644 ---- a/vm_tools/sommelier/sommelier.h -+++ b/vm_tools/sommelier/sommelier.h -@@ -31,7 +31,7 @@ struct sl_shell; - struct sl_data_device_manager; - struct sl_data_offer; - struct sl_data_source; --struct sl_xdg_shell; -+struct sl_xdg_wm_base; - struct sl_subcompositor; - struct sl_aura_shell; - struct sl_viewporter; -@@ -99,7 +99,7 @@ struct sl_context { - struct sl_shm* shm; - struct sl_shell* shell; - struct sl_data_device_manager* data_device_manager; -- struct sl_xdg_shell* xdg_shell; -+ struct sl_xdg_wm_base* xdg_wm_base; - struct sl_aura_shell* aura_shell; - struct sl_viewporter* viewporter; - struct sl_linux_dmabuf* linux_dmabuf; -@@ -373,11 +373,12 @@ struct sl_viewporter { - struct wp_viewporter* internal; - }; - --struct sl_xdg_shell { -+struct sl_xdg_wm_base { - struct sl_context* ctx; - uint32_t id; -+ uint32_t version; - struct sl_global* host_global; -- struct zxdg_shell_v6* internal; -+ struct xdg_wm_base* internal; - }; - - struct sl_aura_shell { -@@ -476,9 +477,9 @@ struct sl_window { - int max_height; - struct sl_config next_config; - struct sl_config pending_config; -- struct zxdg_surface_v6* xdg_surface; -- struct zxdg_toplevel_v6* xdg_toplevel; -- struct zxdg_popup_v6* xdg_popup; -+ struct xdg_surface* xdg_surface; -+ struct xdg_toplevel* xdg_toplevel; -+ struct xdg_popup* xdg_popup; - struct zaura_surface* aura_surface; - struct wl_list link; - }; -@@ -522,7 +523,7 @@ struct sl_global* sl_data_device_manager_global_create(struct sl_context* ctx); - - struct sl_global* sl_viewporter_global_create(struct sl_context* ctx); - --struct sl_global* sl_xdg_shell_global_create(struct sl_context* ctx); -+struct sl_global* sl_xdg_wm_base_global_create(struct sl_context* ctx); - - struct sl_global* sl_gtk_shell_global_create(struct sl_context* ctx); - --- -2.26.2 - diff --git a/pkgs/os-specific/linux/chromium-os/sommelier/0006-sommelier-make-building-demos-optional.patch b/pkgs/os-specific/linux/chromium-os/sommelier/0006-sommelier-make-building-demos-optional.patch deleted file mode 100644 index ecc876e4bfb..00000000000 --- a/pkgs/os-specific/linux/chromium-os/sommelier/0006-sommelier-make-building-demos-optional.patch +++ /dev/null @@ -1,100 +0,0 @@ -From 6a4ccbcded19df9ec42b865218ac744e6b35d505 Mon Sep 17 00:00:00 2001 -From: Alyssa Ross <hi@alyssa.is> -Date: Wed, 15 Jan 2020 21:36:43 +0000 -Subject: [PATCH 6/6] sommelier: make building demos optional -MIME-Version: 1.0 -Content-Type: text/plain; charset=UTF-8 -Content-Transfer-Encoding: 8bit - -pkg-config was checked at GN evaluation time for libbrillo and -libchrome, meaning that there was no way to build sommelier without -them, even though they were only required for the demos, not for -sommelier itself. - -Making the demo optional saves having to libbrillo and libchrome for -the common case of building just sommelier, which themselves have lots -of unusual dependencies. - -Thanks-to: Tomasz Śniatowski <tsniatowski@vewd.com> ---- - vm_tools/sommelier/BUILD.gn | 54 ++++++++++++++++++++++--------------- - 1 file changed, 32 insertions(+), 22 deletions(-) - -diff --git a/vm_tools/sommelier/BUILD.gn b/vm_tools/sommelier/BUILD.gn -index 4330560a1..cbb752745 100644 ---- a/vm_tools/sommelier/BUILD.gn -+++ b/vm_tools/sommelier/BUILD.gn -@@ -4,12 +4,20 @@ - - import("wayland_protocol.gni") - -+declare_args() { -+ use_demos = true -+} -+ - group("all") { - deps = [ - ":sommelier", -- ":wayland_demo", -- ":x11_demo", - ] -+ if (use_demos) { -+ deps += [ -+ ":wayland_demo", -+ ":x11_demo", -+ ] -+ } - } - - if (!defined(peer_cmd_prefix)) { -@@ -123,25 +131,27 @@ executable("sommelier") { - ] - } - --executable("wayland_demo") { -- pkg_deps = [ -- "libbrillo", -- "libchrome-${libbase_ver}", -- "wayland-client", -- ] -- libs = [ "wayland-client" ] -- sources = [ -- "demos/wayland_demo.cc", -- ] --} -+if (use_demos) { -+ executable("wayland_demo") { -+ pkg_deps = [ -+ "libbrillo", -+ "libchrome-${libbase_ver}", -+ "wayland-client", -+ ] -+ libs = [ "wayland-client" ] -+ sources = [ -+ "demos/wayland_demo.cc", -+ ] -+ } - --executable("x11_demo") { -- pkg_deps = [ -- "libbrillo", -- "libchrome-${libbase_ver}", -- ] -- libs = [ "X11" ] -- sources = [ -- "demos/x11_demo.cc", -- ] -+ executable("x11_demo") { -+ pkg_deps = [ -+ "libbrillo", -+ "libchrome-${libbase_ver}", -+ ] -+ libs = [ "X11" ] -+ sources = [ -+ "demos/x11_demo.cc", -+ ] -+ } - } --- -2.26.2 - diff --git a/pkgs/os-specific/linux/chromium-os/sommelier/default.nix b/pkgs/os-specific/linux/chromium-os/sommelier/default.nix index 9bf2777bfd7..68d23444f8d 100644 --- a/pkgs/os-specific/linux/chromium-os/sommelier/default.nix +++ b/pkgs/os-specific/linux/chromium-os/sommelier/default.nix @@ -8,8 +8,6 @@ common-mk { platform2Patches = [ ./0004-sommelier-don-t-leak-source-absolute-paths.patch - ./0005-sommelier-use-stable-xdg-shell-protocol.patch - ./0006-sommelier-make-building-demos-optional.patch ]; buildInputs = [ -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches 2021-04-02 9:04 ` [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches Jamie McClymont @ 2021-04-02 16:11 ` Alyssa Ross 2021-04-02 17:28 ` Alyssa Ross 0 siblings, 1 reply; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 16:11 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel [-- Attachment #1: Type: text/plain, Size: 2722 bytes --] Jamie McClymont <jamie@kwiius.com> writes: > The xdg-shell thing has been integrated upstream, and the demos seem to > no longer exist. > --- > ...melier-use-stable-xdg-shell-protocol.patch | 1748 ----------------- > ...mmelier-make-building-demos-optional.patch | 100 - > .../linux/chromium-os/sommelier/default.nix | 2 - > 3 files changed, 1850 deletions(-) > delete mode 100644 pkgs/os-specific/linux/chromium-os/sommelier/0005-sommelier-use-stable-xdg-shell-protocol.patch > delete mode 100644 pkgs/os-specific/linux/chromium-os/sommelier/0006-sommelier-make-building-demos-optional.patch This patch didn't apply for me. Looking at the message, it looks like unlike your other patches this has been encoded as base64. I wouldn't be surprised if this confuses things. Perhaps your mail provider re-encodes outgoing mail that isn't 7-bit. It also got held up for moderation by the mailing list because it was such a big message. For big deletions like this, you might want to consider using git-format-patch's --irreversible-delete option, that will omit the actual content being deleted from the patch. I think this might mean a little more work on my end when applying it (because the man page suggests I can't just feed it to git am), but that's fine by me if it'll mean messages don't get held up. Anyway, I just redid the patch by hand since it's such a simple change, and it looks like it does the job. If the demos are gone, I think we should remove this line too: gnArgs.use_demos = false; since we get a warning that it now has no effect: WARNING at the command-line "--args":1:400: Build argument has no effect. ar="ar" cc="cc" cxx="c++" libdir="/nix/store/gn09lnn0v3nssy1xw8m2r3vm2iyanmay-sommelier-89.13729.0.0-rc1" pkg_config="pkg-config" platform2_root="." platform_subdir="vm_tools/sommelier" use={amd64=true arm=false asan=false coverage=false cros_host=false crypto=false dbus=false device_mapper=false fuzzer=false mojo=false profiling=false tcmalloc=false test=false timers=false udev=false} use_demos=false ^---- The variable "use_demos" was set as a build argument but never appeared in a declare_args() block in any buildfile. To view all possible args, run "gn args --list <out_dir>" The build continued as if that argument was unspecified. LGTM other than that. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches 2021-04-02 16:11 ` Alyssa Ross @ 2021-04-02 17:28 ` Alyssa Ross 2021-04-02 17:18 ` Thomas Leonard 2021-04-02 21:00 ` [PATCH platform2] Revert "Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell"" Alyssa Ross 0 siblings, 2 replies; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 17:28 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel, Puck Meerburg, Thomas Leonard [-- Attachment #1: Type: text/plain, Size: 1521 bytes --] >> The xdg-shell thing has been integrated upstream, and the demos seem to >> no longer exist. Actually, is this true? Looking through the sommelier git log[1] I see 32050c0ea6c00c16999915856b40a6a6b8b41bb9: > Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell" > > This reverts commit be4e16feb380360cabbb5d6199a09592ecaf4a42. > > Reason for revert: Breaks the version of gtk3 shipped with stretch [1]: https://chromium.googlesource.com/chromiumos/platform2/+log/refs/heads/main/vm_tools/sommelier The relevant Chromium bugs[2][3] are: Issue 1022716: Sommelier does not support the stable xdg-shell Issue 1120277: GTK3 broken on stretch in M86 [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1022716 [3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1120277 It doesn't look like it's been reintroduced since, and there's no further activity on the bug, so I think current Sommelier doesn't support stable xdg-shell after all. From what I can tell, they backed out stable xdg-shell because their Debian version is too old to support it. So we probably still need this patch. It doesn't still apply cleanly, though. It would probably be better to just revert their revert than to keep carrying around Puck's version so that we're closer to upstream while still supporting stable xdg-shell. Also CCing Thomas, with whom I've previously talked about stable xdg-shell in Sommelier, in case he hasn't seen that it was reverted upstream. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches 2021-04-02 17:28 ` Alyssa Ross @ 2021-04-02 17:18 ` Thomas Leonard 2021-04-02 21:00 ` [PATCH platform2] Revert "Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell"" Alyssa Ross 1 sibling, 0 replies; 17+ messages in thread From: Thomas Leonard @ 2021-04-02 17:18 UTC (permalink / raw) To: Alyssa Ross; +Cc: Jamie McClymont, devel, Puck Meerburg On Fri, 2 Apr 2021 at 17:28, Alyssa Ross <hi@alyssa.is> wrote: > > >> The xdg-shell thing has been integrated upstream, and the demos seem to > >> no longer exist. > > Actually, is this true? Looking through the sommelier git log[1] I see > 32050c0ea6c00c16999915856b40a6a6b8b41bb9: > > > Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell" > > > > This reverts commit be4e16feb380360cabbb5d6199a09592ecaf4a42. > > > > Reason for revert: Breaks the version of gtk3 shipped with stretch > > [1]: https://chromium.googlesource.com/chromiumos/platform2/+log/refs/heads/main/vm_tools/sommelier > > The relevant Chromium bugs[2][3] are: > > Issue 1022716: Sommelier does not support the stable xdg-shell > Issue 1120277: GTK3 broken on stretch in M86 > > [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1022716 > [3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1120277 > > It doesn't look like it's been reintroduced since, and there's no > further activity on the bug, so I think current Sommelier doesn't > support stable xdg-shell after all. > > From what I can tell, they backed out stable xdg-shell because their > Debian version is too old to support it. So we probably still need this > patch. It doesn't still apply cleanly, though. It would probably be > better to just revert their revert than to keep carrying around Puck's > version so that we're closer to upstream while still supporting stable > xdg-shell. > > Also CCing Thomas, with whom I've previously talked about stable > xdg-shell in Sommelier, in case he hasn't seen that it was reverted > upstream. Yes, I initially reapplied the sommelier patch switching to the stable xdg-shell version (I had to update it slightly due to the C++ switch). But I've since replaced sommelier with https://github.com/talex5/wayland-virtwl-proxy/, which uses the stable xdg-shell version anyway. -- talex5 (GitHub/Twitter) http://roscidus.com/blog/ GPG: 5DD5 8D70 899C 454A 966D 6A51 7513 3C8F 94F6 E0CC ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH platform2] Revert "Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell"" 2021-04-02 17:28 ` Alyssa Ross 2021-04-02 17:18 ` Thomas Leonard @ 2021-04-02 21:00 ` Alyssa Ross 1 sibling, 0 replies; 17+ messages in thread From: Alyssa Ross @ 2021-04-02 21:00 UTC (permalink / raw) To: Jamie McClymont; +Cc: devel, Puck Meerburg This reverts commit 32050c0ea6c00c16999915856b40a6a6b8b41bb9. It's reverted upstream because Debian --- I propose replacing Puck's Sommelier patch with this (I haven't looked at how different it actually is -- I suppose probably not substantially). Reverting it was a bit of a pain because a bunch of static_casts and formatter comments have been added in the meantime, so I hope I resolved all the conflicts correctly. I've only tested that it compiles so far, because we haven't got crosvm building for Chromium OS 89 yet. vm_tools/sommelier/BUILD.gn | 2 +- vm_tools/sommelier/meson.build | 2 +- ...dg-shell-unstable-v6.xml => xdg-shell.xml} | 435 +++++++++++++----- vm_tools/sommelier/sommelier-xdg-shell.cc | 217 +++++---- vm_tools/sommelier/sommelier.cc | 210 +++++---- vm_tools/sommelier/sommelier.h | 8 +- 6 files changed, 535 insertions(+), 339 deletions(-) rename vm_tools/sommelier/protocol/{xdg-shell-unstable-v6.xml => xdg-shell.xml} (71%) diff --git a/vm_tools/sommelier/BUILD.gn b/vm_tools/sommelier/BUILD.gn index fe8481bee1..7fdebbb201 100644 --- a/vm_tools/sommelier/BUILD.gn +++ b/vm_tools/sommelier/BUILD.gn @@ -64,7 +64,7 @@ wayland_protocol_library("sommelier-protocol") { "protocol/relative-pointer-unstable-v1.xml", "protocol/text-input-unstable-v1.xml", "protocol/viewporter.xml", - "protocol/xdg-shell-unstable-v6.xml", + "protocol/xdg-shell.xml", ] } diff --git a/vm_tools/sommelier/meson.build b/vm_tools/sommelier/meson.build index cd33ec8fec..9eb8a2fb30 100644 --- a/vm_tools/sommelier/meson.build +++ b/vm_tools/sommelier/meson.build @@ -58,7 +58,7 @@ wl_protocols = [ 'protocol/relative-pointer-unstable-v1.xml', 'protocol/text-input-unstable-v1.xml', 'protocol/viewporter.xml', - 'protocol/xdg-shell-unstable-v6.xml', + 'protocol/xdg-shell.xml', ] wl_outs = [] diff --git a/vm_tools/sommelier/protocol/xdg-shell-unstable-v6.xml b/vm_tools/sommelier/protocol/xdg-shell.xml similarity index 71% rename from vm_tools/sommelier/protocol/xdg-shell-unstable-v6.xml rename to vm_tools/sommelier/protocol/xdg-shell.xml index 1c0f92452b..f7377a713c 100644 --- a/vm_tools/sommelier/protocol/xdg-shell-unstable-v6.xml +++ b/vm_tools/sommelier/protocol/xdg-shell.xml @@ -1,11 +1,13 @@ <?xml version="1.0" encoding="UTF-8"?> -<protocol name="xdg_shell_unstable_v6"> +<protocol name="xdg_shell"> <copyright> Copyright © 2008-2013 Kristian Høgsberg Copyright © 2013 Rafael Antognolli Copyright © 2013 Jasper St. Pierre Copyright © 2010-2013 Intel Corporation + Copyright © 2015-2017 Samsung Electronics Co., Ltd + Copyright © 2015-2017 Red Hat Inc. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), @@ -27,18 +29,19 @@ DEALINGS IN THE SOFTWARE. </copyright> - <interface name="zxdg_shell_v6" version="1"> + <interface name="xdg_wm_base" version="3"> <description summary="create desktop-style surfaces"> - xdg_shell allows clients to turn a wl_surface into a "real window" - which can be dragged, resized, stacked, and moved around by the - user. Everything about this interface is suited towards traditional - desktop environments. + The xdg_wm_base interface is exposed as a global object enabling clients + to turn their wl_surfaces into windows in a desktop environment. It + defines the basic functionality needed for clients and the compositor to + create windows that can be dragged, resized, maximized, etc, as well as + creating transient windows such as popup menus. </description> <enum name="error"> <entry name="role" value="0" summary="given wl_surface has another role"/> <entry name="defunct_surfaces" value="1" - summary="xdg_shell was destroyed before children"/> + summary="xdg_wm_base was destroyed before children"/> <entry name="not_the_topmost_popup" value="2" summary="the client tried to map or destroy a non-topmost popup"/> <entry name="invalid_popup_parent" value="3" @@ -50,11 +53,11 @@ </enum> <request name="destroy" type="destructor"> - <description summary="destroy xdg_shell"> - Destroy this xdg_shell object. + <description summary="destroy xdg_wm_base"> + Destroy this xdg_wm_base object. - Destroying a bound xdg_shell object while there are surfaces - still alive created by this xdg_shell object instance is illegal + Destroying a bound xdg_wm_base object while there are surfaces + still alive created by this xdg_wm_base object instance is illegal and will result in a protocol error. </description> </request> @@ -65,7 +68,7 @@ surfaces relative to some parent surface. See the interface description and xdg_surface.get_popup for details. </description> - <arg name="id" type="new_id" interface="zxdg_positioner_v6"/> + <arg name="id" type="new_id" interface="xdg_positioner"/> </request> <request name="get_xdg_surface"> @@ -82,14 +85,14 @@ See the documentation of xdg_surface for more details about what an xdg_surface is and how it is used. </description> - <arg name="id" type="new_id" interface="zxdg_surface_v6"/> + <arg name="id" type="new_id" interface="xdg_surface"/> <arg name="surface" type="object" interface="wl_surface"/> </request> <request name="pong"> <description summary="respond to a ping event"> A client must respond to a ping event with a pong request or - the client may be deemed unresponsive. See xdg_shell.ping. + the client may be deemed unresponsive. See xdg_wm_base.ping. </description> <arg name="serial" type="uint" summary="serial of the ping event"/> </request> @@ -98,7 +101,7 @@ <description summary="check if the client is alive"> The ping event asks the client if it's still alive. Pass the serial specified in the event back to the compositor by sending - a "pong" request back with the specified serial. See xdg_shell.ping. + a "pong" request back with the specified serial. See xdg_wm_base.pong. Compositors can use this to determine if the client is still alive. It's unspecified what will happen if the client doesn't @@ -106,13 +109,13 @@ try to respond in a reasonable amount of time. A compositor is free to ping in any way it wants, but a client must - always respond to any xdg_shell object it created. + always respond to any xdg_wm_base object it created. </description> <arg name="serial" type="uint" summary="pass this to the pong request"/> </event> </interface> - <interface name="zxdg_positioner_v6" version="1"> + <interface name="xdg_positioner" version="3"> <description summary="child surface positioner"> The xdg_positioner provides a collection of rules for the placement of a child surface relative to a parent surface. Rules can be defined to ensure @@ -162,13 +165,13 @@ Specify the anchor rectangle within the parent surface that the child surface will be placed relative to. The rectangle is relative to the window geometry as defined by xdg_surface.set_window_geometry of the - parent surface. The rectangle must be at least 1x1 large. + parent surface. When the xdg_positioner object is used to position a child surface, the anchor rectangle may not extend outside the window geometry of the positioned child's parent surface. - If a zero or negative size is set the invalid_input error is raised. + If a negative size is set the invalid_input error is raised. </description> <arg name="x" type="int" summary="x position of anchor rectangle"/> <arg name="y" type="int" summary="y position of anchor rectangle"/> @@ -176,63 +179,54 @@ <arg name="height" type="int" summary="height of anchor rectangle"/> </request> - <enum name="anchor" bitfield="true"> - <entry name="none" value="0" - summary="the center of the anchor rectangle"/> - <entry name="top" value="1" - summary="the top edge of the anchor rectangle"/> - <entry name="bottom" value="2" - summary="the bottom edge of the anchor rectangle"/> - <entry name="left" value="4" - summary="the left edge of the anchor rectangle"/> - <entry name="right" value="8" - summary="the right edge of the anchor rectangle"/> + <enum name="anchor"> + <entry name="none" value="0"/> + <entry name="top" value="1"/> + <entry name="bottom" value="2"/> + <entry name="left" value="3"/> + <entry name="right" value="4"/> + <entry name="top_left" value="5"/> + <entry name="bottom_left" value="6"/> + <entry name="top_right" value="7"/> + <entry name="bottom_right" value="8"/> </enum> <request name="set_anchor"> - <description summary="set anchor rectangle anchor edges"> - Defines a set of edges for the anchor rectangle. These are used to - derive an anchor point that the child surface will be positioned - relative to. If two orthogonal edges are specified (e.g. 'top' and - 'left'), then the anchor point will be the intersection of the edges - (e.g. the top left position of the rectangle); otherwise, the derived - anchor point will be centered on the specified edge, or in the center of - the anchor rectangle if no edge is specified. - - If two parallel anchor edges are specified (e.g. 'left' and 'right'), - the invalid_input error is raised. + <description summary="set anchor rectangle anchor"> + Defines the anchor point for the anchor rectangle. The specified anchor + is used derive an anchor point that the child surface will be + positioned relative to. If a corner anchor is set (e.g. 'top_left' or + 'bottom_right'), the anchor point will be at the specified corner; + otherwise, the derived anchor point will be centered on the specified + edge, or in the center of the anchor rectangle if no edge is specified. </description> <arg name="anchor" type="uint" enum="anchor" - summary="bit mask of anchor edges"/> + summary="anchor"/> </request> - <enum name="gravity" bitfield="true"> - <entry name="none" value="0" - summary="center over the anchor edge"/> - <entry name="top" value="1" - summary="position above the anchor edge"/> - <entry name="bottom" value="2" - summary="position below the anchor edge"/> - <entry name="left" value="4" - summary="position to the left of the anchor edge"/> - <entry name="right" value="8" - summary="position to the right of the anchor edge"/> + <enum name="gravity"> + <entry name="none" value="0"/> + <entry name="top" value="1"/> + <entry name="bottom" value="2"/> + <entry name="left" value="3"/> + <entry name="right" value="4"/> + <entry name="top_left" value="5"/> + <entry name="bottom_left" value="6"/> + <entry name="top_right" value="7"/> + <entry name="bottom_right" value="8"/> </enum> <request name="set_gravity"> <description summary="set child surface gravity"> Defines in what direction a surface should be positioned, relative to - the anchor point of the parent surface. If two orthogonal gravities are - specified (e.g. 'bottom' and 'right'), then the child surface will be - placed in the specified direction; otherwise, the child surface will be - centered over the anchor point on any axis that had no gravity - specified. - - If two parallel gravities are specified (e.g. 'left' and 'right'), the - invalid_input error is raised. + the anchor point of the parent surface. If a corner gravity is + specified (e.g. 'bottom_right' or 'top_left'), then the child surface + will be placed towards the specified gravity; otherwise, the child + surface will be centered over the anchor point on any axis that had no + gravity specified. </description> <arg name="gravity" type="uint" enum="gravity" - summary="bit mask of gravity directions"/> + summary="gravity direction"/> </request> <enum name="constraint_adjustment" bitfield="true"> @@ -252,7 +246,7 @@ <entry name="none" value="0"> <description summary="don't move the child surface when constrained"> Don't alter the surface position even if it is constrained on some - axis, for example partially outside the edge of a monitor. + axis, for example partially outside the edge of an output. </description> </entry> <entry name="slide_x" value="1"> @@ -304,6 +298,10 @@ surface is constrained, the gravity is 'bottom' and the anchor is 'bottom', change the gravity to 'top' and the anchor to 'top'. + The adjusted position is calculated given the original anchor + rectangle and offset, but with the new flipped anchor and gravity + values. + If the adjusted position also ends up being constrained, the resulting position of the flip_y adjustment will be the one before the adjustment. @@ -359,9 +357,49 @@ <arg name="x" type="int" summary="surface position x offset"/> <arg name="y" type="int" summary="surface position y offset"/> </request> + + <!-- Version 3 additions --> + + <request name="set_reactive" since="3"> + <description summary="continuously reconstrain the surface"> + When set reactive, the surface is reconstrained if the conditions used + for constraining changed, e.g. the parent window moved. + + If the conditions changed and the popup was reconstrained, an + xdg_popup.configure event is sent with updated geometry, followed by an + xdg_surface.configure event. + </description> + </request> + + <request name="set_parent_size" since="3"> + <description summary=""> + Set the parent window geometry the compositor should use when + positioning the popup. The compositor may use this information to + determine the future state the popup should be constrained using. If + this doesn't match the dimension of the parent the popup is eventually + positioned against, the behavior is undefined. + + The arguments are given in the surface-local coordinate space. + </description> + <arg name="parent_width" type="int" + summary="future window geometry width of parent"/> + <arg name="parent_height" type="int" + summary="future window geometry height of parent"/> + </request> + + <request name="set_parent_configure" since="3"> + <description summary="set parent configure this is a response to"> + Set the serial of a xdg_surface.configure event this positioner will be + used in response to. The compositor may use this information together + with set_parent_size to determine what future state the popup should be + constrained using. + </description> + <arg name="serial" type="uint" + summary="serial of parent configure event"/> + </request> </interface> - <interface name="zxdg_surface_v6" version="1"> + <interface name="xdg_surface" version="3"> <description summary="desktop user interface surface base interface"> An interface that may be implemented by a wl_surface, for implementations that provide a desktop-style user interface. @@ -388,11 +426,25 @@ manipulate a buffer prior to the first xdg_surface.configure call must also be treated as errors. - For a surface to be mapped by the compositor, the following conditions - must be met: (1) the client has assigned a xdg_surface based role to the - surface, (2) the client has set and committed the xdg_surface state and - the role dependent state to the surface and (3) the client has committed a - buffer to the surface. + After creating a role-specific object and setting it up, the client must + perform an initial commit without any buffer attached. The compositor + will reply with an xdg_surface.configure event. The client must + acknowledge it and is then allowed to attach a buffer to map the surface. + + Mapping an xdg_surface-based role surface is defined as making it + possible for the surface to be shown by the compositor. Note that + a mapped surface is not guaranteed to be visible once it is mapped. + + For an xdg_surface to be mapped by the compositor, the following + conditions must be met: + (1) the client has assigned an xdg_surface-based role to the surface + (2) the client has set and committed the xdg_surface state and the + role-dependent state to the surface + (3) the client has committed a buffer to the surface + + A newly-unmapped surface is considered to have met condition (1) out + of the 3 required conditions for mapping a surface if its role surface + has not been destroyed. </description> <enum name="error"> @@ -416,20 +468,23 @@ See the documentation of xdg_toplevel for more details about what an xdg_toplevel is and how it is used. </description> - <arg name="id" type="new_id" interface="zxdg_toplevel_v6"/> + <arg name="id" type="new_id" interface="xdg_toplevel"/> </request> <request name="get_popup"> <description summary="assign the xdg_popup surface role"> - This creates an xdg_popup object for the given xdg_surface and gives the - associated wl_surface the xdg_popup role. + This creates an xdg_popup object for the given xdg_surface and gives + the associated wl_surface the xdg_popup role. + + If null is passed as a parent, a parent surface must be specified using + some other protocol, before committing the initial state. See the documentation of xdg_popup for more details about what an xdg_popup is and how it is used. </description> - <arg name="id" type="new_id" interface="zxdg_popup_v6"/> - <arg name="parent" type="object" interface="zxdg_surface_v6"/> - <arg name="positioner" type="object" interface="zxdg_positioner_v6"/> + <arg name="id" type="new_id" interface="xdg_popup"/> + <arg name="parent" type="object" interface="xdg_surface" allow-null="true"/> + <arg name="positioner" type="object" interface="xdg_positioner"/> </request> <request name="set_window_geometry"> @@ -442,6 +497,11 @@ The window geometry is double buffered, and will be applied at the time wl_surface.commit of the corresponding wl_surface is called. + When maintaining a position, the compositor should treat the (x, y) + coordinate of the window geometry as the top left corner of the window. + A client changing the (x, y) window geometry coordinate should in + general not alter the position of the window. + Once the window geometry of the surface is set, it is not possible to unset it, and it will remain the same until set_window_geometry is called again, even if a new subsurface or buffer is attached. @@ -511,36 +571,57 @@ </description> <arg name="serial" type="uint" summary="serial of the configure event"/> </event> + </interface> - <interface name="zxdg_toplevel_v6" version="1"> + <interface name="xdg_toplevel" version="3"> <description summary="toplevel surface"> This interface defines an xdg_surface role which allows a surface to, among other things, set window-like properties such as maximize, fullscreen, and minimize, set application-specific metadata like title and id, and well as trigger user interactive operations such as interactive resize and move. + + Unmapping an xdg_toplevel means that the surface cannot be shown + by the compositor until it is explicitly mapped again. + All active operations (e.g., move, resize) are canceled and all + attributes (e.g. title, state, stacking, ...) are discarded for + an xdg_toplevel surface when it is unmapped. The xdg_toplevel returns to + the state it had right after xdg_surface.get_toplevel. The client + can re-map the toplevel by perfoming a commit without any buffer + attached, waiting for a configure event and handling it as usual (see + xdg_surface description). + + Attaching a null buffer to a toplevel unmaps the surface. </description> <request name="destroy" type="destructor"> <description summary="destroy the xdg_toplevel"> - Unmap and destroy the window. The window will be effectively - hidden from the user's point of view, and all state like - maximization, fullscreen, and so on, will be lost. + This request destroys the role surface and unmaps the surface; + see "Unmapping" behavior in interface section for details. </description> </request> <request name="set_parent"> <description summary="set the parent of this surface"> - Set the "parent" of this surface. This window should be stacked - above a parent. The parent surface must be mapped as long as this - surface is mapped. + Set the "parent" of this surface. This surface should be stacked + above the parent surface and all other ancestor surfaces. Parent windows should be set on dialogs, toolboxes, or other "auxiliary" surfaces, so that the parent is raised when the dialog is raised. + + Setting a null parent for a child window removes any parent-child + relationship for the child. Setting a null parent for a window which + currently has no parent is a no-op. + + If the parent is unmapped then its children are managed as + though the parent of the now-unmapped parent has become the + parent of this surface. If no parent exists for the now-unmapped + parent then the children are managed as though they have no + parent surface. </description> - <arg name="parent" type="object" interface="zxdg_toplevel_v6" allow-null="true"/> + <arg name="parent" type="object" interface="xdg_toplevel" allow-null="true"/> </request> <request name="set_title"> @@ -573,6 +654,9 @@ For example, "org.freedesktop.FooViewer" where the .desktop file is "org.freedesktop.FooViewer.desktop". + Like other properties, a set_app_id request can be sent after the + xdg_toplevel has been mapped to update the property. + See the desktop-entry specification [0] for more details on application identifiers and how they relate to well-known D-Bus names and .desktop files. @@ -676,7 +760,7 @@ </description> <arg name="seat" type="object" interface="wl_seat" summary="the wl_seat of the user event"/> <arg name="serial" type="uint" summary="the serial of the user event"/> - <arg name="edges" type="uint" summary="which edge or corner is being dragged"/> + <arg name="edges" type="uint" enum="resize_edge" summary="which edge or corner is being dragged"/> </request> <enum name="state"> @@ -693,12 +777,18 @@ <description summary="the surface is maximized"> The surface is maximized. The window geometry specified in the configure event must be obeyed by the client. + + The client should draw without shadow or other + decoration outside of the window geometry. </description> </entry> <entry name="fullscreen" value="2" summary="the surface is fullscreen"> <description summary="the surface is fullscreen"> - The surface is fullscreen. The window geometry specified in the configure - event must be obeyed by the client. + The surface is fullscreen. The window geometry specified in the + configure event is a maximum; the client cannot resize beyond it. For + a surface to cover the whole fullscreened area, the geometry + dimensions must be obeyed by the client. For more details, see + xdg_toplevel.set_fullscreen. </description> </entry> <entry name="resizing" value="3" summary="the surface is being resized"> @@ -716,6 +806,30 @@ keyboard or pointer focus. </description> </entry> + <entry name="tiled_left" value="5" since="2"> + <description summary="the surface is tiled"> + The window is currently in a tiled layout and the left edge is + considered to be adjacent to another part of the tiling grid. + </description> + </entry> + <entry name="tiled_right" value="6" since="2"> + <description summary="the surface is tiled"> + The window is currently in a tiled layout and the right edge is + considered to be adjacent to another part of the tiling grid. + </description> + </entry> + <entry name="tiled_top" value="7" since="2"> + <description summary="the surface is tiled"> + The window is currently in a tiled layout and the top edge is + considered to be adjacent to another part of the tiling grid. + </description> + </entry> + <entry name="tiled_bottom" value="8" since="2"> + <description summary="the surface is tiled"> + The window is currently in a tiled layout and the bottom edge is + considered to be adjacent to another part of the tiling grid. + </description> + </entry> </enum> <request name="set_max_size"> @@ -805,12 +919,11 @@ Maximize the surface. After requesting that the surface should be maximized, the compositor - will respond by emitting a configure event with the "maximized" state - and the required window geometry. The client should then update its - content, drawing it in a maximized state, i.e. without shadow or other - decoration outside of the window geometry. The client must also - acknowledge the configure when committing the new content (see - ack_configure). + will respond by emitting a configure event. Whether this configure + actually sets the window maximized is subject to compositor policies. + The client must then update its content, drawing in the configured + state. The client must also acknowledge the configure when committing + the new content (see ack_configure). It is up to the compositor to decide how and where to maximize the surface, for example which output and what region of the screen should @@ -818,6 +931,10 @@ If the surface was already maximized, the compositor will still emit a configure event with the "maximized" state. + + If the surface is in a fullscreen state, this request has no direct + effect. It may alter the state the surface is returned to when + unmaximized unless overridden by the compositor. </description> </request> @@ -826,13 +943,13 @@ Unmaximize the surface. After requesting that the surface should be unmaximized, the compositor - will respond by emitting a configure event without the "maximized" - state. If available, the compositor will include the window geometry - dimensions the window had prior to being maximized in the configure - request. The client must then update its content, drawing it in a - regular state, i.e. potentially with shadow, etc. The client must also - acknowledge the configure when committing the new content (see - ack_configure). + will respond by emitting a configure event. Whether this actually + un-maximizes the window is subject to compositor policies. + If available and applicable, the compositor will include the window + geometry dimensions the window had prior to being maximized in the + configure event. The client must then update its content, drawing it in + the configured state. The client must also acknowledge the configure + when committing the new content (see ack_configure). It is up to the compositor to position the surface after it was unmaximized; usually the position the surface had before maximizing, if @@ -840,24 +957,63 @@ If the surface was already not maximized, the compositor will still emit a configure event without the "maximized" state. + + If the surface is in a fullscreen state, this request has no direct + effect. It may alter the state the surface is returned to when + unmaximized unless overridden by the compositor. </description> </request> <request name="set_fullscreen"> - <description summary="set the window as fullscreen on a monitor"> + <description summary="set the window as fullscreen on an output"> Make the surface fullscreen. - You can specify an output that you would prefer to be fullscreen. - If this value is NULL, it's up to the compositor to choose which - display will be used to map this surface. + After requesting that the surface should be fullscreened, the + compositor will respond by emitting a configure event. Whether the + client is actually put into a fullscreen state is subject to compositor + policies. The client must also acknowledge the configure when + committing the new content (see ack_configure). + + The output passed by the request indicates the client's preference as + to which display it should be set fullscreen on. If this value is NULL, + it's up to the compositor to choose which display will be used to map + this surface. If the surface doesn't cover the whole output, the compositor will position the surface in the center of the output and compensate with - black borders filling the rest of the output. + with border fill covering the rest of the output. The content of the + border fill is undefined, but should be assumed to be in some way that + attempts to blend into the surrounding area (e.g. solid black). + + If the fullscreened surface is not opaque, the compositor must make + sure that other screen content not part of the same surface tree (made + up of subsurfaces, popups or similarly coupled surfaces) are not + visible below the fullscreened surface. </description> <arg name="output" type="object" interface="wl_output" allow-null="true"/> </request> - <request name="unset_fullscreen" /> + + <request name="unset_fullscreen"> + <description summary="unset the window as fullscreen"> + Make the surface no longer fullscreen. + + After requesting that the surface should be unfullscreened, the + compositor will respond by emitting a configure event. + Whether this actually removes the fullscreen state of the client is + subject to compositor policies. + + Making a surface unfullscreen sets states for the surface based on the following: + * the state(s) it may have had before becoming fullscreen + * any state(s) decided by the compositor + * any state(s) requested by the client while the surface was fullscreen + + The compositor may include the previous window geometry dimensions in + the configure event, if applicable. + + The client must also acknowledge the configure when committing the new + content (see ack_configure). + </description> + </request> <request name="set_minimized"> <description summary="set the window as minimized"> @@ -913,7 +1069,7 @@ </event> </interface> - <interface name="zxdg_popup_v6" version="1"> + <interface name="xdg_popup" version="3"> <description summary="short-lived, popup surfaces for menus"> A popup surface is a short-lived, temporary surface. It can be used to implement for example menus, popovers, tooltips and other similar user @@ -931,21 +1087,12 @@ surface of their own is clicked should dismiss the popup using the destroy request. - The parent surface must have either the xdg_toplevel or xdg_popup surface - role. - A newly created xdg_popup will be stacked on top of all previously created xdg_popup surfaces associated with the same xdg_toplevel. The parent of an xdg_popup must be mapped (see the xdg_surface description) before the xdg_popup itself. - The x and y arguments passed when creating the popup object specify - where the top left of the popup should be placed, relative to the - local surface coordinates of the parent surface. See - xdg_surface.get_popup. An xdg_popup must intersect with or be at least - partially adjacent to its parent surface. - The client must call wl_surface.commit on the corresponding wl_surface for the xdg_popup state to take effect. </description> @@ -1023,6 +1170,11 @@ The x and y arguments represent the position the popup was placed at given the xdg_positioner rule, relative to the upper left corner of the window geometry of the parent surface. + + For version 2 or older, the configure event for an xdg_popup is only + ever sent once for the initial configuration. Starting with version 3, + it may be sent again if the popup is setup with an xdg_positioner with + set_reactive requested, or in response to xdg_popup.reposition requests. </description> <arg name="x" type="int" summary="x position relative to parent surface window geometry"/> @@ -1040,5 +1192,58 @@ </description> </event> + <!-- Version 3 additions --> + + <request name="reposition" since="3"> + <description summary="recalculate the popup's location"> + Reposition an already-mapped popup. The popup will be placed given the + details in the passed xdg_positioner object, and a + xdg_popup.repositioned followed by xdg_popup.configure and + xdg_surface.configure will be emitted in response. Any parameters set + by the previous positioner will be discarded. + + The passed token will be sent in the corresponding + xdg_popup.repositioned event. The new popup position will not take + effect until the corresponding configure event is acknowledged by the + client. See xdg_popup.repositioned for details. The token itself is + opaque, and has no other special meaning. + + If multiple reposition requests are sent, the compositor may skip all + but the last one. + + If the popup is repositioned in response to a configure event for its + parent, the client should send an xdg_positioner.set_parent_configure + and possibly a xdg_positioner.set_parent_size request to allow the + compositor to properly constrain the popup. + + If the popup is repositioned together with a parent that is being + resized, but not in response to a configure event, the client should + send a xdg_positioner.set_parent_size request. + </description> + <arg name="positioner" type="object" interface="xdg_positioner"/> + <arg name="token" type="uint" summary="reposition request token"/> + </request> + + <event name="repositioned" since="3"> + <description summary="signal the completion of a repositioned request"> + The repositioned event is sent as part of a popup configuration + sequence, together with xdg_popup.configure and lastly + xdg_surface.configure to notify the completion of a reposition request. + + The repositioned event is to notify about the completion of a + xdg_popup.reposition request. The token argument is the token passed + in the xdg_popup.reposition request. + + Immediately after this event is emitted, xdg_popup.configure and + xdg_surface.configure will be sent with the updated size and position, + as well as a new configure serial. + + The client should optionally update the content of the popup, but must + acknowledge the new popup configuration for the new position to take + effect. See xdg_surface.ack_configure for details. + </description> + <arg name="token" type="uint" summary="reposition request token"/> + </event> + </interface> </protocol> diff --git a/vm_tools/sommelier/sommelier-xdg-shell.cc b/vm_tools/sommelier/sommelier-xdg-shell.cc index 91744a67e3..45b8eeb93e 100644 --- a/vm_tools/sommelier/sommelier-xdg-shell.cc +++ b/vm_tools/sommelier/sommelier-xdg-shell.cc @@ -7,37 +7,37 @@ #include <assert.h> #include <stdlib.h> -#include "xdg-shell-unstable-v6-client-protocol.h" // NOLINT(build/include_directory) -#include "xdg-shell-unstable-v6-server-protocol.h" // NOLINT(build/include_directory) +#include "xdg-shell-client-protocol.h" // NOLINT(build/include_directory) +#include "xdg-shell-server-protocol.h" // NOLINT(build/include_directory) struct sl_host_xdg_shell { struct sl_context* ctx; struct wl_resource* resource; - struct zxdg_shell_v6* proxy; + struct xdg_wm_base* proxy; }; struct sl_host_xdg_surface { struct sl_context* ctx; struct wl_resource* resource; - struct zxdg_surface_v6* proxy; + struct xdg_surface* proxy; }; struct sl_host_xdg_toplevel { struct sl_context* ctx; struct wl_resource* resource; - struct zxdg_toplevel_v6* proxy; + struct xdg_toplevel* proxy; }; struct sl_host_xdg_popup { struct sl_context* ctx; struct wl_resource* resource; - struct zxdg_popup_v6* proxy; + struct xdg_popup* proxy; }; struct sl_host_xdg_positioner { struct sl_context* ctx; struct wl_resource* resource; - struct zxdg_positioner_v6* proxy; + struct xdg_positioner* proxy; }; static void sl_xdg_positioner_destroy(struct wl_client* client, @@ -53,7 +53,7 @@ static void sl_xdg_positioner_set_size(struct wl_client* client, static_cast<sl_host_xdg_positioner*>(wl_resource_get_user_data(resource)); double scale = host->ctx->scale; - zxdg_positioner_v6_set_size(host->proxy, width / scale, height / scale); + xdg_positioner_set_size(host->proxy, width / scale, height / scale); } static void sl_xdg_positioner_set_anchor_rect(struct wl_client* client, @@ -72,7 +72,7 @@ static void sl_xdg_positioner_set_anchor_rect(struct wl_client* client, x2 = (x + width) / scale; y2 = (y + height) / scale; - zxdg_positioner_v6_set_anchor_rect(host->proxy, x1, y1, x2 - x1, y2 - y1); + xdg_positioner_set_anchor_rect(host->proxy, x1, y1, x2 - x1, y2 - y1); } static void sl_xdg_positioner_set_anchor(struct wl_client* client, @@ -81,7 +81,7 @@ static void sl_xdg_positioner_set_anchor(struct wl_client* client, struct sl_host_xdg_positioner* host = static_cast<sl_host_xdg_positioner*>(wl_resource_get_user_data(resource)); - zxdg_positioner_v6_set_anchor(host->proxy, anchor); + xdg_positioner_set_anchor(host->proxy, anchor); } static void sl_xdg_positioner_set_gravity(struct wl_client* client, @@ -90,7 +90,7 @@ static void sl_xdg_positioner_set_gravity(struct wl_client* client, struct sl_host_xdg_positioner* host = static_cast<sl_host_xdg_positioner*>(wl_resource_get_user_data(resource)); - zxdg_positioner_v6_set_gravity(host->proxy, gravity); + xdg_positioner_set_gravity(host->proxy, gravity); } static void sl_xdg_positioner_set_constraint_adjustment( @@ -100,8 +100,7 @@ static void sl_xdg_positioner_set_constraint_adjustment( struct sl_host_xdg_positioner* host = static_cast<sl_host_xdg_positioner*>(wl_resource_get_user_data(resource)); - zxdg_positioner_v6_set_constraint_adjustment(host->proxy, - constraint_adjustment); + xdg_positioner_set_constraint_adjustment(host->proxy, constraint_adjustment); } // NOLINT(whitespace/indent) static void sl_xdg_positioner_set_offset(struct wl_client* client, @@ -112,24 +111,23 @@ static void sl_xdg_positioner_set_offset(struct wl_client* client, static_cast<sl_host_xdg_positioner*>(wl_resource_get_user_data(resource)); double scale = host->ctx->scale; - zxdg_positioner_v6_set_offset(host->proxy, x / scale, y / scale); + xdg_positioner_set_offset(host->proxy, x / scale, y / scale); } -static const struct zxdg_positioner_v6_interface - sl_xdg_positioner_implementation = { - sl_xdg_positioner_destroy, - sl_xdg_positioner_set_size, - sl_xdg_positioner_set_anchor_rect, - sl_xdg_positioner_set_anchor, - sl_xdg_positioner_set_gravity, - sl_xdg_positioner_set_constraint_adjustment, - sl_xdg_positioner_set_offset}; +static const struct xdg_positioner_interface sl_xdg_positioner_implementation = + {sl_xdg_positioner_destroy, + sl_xdg_positioner_set_size, + sl_xdg_positioner_set_anchor_rect, + sl_xdg_positioner_set_anchor, + sl_xdg_positioner_set_gravity, + sl_xdg_positioner_set_constraint_adjustment, + sl_xdg_positioner_set_offset}; static void sl_destroy_host_xdg_positioner(struct wl_resource* resource) { struct sl_host_xdg_positioner* host = static_cast<sl_host_xdg_positioner*>(wl_resource_get_user_data(resource)); - zxdg_positioner_v6_destroy(host->proxy); + xdg_positioner_destroy(host->proxy); wl_resource_set_user_data(resource, NULL); free(host); } @@ -148,20 +146,20 @@ static void sl_xdg_popup_grab(struct wl_client* client, struct sl_host_seat* host_seat = static_cast<sl_host_seat*>(wl_resource_get_user_data(seat_resource)); - zxdg_popup_v6_grab(host->proxy, host_seat->proxy, serial); + xdg_popup_grab(host->proxy, host_seat->proxy, serial); } // NOLINT(whitespace/indent) -static const struct zxdg_popup_v6_interface sl_xdg_popup_implementation = { +static const struct xdg_popup_interface sl_xdg_popup_implementation = { sl_xdg_popup_destroy, sl_xdg_popup_grab}; static void sl_xdg_popup_configure(void* data, - struct zxdg_popup_v6* xdg_popup, + struct xdg_popup* xdg_popup, int32_t x, int32_t y, int32_t width, int32_t height) { struct sl_host_xdg_popup* host = - static_cast<sl_host_xdg_popup*>(zxdg_popup_v6_get_user_data(xdg_popup)); + static_cast<sl_host_xdg_popup*>(xdg_popup_get_user_data(xdg_popup)); double scale = host->ctx->scale; int32_t x1, y1, x2, y2; @@ -170,25 +168,24 @@ static void sl_xdg_popup_configure(void* data, x2 = (x + width) * scale; y2 = (y + height) * scale; - zxdg_popup_v6_send_configure(host->resource, x1, y1, x2 - x1, y2 - y1); + xdg_popup_send_configure(host->resource, x1, y1, x2 - x1, y2 - y1); } -static void sl_xdg_popup_popup_done(void* data, - struct zxdg_popup_v6* xdg_popup) { +static void sl_xdg_popup_popup_done(void* data, struct xdg_popup* xdg_popup) { struct sl_host_xdg_popup* host = - static_cast<sl_host_xdg_popup*>(zxdg_popup_v6_get_user_data(xdg_popup)); + static_cast<sl_host_xdg_popup*>(xdg_popup_get_user_data(xdg_popup)); - zxdg_popup_v6_send_popup_done(host->resource); + xdg_popup_send_popup_done(host->resource); } -static const struct zxdg_popup_v6_listener sl_xdg_popup_listener = { +static const struct xdg_popup_listener sl_xdg_popup_listener = { sl_xdg_popup_configure, sl_xdg_popup_popup_done}; static void sl_destroy_host_xdg_popup(struct wl_resource* resource) { struct sl_host_xdg_popup* host = static_cast<sl_host_xdg_popup*>(wl_resource_get_user_data(resource)); - zxdg_popup_v6_destroy(host->proxy); + xdg_popup_destroy(host->proxy); wl_resource_set_user_data(resource, NULL); free(host); } @@ -208,8 +205,7 @@ static void sl_xdg_toplevel_set_parent(struct wl_client* client, wl_resource_get_user_data(parent_resource)) : NULL; - zxdg_toplevel_v6_set_parent(host->proxy, - host_parent ? host_parent->proxy : NULL); + xdg_toplevel_set_parent(host->proxy, host_parent ? host_parent->proxy : NULL); } static void sl_xdg_toplevel_set_title(struct wl_client* client, @@ -218,7 +214,7 @@ static void sl_xdg_toplevel_set_title(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_set_title(host->proxy, title); + xdg_toplevel_set_title(host->proxy, title); } static void sl_xdg_toplevel_set_app_id(struct wl_client* client, @@ -227,7 +223,7 @@ static void sl_xdg_toplevel_set_app_id(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_set_app_id(host->proxy, app_id); + xdg_toplevel_set_app_id(host->proxy, app_id); } static void sl_xdg_toplevel_show_window_menu(struct wl_client* client, @@ -243,7 +239,7 @@ static void sl_xdg_toplevel_show_window_menu(struct wl_client* client, ? static_cast<sl_host_seat*>(wl_resource_get_user_data(seat_resource)) : NULL; - zxdg_toplevel_v6_show_window_menu( + xdg_toplevel_show_window_menu( host->proxy, host_seat ? host_seat->proxy : NULL, serial, x, y); } // NOLINT(whitespace/indent) @@ -258,8 +254,7 @@ static void sl_xdg_toplevel_move(struct wl_client* client, ? static_cast<sl_host_seat*>(wl_resource_get_user_data(seat_resource)) : NULL; - zxdg_toplevel_v6_move(host->proxy, host_seat ? host_seat->proxy : NULL, - serial); + xdg_toplevel_move(host->proxy, host_seat ? host_seat->proxy : NULL, serial); } // NOLINT(whitespace/indent) static void sl_xdg_toplevel_resize(struct wl_client* client, @@ -274,8 +269,8 @@ static void sl_xdg_toplevel_resize(struct wl_client* client, ? static_cast<sl_host_seat*>(wl_resource_get_user_data(seat_resource)) : NULL; - zxdg_toplevel_v6_resize(host->proxy, host_seat ? host_seat->proxy : NULL, - serial, edges); + xdg_toplevel_resize(host->proxy, host_seat ? host_seat->proxy : NULL, serial, + edges); } // NOLINT(whitespace/indent) static void sl_xdg_toplevel_set_max_size(struct wl_client* client, @@ -285,7 +280,7 @@ static void sl_xdg_toplevel_set_max_size(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_set_max_size(host->proxy, width, height); + xdg_toplevel_set_max_size(host->proxy, width, height); } static void sl_xdg_toplevel_set_min_size(struct wl_client* client, @@ -295,7 +290,7 @@ static void sl_xdg_toplevel_set_min_size(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_set_min_size(host->proxy, width, height); + xdg_toplevel_set_min_size(host->proxy, width, height); } static void sl_xdg_toplevel_set_maximized(struct wl_client* client, @@ -303,7 +298,7 @@ static void sl_xdg_toplevel_set_maximized(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_set_maximized(host->proxy); + xdg_toplevel_set_maximized(host->proxy); } static void sl_xdg_toplevel_unset_maximized(struct wl_client* client, @@ -311,7 +306,7 @@ static void sl_xdg_toplevel_unset_maximized(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_unset_maximized(host->proxy); + xdg_toplevel_unset_maximized(host->proxy); } static void sl_xdg_toplevel_set_fullscreen( @@ -325,8 +320,8 @@ static void sl_xdg_toplevel_set_fullscreen( wl_resource_get_user_data(output_resource)) : NULL; - zxdg_toplevel_v6_set_fullscreen(host->proxy, - host_output ? host_output->proxy : NULL); + xdg_toplevel_set_fullscreen(host->proxy, + host_output ? host_output->proxy : NULL); } // NOLINT(whitespace/indent) static void sl_xdg_toplevel_unset_fullscreen(struct wl_client* client, @@ -334,7 +329,7 @@ static void sl_xdg_toplevel_unset_fullscreen(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_unset_fullscreen(host->proxy); + xdg_toplevel_unset_fullscreen(host->proxy); } static void sl_xdg_toplevel_set_minimized(struct wl_client* client, @@ -342,47 +337,47 @@ static void sl_xdg_toplevel_set_minimized(struct wl_client* client, struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_set_minimized(host->proxy); + xdg_toplevel_set_minimized(host->proxy); } -static const struct zxdg_toplevel_v6_interface sl_xdg_toplevel_implementation = - {sl_xdg_toplevel_destroy, sl_xdg_toplevel_set_parent, - sl_xdg_toplevel_set_title, sl_xdg_toplevel_set_app_id, - sl_xdg_toplevel_show_window_menu, sl_xdg_toplevel_move, - sl_xdg_toplevel_resize, sl_xdg_toplevel_set_max_size, - sl_xdg_toplevel_set_min_size, sl_xdg_toplevel_set_maximized, - sl_xdg_toplevel_unset_maximized, sl_xdg_toplevel_set_fullscreen, - sl_xdg_toplevel_unset_fullscreen, sl_xdg_toplevel_set_minimized}; +static const struct xdg_toplevel_interface sl_xdg_toplevel_implementation = { + sl_xdg_toplevel_destroy, sl_xdg_toplevel_set_parent, + sl_xdg_toplevel_set_title, sl_xdg_toplevel_set_app_id, + sl_xdg_toplevel_show_window_menu, sl_xdg_toplevel_move, + sl_xdg_toplevel_resize, sl_xdg_toplevel_set_max_size, + sl_xdg_toplevel_set_min_size, sl_xdg_toplevel_set_maximized, + sl_xdg_toplevel_unset_maximized, sl_xdg_toplevel_set_fullscreen, + sl_xdg_toplevel_unset_fullscreen, sl_xdg_toplevel_set_minimized}; static void sl_xdg_toplevel_configure(void* data, - struct zxdg_toplevel_v6* xdg_toplevel, + struct xdg_toplevel* xdg_toplevel, int32_t width, int32_t height, struct wl_array* states) { struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>( - zxdg_toplevel_v6_get_user_data(xdg_toplevel)); + xdg_toplevel_get_user_data(xdg_toplevel)); double scale = host->ctx->scale; - zxdg_toplevel_v6_send_configure(host->resource, width * scale, height * scale, - states); + xdg_toplevel_send_configure(host->resource, width * scale, height * scale, + states); } static void sl_xdg_toplevel_close(void* data, - struct zxdg_toplevel_v6* xdg_toplevel) { + struct xdg_toplevel* xdg_toplevel) { struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>( - zxdg_toplevel_v6_get_user_data(xdg_toplevel)); + xdg_toplevel_get_user_data(xdg_toplevel)); - zxdg_toplevel_v6_send_close(host->resource); + xdg_toplevel_send_close(host->resource); } -static const struct zxdg_toplevel_v6_listener sl_xdg_toplevel_listener = { +static const struct xdg_toplevel_listener sl_xdg_toplevel_listener = { sl_xdg_toplevel_configure, sl_xdg_toplevel_close}; static void sl_destroy_host_xdg_toplevel(struct wl_resource* resource) { struct sl_host_xdg_toplevel* host = static_cast<sl_host_xdg_toplevel*>(wl_resource_get_user_data(resource)); - zxdg_toplevel_v6_destroy(host->proxy); + xdg_toplevel_destroy(host->proxy); wl_resource_set_user_data(resource, NULL); free(host); } @@ -403,14 +398,14 @@ static void sl_xdg_surface_get_toplevel(struct wl_client* client, host_xdg_toplevel->ctx = host->ctx; host_xdg_toplevel->resource = - wl_resource_create(client, &zxdg_toplevel_v6_interface, 1, id); + wl_resource_create(client, &xdg_toplevel_interface, 1, id); wl_resource_set_implementation( host_xdg_toplevel->resource, &sl_xdg_toplevel_implementation, host_xdg_toplevel, sl_destroy_host_xdg_toplevel); - host_xdg_toplevel->proxy = zxdg_surface_v6_get_toplevel(host->proxy); - zxdg_toplevel_v6_set_user_data(host_xdg_toplevel->proxy, host_xdg_toplevel); - zxdg_toplevel_v6_add_listener(host_xdg_toplevel->proxy, - &sl_xdg_toplevel_listener, host_xdg_toplevel); + host_xdg_toplevel->proxy = xdg_surface_get_toplevel(host->proxy); + xdg_toplevel_set_user_data(host_xdg_toplevel->proxy, host_xdg_toplevel); + xdg_toplevel_add_listener(host_xdg_toplevel->proxy, &sl_xdg_toplevel_listener, + host_xdg_toplevel); } static void sl_xdg_surface_get_popup(struct wl_client* client, @@ -421,7 +416,7 @@ static void sl_xdg_surface_get_popup(struct wl_client* client, struct sl_host_xdg_surface* host = static_cast<sl_host_xdg_surface*>(wl_resource_get_user_data(resource)); struct sl_host_xdg_surface* host_parent = static_cast<sl_host_xdg_surface*>( - wl_resource_get_user_data(parent_resource)); + parent_resource ? wl_resource_get_user_data(parent_resource) : NULL); struct sl_host_xdg_positioner* host_positioner = static_cast<sl_host_xdg_positioner*>( wl_resource_get_user_data(positioner_resource)); @@ -431,15 +426,16 @@ static void sl_xdg_surface_get_popup(struct wl_client* client, host_xdg_popup->ctx = host->ctx; host_xdg_popup->resource = - wl_resource_create(client, &zxdg_popup_v6_interface, 1, id); + wl_resource_create(client, &xdg_popup_interface, 1, id); wl_resource_set_implementation(host_xdg_popup->resource, &sl_xdg_popup_implementation, host_xdg_popup, sl_destroy_host_xdg_popup); - host_xdg_popup->proxy = zxdg_surface_v6_get_popup( - host->proxy, host_parent->proxy, host_positioner->proxy); - zxdg_popup_v6_set_user_data(host_xdg_popup->proxy, host_xdg_popup); - zxdg_popup_v6_add_listener(host_xdg_popup->proxy, &sl_xdg_popup_listener, - host_xdg_popup); + host_xdg_popup->proxy = xdg_surface_get_popup( + host->proxy, host_parent ? host_parent->proxy : NULL, + host_positioner->proxy); + xdg_popup_set_user_data(host_xdg_popup->proxy, host_xdg_popup); + xdg_popup_add_listener(host_xdg_popup->proxy, &sl_xdg_popup_listener, + host_xdg_popup); } // NOLINT(whitespace/indent) static void sl_xdg_surface_set_window_geometry(struct wl_client* client, @@ -458,7 +454,7 @@ static void sl_xdg_surface_set_window_geometry(struct wl_client* client, x2 = (x + width) / scale; y2 = (y + height) / scale; - zxdg_surface_v6_set_window_geometry(host->proxy, x1, y1, x2 - x1, y2 - y1); + xdg_surface_set_window_geometry(host->proxy, x1, y1, x2 - x1, y2 - y1); } static void sl_xdg_surface_ack_configure(struct wl_client* client, @@ -467,31 +463,31 @@ static void sl_xdg_surface_ack_configure(struct wl_client* client, struct sl_host_xdg_surface* host = static_cast<sl_host_xdg_surface*>(wl_resource_get_user_data(resource)); - zxdg_surface_v6_ack_configure(host->proxy, serial); + xdg_surface_ack_configure(host->proxy, serial); } -static const struct zxdg_surface_v6_interface sl_xdg_surface_implementation = { +static const struct xdg_surface_interface sl_xdg_surface_implementation = { sl_xdg_surface_destroy, sl_xdg_surface_get_toplevel, sl_xdg_surface_get_popup, sl_xdg_surface_set_window_geometry, sl_xdg_surface_ack_configure}; static void sl_xdg_surface_configure(void* data, - struct zxdg_surface_v6* xdg_surface, + struct xdg_surface* xdg_surface, uint32_t serial) { struct sl_host_xdg_surface* host = static_cast<sl_host_xdg_surface*>( - zxdg_surface_v6_get_user_data(xdg_surface)); + xdg_surface_get_user_data(xdg_surface)); - zxdg_surface_v6_send_configure(host->resource, serial); + xdg_surface_send_configure(host->resource, serial); } -static const struct zxdg_surface_v6_listener sl_xdg_surface_listener = { +static const struct xdg_surface_listener sl_xdg_surface_listener = { sl_xdg_surface_configure}; static void sl_destroy_host_xdg_surface(struct wl_resource* resource) { struct sl_host_xdg_surface* host = static_cast<sl_host_xdg_surface*>(wl_resource_get_user_data(resource)); - zxdg_surface_v6_destroy(host->proxy); + xdg_surface_destroy(host->proxy); wl_resource_set_user_data(resource, NULL); free(host); } @@ -513,13 +509,12 @@ static void sl_xdg_shell_create_positioner(struct wl_client* client, host_xdg_positioner->ctx = host->ctx; host_xdg_positioner->resource = - wl_resource_create(client, &zxdg_positioner_v6_interface, 1, id); + wl_resource_create(client, &xdg_positioner_interface, 1, id); wl_resource_set_implementation( host_xdg_positioner->resource, &sl_xdg_positioner_implementation, host_xdg_positioner, sl_destroy_host_xdg_positioner); - host_xdg_positioner->proxy = zxdg_shell_v6_create_positioner(host->proxy); - zxdg_positioner_v6_set_user_data(host_xdg_positioner->proxy, - host_xdg_positioner); + host_xdg_positioner->proxy = xdg_wm_base_create_positioner(host->proxy); + xdg_positioner_set_user_data(host_xdg_positioner->proxy, host_xdg_positioner); } static void sl_xdg_shell_get_xdg_surface(struct wl_client* client, @@ -536,15 +531,15 @@ static void sl_xdg_shell_get_xdg_surface(struct wl_client* client, host_xdg_surface->ctx = host->ctx; host_xdg_surface->resource = - wl_resource_create(client, &zxdg_surface_v6_interface, 1, id); + wl_resource_create(client, &xdg_surface_interface, 1, id); wl_resource_set_implementation(host_xdg_surface->resource, &sl_xdg_surface_implementation, host_xdg_surface, sl_destroy_host_xdg_surface); host_xdg_surface->proxy = - zxdg_shell_v6_get_xdg_surface(host->proxy, host_surface->proxy); - zxdg_surface_v6_set_user_data(host_xdg_surface->proxy, host_xdg_surface); - zxdg_surface_v6_add_listener(host_xdg_surface->proxy, - &sl_xdg_surface_listener, host_xdg_surface); + xdg_wm_base_get_xdg_surface(host->proxy, host_surface->proxy); + xdg_surface_set_user_data(host_xdg_surface->proxy, host_xdg_surface); + xdg_surface_add_listener(host_xdg_surface->proxy, &sl_xdg_surface_listener, + host_xdg_surface); host_surface->has_role = 1; } @@ -554,30 +549,30 @@ static void sl_xdg_shell_pong(struct wl_client* client, struct sl_host_xdg_shell* host = static_cast<sl_host_xdg_shell*>(wl_resource_get_user_data(resource)); - zxdg_shell_v6_pong(host->proxy, serial); + xdg_wm_base_pong(host->proxy, serial); } -static const struct zxdg_shell_v6_interface sl_xdg_shell_implementation = { +static const struct xdg_wm_base_interface sl_xdg_shell_implementation = { sl_xdg_shell_destroy, sl_xdg_shell_create_positioner, sl_xdg_shell_get_xdg_surface, sl_xdg_shell_pong}; static void sl_xdg_shell_ping(void* data, - struct zxdg_shell_v6* xdg_shell, + struct xdg_wm_base* xdg_shell, uint32_t serial) { struct sl_host_xdg_shell* host = - static_cast<sl_host_xdg_shell*>(zxdg_shell_v6_get_user_data(xdg_shell)); + static_cast<sl_host_xdg_shell*>(xdg_wm_base_get_user_data(xdg_shell)); - zxdg_shell_v6_send_ping(host->resource, serial); + xdg_wm_base_send_ping(host->resource, serial); } -static const struct zxdg_shell_v6_listener sl_xdg_shell_listener = { +static const struct xdg_wm_base_listener sl_xdg_shell_listener = { sl_xdg_shell_ping}; static void sl_destroy_host_xdg_shell(struct wl_resource* resource) { struct sl_host_xdg_shell* host = static_cast<sl_host_xdg_shell*>(wl_resource_get_user_data(resource)); - zxdg_shell_v6_destroy(host->proxy); + xdg_wm_base_destroy(host->proxy); wl_resource_set_user_data(resource, NULL); free(host); } @@ -591,17 +586,17 @@ static void sl_bind_host_xdg_shell(struct wl_client* client, static_cast<sl_host_xdg_shell*>(malloc(sizeof(*host))); assert(host); host->ctx = ctx; - host->resource = wl_resource_create(client, &zxdg_shell_v6_interface, 1, id); + host->resource = wl_resource_create(client, &xdg_wm_base_interface, 1, id); wl_resource_set_implementation(host->resource, &sl_xdg_shell_implementation, host, sl_destroy_host_xdg_shell); - host->proxy = static_cast<zxdg_shell_v6*>( + host->proxy = static_cast<xdg_wm_base*>( wl_registry_bind(wl_display_get_registry(ctx->display), - ctx->xdg_shell->id, &zxdg_shell_v6_interface, 1)); - zxdg_shell_v6_set_user_data(host->proxy, host); - zxdg_shell_v6_add_listener(host->proxy, &sl_xdg_shell_listener, host); + ctx->xdg_shell->id, &xdg_wm_base_interface, 1)); + xdg_wm_base_set_user_data(host->proxy, host); + xdg_wm_base_add_listener(host->proxy, &sl_xdg_shell_listener, host); } struct sl_global* sl_xdg_shell_global_create(struct sl_context* ctx) { - return sl_global_create(ctx, &zxdg_shell_v6_interface, 1, ctx, + return sl_global_create(ctx, &xdg_wm_base_interface, 1, ctx, sl_bind_host_xdg_shell); } diff --git a/vm_tools/sommelier/sommelier.cc b/vm_tools/sommelier/sommelier.cc index 0560672d46..8435dbe082 100644 --- a/vm_tools/sommelier/sommelier.cc +++ b/vm_tools/sommelier/sommelier.cc @@ -39,7 +39,7 @@ #include "relative-pointer-unstable-v1-client-protocol.h" // NOLINT(build/include_directory) #include "text-input-unstable-v1-client-protocol.h" // NOLINT(build/include_directory) #include "viewporter-client-protocol.h" // NOLINT(build/include_directory) -#include "xdg-shell-unstable-v6-client-protocol.h" // NOLINT(build/include_directory) +#include "xdg-shell-client-protocol.h" // NOLINT(build/include_directory) #define errno_assert(rv) \ { \ @@ -376,13 +376,13 @@ void sl_sync_point_destroy(struct sl_sync_point* sync_point) { } static void sl_internal_xdg_shell_ping(void* data, - struct zxdg_shell_v6* xdg_shell, + struct xdg_wm_base* xdg_shell, uint32_t serial) { TRACE_EVENT("shell", "sl_internal_xdg_shell_ping"); - zxdg_shell_v6_pong(xdg_shell, serial); + xdg_wm_base_pong(xdg_shell, serial); } -static const struct zxdg_shell_v6_listener sl_internal_xdg_shell_listener = { +static const struct xdg_wm_base_listener sl_internal_xdg_shell_listener = { sl_internal_xdg_shell_ping}; static void sl_send_configure_notify(struct sl_window* window) { @@ -549,8 +549,8 @@ int sl_process_pending_configure_acks(struct sl_window* window, } if (window->xdg_surface) { - zxdg_surface_v6_ack_configure(window->xdg_surface, - window->pending_config.serial); + xdg_surface_ack_configure(window->xdg_surface, + window->pending_config.serial); } window->pending_config.serial = 0; @@ -560,11 +560,12 @@ int sl_process_pending_configure_acks(struct sl_window* window, return 1; } -static void sl_internal_xdg_surface_configure( - void* data, struct zxdg_surface_v6* xdg_surface, uint32_t serial) { +static void sl_internal_xdg_surface_configure(void* data, + struct xdg_surface* xdg_surface, + uint32_t serial) { TRACE_EVENT("surface", "sl_internal_xdg_surface_configure"); struct sl_window* window = - static_cast<sl_window*>(zxdg_surface_v6_get_user_data(xdg_surface)); + static_cast<sl_window*>(xdg_surface_get_user_data(xdg_surface)); window->next_config.serial = serial; if (!window->pending_config.serial) { @@ -586,18 +587,18 @@ static void sl_internal_xdg_surface_configure( } } -static const struct zxdg_surface_v6_listener sl_internal_xdg_surface_listener = - {sl_internal_xdg_surface_configure}; +static const struct xdg_surface_listener sl_internal_xdg_surface_listener = { + sl_internal_xdg_surface_configure}; static void sl_internal_xdg_toplevel_configure( void* data, - struct zxdg_toplevel_v6* xdg_toplevel, + struct xdg_toplevel* xdg_toplevel, int32_t width, int32_t height, struct wl_array* states) { TRACE_EVENT("other", "sl_internal_xdg_toplevel_configure"); struct sl_window* window = - static_cast<sl_window*>(zxdg_toplevel_v6_get_user_data(xdg_toplevel)); + static_cast<sl_window*>(xdg_toplevel_get_user_data(xdg_toplevel)); int activated = 0; uint32_t* state; int i = 0; @@ -627,21 +628,21 @@ static void sl_internal_xdg_toplevel_configure( window->allow_resize = 1; sl_array_for_each(state, states) { - if (*state == ZXDG_TOPLEVEL_V6_STATE_FULLSCREEN) { + if (*state == XDG_TOPLEVEL_STATE_FULLSCREEN) { window->allow_resize = 0; window->next_config.states[i++] = window->ctx->atoms[ATOM_NET_WM_STATE_FULLSCREEN].value; } - if (*state == ZXDG_TOPLEVEL_V6_STATE_MAXIMIZED) { + if (*state == XDG_TOPLEVEL_STATE_MAXIMIZED) { window->allow_resize = 0; window->next_config.states[i++] = window->ctx->atoms[ATOM_NET_WM_STATE_MAXIMIZED_VERT].value; window->next_config.states[i++] = window->ctx->atoms[ATOM_NET_WM_STATE_MAXIMIZED_HORZ].value; } - if (*state == ZXDG_TOPLEVEL_V6_STATE_ACTIVATED) + if (*state == XDG_TOPLEVEL_STATE_ACTIVATED) activated = 1; - if (*state == ZXDG_TOPLEVEL_V6_STATE_RESIZING) + if (*state == XDG_TOPLEVEL_STATE_RESIZING) window->allow_resize = 0; } @@ -656,11 +657,11 @@ static void sl_internal_xdg_toplevel_configure( window->next_config.states_length = i; } -static void sl_internal_xdg_toplevel_close( - void* data, struct zxdg_toplevel_v6* xdg_toplevel) { +static void sl_internal_xdg_toplevel_close(void* data, + struct xdg_toplevel* xdg_toplevel) { TRACE_EVENT("other", "sl_internal_xdg_toplevel_close"); struct sl_window* window = - static_cast<sl_window*>(zxdg_toplevel_v6_get_user_data(xdg_toplevel)); + static_cast<sl_window*>(xdg_toplevel_get_user_data(xdg_toplevel)); xcb_client_message_event_t event = {}; event.response_type = XCB_CLIENT_MESSAGE; event.format = 32; @@ -673,21 +674,20 @@ static void sl_internal_xdg_toplevel_close( XCB_EVENT_MASK_NO_EVENT, (const char*)&event); } -static const struct zxdg_toplevel_v6_listener - sl_internal_xdg_toplevel_listener = {sl_internal_xdg_toplevel_configure, - sl_internal_xdg_toplevel_close}; +static const struct xdg_toplevel_listener sl_internal_xdg_toplevel_listener = { + sl_internal_xdg_toplevel_configure, sl_internal_xdg_toplevel_close}; static void sl_internal_xdg_popup_configure(void* data, - struct zxdg_popup_v6* xdg_popup, + struct xdg_popup* xdg_popup, int32_t x, int32_t y, int32_t width, int32_t height) {} static void sl_internal_xdg_popup_done(void* data, - struct zxdg_popup_v6* zxdg_popup_v6) {} + struct xdg_popup* xdg_popup) {} -static const struct zxdg_popup_v6_listener sl_internal_xdg_popup_listener = { +static const struct xdg_popup_listener sl_internal_xdg_popup_listener = { sl_internal_xdg_popup_configure, sl_internal_xdg_popup_done}; static void sl_window_set_wm_state(struct sl_window* window, int state) { @@ -759,15 +759,15 @@ void sl_window_update(struct sl_window* window) { window->aura_surface = NULL; } if (window->xdg_toplevel) { - zxdg_toplevel_v6_destroy(window->xdg_toplevel); + xdg_toplevel_destroy(window->xdg_toplevel); window->xdg_toplevel = NULL; } if (window->xdg_popup) { - zxdg_popup_v6_destroy(window->xdg_popup); + xdg_popup_destroy(window->xdg_popup); window->xdg_popup = NULL; } if (window->xdg_surface) { - zxdg_surface_v6_destroy(window->xdg_surface); + xdg_surface_destroy(window->xdg_surface); window->xdg_surface = NULL; } window->realized = 0; @@ -843,11 +843,11 @@ void sl_window_update(struct sl_window* window) { } if (!window->xdg_surface) { - window->xdg_surface = zxdg_shell_v6_get_xdg_surface( - ctx->xdg_shell->internal, host_surface->proxy); - zxdg_surface_v6_set_user_data(window->xdg_surface, window); - zxdg_surface_v6_add_listener(window->xdg_surface, - &sl_internal_xdg_surface_listener, window); + window->xdg_surface = xdg_wm_base_get_xdg_surface(ctx->xdg_shell->internal, + host_surface->proxy); + xdg_surface_set_user_data(window->xdg_surface, window); + xdg_surface_add_listener(window->xdg_surface, + &sl_internal_xdg_surface_listener, window); } if (ctx->aura_shell) { @@ -882,50 +882,46 @@ void sl_window_update(struct sl_window* window) { // window is closed. if (ctx->xwayland || !parent) { if (!window->xdg_toplevel) { - window->xdg_toplevel = zxdg_surface_v6_get_toplevel(window->xdg_surface); - zxdg_toplevel_v6_set_user_data(window->xdg_toplevel, window); - zxdg_toplevel_v6_add_listener(window->xdg_toplevel, - &sl_internal_xdg_toplevel_listener, window); + window->xdg_toplevel = xdg_surface_get_toplevel(window->xdg_surface); + xdg_toplevel_set_user_data(window->xdg_toplevel, window); + xdg_toplevel_add_listener(window->xdg_toplevel, + &sl_internal_xdg_toplevel_listener, window); } if (parent) - zxdg_toplevel_v6_set_parent(window->xdg_toplevel, parent->xdg_toplevel); + xdg_toplevel_set_parent(window->xdg_toplevel, parent->xdg_toplevel); if (window->name) - zxdg_toplevel_v6_set_title(window->xdg_toplevel, window->name); + xdg_toplevel_set_title(window->xdg_toplevel, window->name); if (window->size_flags & P_MIN_SIZE) { - zxdg_toplevel_v6_set_min_size(window->xdg_toplevel, - window->min_width / ctx->scale, - window->min_height / ctx->scale); + xdg_toplevel_set_min_size(window->xdg_toplevel, + window->min_width / ctx->scale, + window->min_height / ctx->scale); } if (window->size_flags & P_MAX_SIZE) { - zxdg_toplevel_v6_set_max_size(window->xdg_toplevel, - window->max_width / ctx->scale, - window->max_height / ctx->scale); + xdg_toplevel_set_max_size(window->xdg_toplevel, + window->max_width / ctx->scale, + window->max_height / ctx->scale); } if (window->maximized) { - zxdg_toplevel_v6_set_maximized(window->xdg_toplevel); + xdg_toplevel_set_maximized(window->xdg_toplevel); } } else if (!window->xdg_popup) { - struct zxdg_positioner_v6* positioner; + struct xdg_positioner* positioner; - positioner = zxdg_shell_v6_create_positioner(ctx->xdg_shell->internal); + positioner = xdg_wm_base_create_positioner(ctx->xdg_shell->internal); assert(positioner); - zxdg_positioner_v6_set_anchor( - positioner, - ZXDG_POSITIONER_V6_ANCHOR_TOP | ZXDG_POSITIONER_V6_ANCHOR_LEFT); - zxdg_positioner_v6_set_gravity( - positioner, - ZXDG_POSITIONER_V6_GRAVITY_BOTTOM | ZXDG_POSITIONER_V6_GRAVITY_RIGHT); - zxdg_positioner_v6_set_anchor_rect( - positioner, (window->x - parent->x) / ctx->scale, - (window->y - parent->y) / ctx->scale, 1, 1); + xdg_positioner_set_anchor(positioner, XDG_POSITIONER_ANCHOR_TOP_LEFT); + xdg_positioner_set_gravity(positioner, XDG_POSITIONER_GRAVITY_BOTTOM_RIGHT); + xdg_positioner_set_anchor_rect(positioner, + (window->x - parent->x) / ctx->scale, + (window->y - parent->y) / ctx->scale, 1, 1); - window->xdg_popup = zxdg_surface_v6_get_popup( - window->xdg_surface, parent->xdg_surface, positioner); - zxdg_popup_v6_set_user_data(window->xdg_popup, window); - zxdg_popup_v6_add_listener(window->xdg_popup, - &sl_internal_xdg_popup_listener, window); + window->xdg_popup = xdg_surface_get_popup(window->xdg_surface, + parent->xdg_surface, positioner); + xdg_popup_set_user_data(window->xdg_popup, window); + xdg_popup_add_listener(window->xdg_popup, &sl_internal_xdg_popup_listener, + window); - zxdg_positioner_v6_destroy(positioner); + xdg_positioner_destroy(positioner); } if ((window->size_flags & (US_POSITION | P_POSITION)) && parent && @@ -1326,7 +1322,7 @@ static void sl_registry_handler(void* data, data_device_manager->host_global = sl_data_device_manager_global_create(ctx); } - } else if (strcmp(interface, "zxdg_shell_v6") == 0) { + } else if (strcmp(interface, "xdg_wm_base") == 0) { struct sl_xdg_shell* xdg_shell = static_cast<sl_xdg_shell*>(malloc(sizeof(struct sl_xdg_shell))); assert(xdg_shell); @@ -1337,10 +1333,10 @@ static void sl_registry_handler(void* data, assert(!ctx->xdg_shell); ctx->xdg_shell = xdg_shell; if (ctx->xwayland) { - xdg_shell->internal = static_cast<zxdg_shell_v6*>( - wl_registry_bind(registry, id, &zxdg_shell_v6_interface, 1)); - zxdg_shell_v6_add_listener(xdg_shell->internal, - &sl_internal_xdg_shell_listener, NULL); + xdg_shell->internal = static_cast<xdg_wm_base*>( + wl_registry_bind(registry, id, &xdg_wm_base_interface, 1)); + xdg_wm_base_add_listener(xdg_shell->internal, + &sl_internal_xdg_shell_listener, NULL); } else { xdg_shell->host_global = sl_xdg_shell_global_create(ctx); } @@ -1473,7 +1469,7 @@ static void sl_registry_remover(void* data, if (ctx->xdg_shell->host_global) sl_global_destroy(ctx->xdg_shell->host_global); if (ctx->xdg_shell->internal) - zxdg_shell_v6_destroy(ctx->xdg_shell->internal); + xdg_wm_base_destroy(ctx->xdg_shell->internal); free(ctx->xdg_shell); ctx->xdg_shell = NULL; return; @@ -1650,11 +1646,11 @@ static void sl_destroy_window(struct sl_window* window) { } if (window->xdg_popup) - zxdg_popup_v6_destroy(window->xdg_popup); + xdg_popup_destroy(window->xdg_popup); if (window->xdg_toplevel) - zxdg_toplevel_v6_destroy(window->xdg_toplevel); + xdg_toplevel_destroy(window->xdg_toplevel); if (window->xdg_surface) - zxdg_surface_v6_destroy(window->xdg_surface); + xdg_surface_destroy(window->xdg_surface); if (window->aura_surface) zaura_surface_destroy(window->aura_surface); @@ -2118,15 +2114,15 @@ static void sl_handle_configure_request(struct sl_context* ctx, // that matching contents will arrive. if (window->xdg_toplevel) { if (window->pending_config.serial) { - zxdg_surface_v6_ack_configure(window->xdg_surface, - window->pending_config.serial); + xdg_surface_ack_configure(window->xdg_surface, + window->pending_config.serial); window->pending_config.serial = 0; window->pending_config.mask = 0; window->pending_config.states_length = 0; } if (window->next_config.serial) { - zxdg_surface_v6_ack_configure(window->xdg_surface, - window->next_config.serial); + xdg_surface_ack_configure(window->xdg_surface, + window->next_config.serial); window->next_config.serial = 0; window->next_config.mask = 0; window->next_config.states_length = 0; @@ -2247,23 +2243,23 @@ static void sl_handle_configure_notify(struct sl_context* ctx, static uint32_t sl_resize_edge(int net_wm_moveresize_size) { switch (net_wm_moveresize_size) { case NET_WM_MOVERESIZE_SIZE_TOPLEFT: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_TOP_LEFT; + return XDG_TOPLEVEL_RESIZE_EDGE_TOP_LEFT; case NET_WM_MOVERESIZE_SIZE_TOP: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_TOP; + return XDG_TOPLEVEL_RESIZE_EDGE_TOP; case NET_WM_MOVERESIZE_SIZE_TOPRIGHT: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_TOP_RIGHT; + return XDG_TOPLEVEL_RESIZE_EDGE_TOP_RIGHT; case NET_WM_MOVERESIZE_SIZE_RIGHT: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_RIGHT; + return XDG_TOPLEVEL_RESIZE_EDGE_RIGHT; case NET_WM_MOVERESIZE_SIZE_BOTTOMRIGHT: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_BOTTOM_RIGHT; + return XDG_TOPLEVEL_RESIZE_EDGE_BOTTOM_RIGHT; case NET_WM_MOVERESIZE_SIZE_BOTTOM: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_BOTTOM; + return XDG_TOPLEVEL_RESIZE_EDGE_BOTTOM; case NET_WM_MOVERESIZE_SIZE_BOTTOMLEFT: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_BOTTOM_LEFT; + return XDG_TOPLEVEL_RESIZE_EDGE_BOTTOM_LEFT; case NET_WM_MOVERESIZE_SIZE_LEFT: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_LEFT; + return XDG_TOPLEVEL_RESIZE_EDGE_LEFT; default: - return ZXDG_TOPLEVEL_V6_RESIZE_EDGE_NONE; + return XDG_TOPLEVEL_RESIZE_EDGE_NONE; } } @@ -2362,16 +2358,16 @@ static void sl_handle_client_message(struct sl_context* ctx, return; if (event->data.data32[2] == NET_WM_MOVERESIZE_MOVE) { - zxdg_toplevel_v6_move(window->xdg_toplevel, seat->proxy, - seat->seat->last_serial); + xdg_toplevel_move(window->xdg_toplevel, seat->proxy, + seat->seat->last_serial); } else { uint32_t edge = sl_resize_edge(event->data.data32[2]); - if (edge == ZXDG_TOPLEVEL_V6_RESIZE_EDGE_NONE) + if (edge == XDG_TOPLEVEL_RESIZE_EDGE_NONE) return; - zxdg_toplevel_v6_resize(window->xdg_toplevel, seat->proxy, - seat->seat->last_serial, edge); + xdg_toplevel_resize(window->xdg_toplevel, seat->proxy, + seat->seat->last_serial, edge); } } } else if (event->type == ctx->atoms[ATOM_NET_WM_STATE].value) { @@ -2392,9 +2388,9 @@ static void sl_handle_client_message(struct sl_context* ctx, "action", net_wm_state_to_string(action), "window->name", window->name); if (action == NET_WM_STATE_ADD) - zxdg_toplevel_v6_set_fullscreen(window->xdg_toplevel, NULL); + xdg_toplevel_set_fullscreen(window->xdg_toplevel, NULL); else if (action == NET_WM_STATE_REMOVE) - zxdg_toplevel_v6_unset_fullscreen(window->xdg_toplevel); + xdg_toplevel_unset_fullscreen(window->xdg_toplevel); } if (changed[ATOM_NET_WM_STATE_MAXIMIZED_VERT] && @@ -2405,9 +2401,9 @@ static void sl_handle_client_message(struct sl_context* ctx, "action", net_wm_state_to_string(action), "window->name", window->name); if (action == NET_WM_STATE_ADD) - zxdg_toplevel_v6_set_maximized(window->xdg_toplevel); + xdg_toplevel_set_maximized(window->xdg_toplevel); else if (action == NET_WM_STATE_REMOVE) - zxdg_toplevel_v6_unset_maximized(window->xdg_toplevel); + xdg_toplevel_unset_maximized(window->xdg_toplevel); } } } else if (event->type == ctx->atoms[ATOM_WM_CHANGE_STATE].value && @@ -2416,7 +2412,7 @@ static void sl_handle_client_message(struct sl_context* ctx, TRACE_EVENT("x11wm", "XCB_CLIENT_MESSAGE: WM_STATE_ICONIC (minimize)", "window->name", window ? window->name : "<unknown>"); if (window && window->xdg_toplevel) { - zxdg_toplevel_v6_set_minimized(window->xdg_toplevel); + xdg_toplevel_set_minimized(window->xdg_toplevel); } } } @@ -2429,7 +2425,7 @@ static void sl_handle_focus_in(struct sl_context* ctx, // window was realized. struct sl_window* parent = sl_lookup_window(ctx, window->transient_for); if (parent && parent->xdg_toplevel && window->xdg_toplevel) - zxdg_toplevel_v6_set_parent(window->xdg_toplevel, parent->xdg_toplevel); + xdg_toplevel_set_parent(window->xdg_toplevel, parent->xdg_toplevel); } } @@ -2738,9 +2734,9 @@ static void sl_handle_property_notify(struct sl_context* ctx, return; if (window->name) { - zxdg_toplevel_v6_set_title(window->xdg_toplevel, window->name); + xdg_toplevel_set_title(window->xdg_toplevel, window->name); } else { - zxdg_toplevel_v6_set_title(window->xdg_toplevel, ""); + xdg_toplevel_set_title(window->xdg_toplevel, ""); } } else if (event->atom == XCB_ATOM_WM_CLASS) { struct sl_window* window = sl_lookup_window(ctx, event->window); @@ -2796,19 +2792,19 @@ static void sl_handle_property_notify(struct sl_context* ctx, return; if (window->size_flags & P_MIN_SIZE) { - zxdg_toplevel_v6_set_min_size(window->xdg_toplevel, - window->min_width / ctx->scale, - window->min_height / ctx->scale); + xdg_toplevel_set_min_size(window->xdg_toplevel, + window->min_width / ctx->scale, + window->min_height / ctx->scale); } else { - zxdg_toplevel_v6_set_min_size(window->xdg_toplevel, 0, 0); + xdg_toplevel_set_min_size(window->xdg_toplevel, 0, 0); } if (window->size_flags & P_MAX_SIZE) { - zxdg_toplevel_v6_set_max_size(window->xdg_toplevel, - window->max_width / ctx->scale, - window->max_height / ctx->scale); + xdg_toplevel_set_max_size(window->xdg_toplevel, + window->max_width / ctx->scale, + window->max_height / ctx->scale); } else { - zxdg_toplevel_v6_set_max_size(window->xdg_toplevel, 0, 0); + xdg_toplevel_set_max_size(window->xdg_toplevel, 0, 0); } } else if (event->atom == XCB_ATOM_WM_HINTS) { struct sl_window* window = sl_lookup_window(ctx, event->window); diff --git a/vm_tools/sommelier/sommelier.h b/vm_tools/sommelier/sommelier.h index 1e00a0b981..f07a826c99 100644 --- a/vm_tools/sommelier/sommelier.h +++ b/vm_tools/sommelier/sommelier.h @@ -411,7 +411,7 @@ struct sl_xdg_shell { struct sl_context* ctx; uint32_t id; struct sl_global* host_global; - struct zxdg_shell_v6* internal; + struct xdg_wm_base* internal; }; struct sl_aura_shell { @@ -511,9 +511,9 @@ struct sl_window { int max_height; struct sl_config next_config; struct sl_config pending_config; - struct zxdg_surface_v6* xdg_surface; - struct zxdg_toplevel_v6* xdg_toplevel; - struct zxdg_popup_v6* xdg_popup; + struct xdg_surface* xdg_surface; + struct xdg_toplevel* xdg_toplevel; + struct xdg_popup* xdg_popup; struct zaura_surface* aura_surface; struct wl_list link; }; -- 2.30.0 ^ permalink raw reply [flat|nested] 17+ messages in thread
* [RFC PATCH 7/8] chromiumOSPackages.crosvm: add platform2 dep [not found] <20210402090042.2020627-1-jamie@kwiius.com> ` (6 preceding siblings ...) 2021-04-02 9:04 ` [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches Jamie McClymont @ 2021-04-02 9:04 ` Jamie McClymont 7 siblings, 0 replies; 17+ messages in thread From: Jamie McClymont @ 2021-04-02 9:04 UTC (permalink / raw) To: devel; +Cc: Jamie McClymont Several crates from under platfrom2 are now used. --- pkgs/os-specific/linux/chromium-os/crosvm/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/os-specific/linux/chromium-os/crosvm/default.nix b/pkgs/os-specific/linux/chromium-os/crosvm/default.nix index d64dc316772..ab5ac518ef7 100644 --- a/pkgs/os-specific/linux/chromium-os/crosvm/default.nix +++ b/pkgs/os-specific/linux/chromium-os/crosvm/default.nix @@ -13,6 +13,7 @@ let "src/platform/crosvm" "src/third_party/adhd" "src/aosp/external/minijail" + "src/platform2" ] getSrc; in -- 2.31.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-04-02 21:03 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210402090042.2020627-1-jamie@kwiius.com>
2021-04-02 9:04 ` [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config Jamie McClymont
2021-04-02 15:35 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 1/8] chromiumOSPackages: update 83->89 Jamie McClymont
2021-04-02 14:58 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches Jamie McClymont
2021-04-02 15:47 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch Jamie McClymont
2021-04-02 15:53 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings Jamie McClymont
2021-04-02 15:54 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 8/8] chromiumOSPackages.crosvm: bump cargoSha256 Jamie McClymont
2021-04-02 9:04 ` [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches Jamie McClymont
2021-04-02 16:11 ` Alyssa Ross
2021-04-02 17:28 ` Alyssa Ross
2021-04-02 17:18 ` Thomas Leonard
2021-04-02 21:00 ` [PATCH platform2] Revert "Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell"" Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 7/8] chromiumOSPackages.crosvm: add platform2 dep Jamie McClymont
Code repositories for project(s) associated with this public inbox https://spectrum-os.org/git/crosvm https://spectrum-os.org/git/doc https://spectrum-os.org/git/mktuntap https://spectrum-os.org/git/nixpkgs https://spectrum-os.org/git/spectrum https://spectrum-os.org/git/ucspi-vsock https://spectrum-os.org/git/www This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).