From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 12C081BD8E; Fri, 2 Apr 2021 16:12:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id EC4911BCF6; Fri, 2 Apr 2021 16:11:47 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id B4F741BCE2; Fri, 2 Apr 2021 16:11:45 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by atuin.qyliss.net (Postfix) with ESMTPS id 7E7861BCE0 for ; Fri, 2 Apr 2021 16:11:42 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AE2285C00AD; Fri, 2 Apr 2021 12:11:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 02 Apr 2021 12:11:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=dinB84k+R7K4jiQPmmw56rSQEE gC5ENG2WKmWk540j4=; b=LiyNKgdCl9guL1lQ0RN+NLoKjTWBTqjTEV60ohehpn SUnXf5bUx8mZOmX+4+2jw4woSMrTnT5YXGJF0IjLrv0BSCa2eqtcWFKMdgwR1tTa WCb8iLCaP2SE3aKtWK+kmC131DZ4L3HsnYkZnQpG/xgWBQdQ3pTd/cLlOMcGPKJE 6BcjFNYG8tqAxQvhTFjFG/wxkGvvtnWrjXzsG0Zxd4Dkd6kBS4gy6WXM+NESKYaH m/T01yBVyP98KiiI5BsbCB7eo9zXEsQSWfenh3DerLpYUUToTD69IrD78bG4DowB gaHj2utooUURuoYpRdXuZiC/iEEUUKNOaniU8x2PXmhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=dinB84 k+R7K4jiQPmmw56rSQEEgC5ENG2WKmWk540j4=; b=DRhOjJTSy7DLx4Dv5Kdk+l IPT51Jqxv2O+pOAWeAEiZOloyDVoR8jNvImxhgCH1M18AR6ASkpp0JAUEUroLfwc OvjLVVWrZXkgiBcV+qA/+VCFLextejkAWOiSTzdCqhGq6C7KCwaqknHRVQ5w53+3 x7Z/FRMdFjjVKT+sK0x26CgNjqarpACI5KNOEBkqPxwcnAZhoWgjlRxGfPydeYiC rI6FyIy3NbgG97BUynZFPARVcmv5fVOSw9CUVWmpMChDK1JTvKw+l7vCPTBh78UH 6LlUswgT5+o5YWFQLdDvvVXsUmVcX7cPdJmooA+IMrWjohF1/wj0S3dMn3EVn2fw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeiiedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepvdeuvd eivdehhfeikedtvddvhefgheffleevueeigffgtdffffeujedujeejkeejnecukfhppeej ledrvdefuddrvdegfedrvddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhish X-ME-Proxy: Received: from x220.qyliss.net (p4fe7f3c9.dip0.t-ipconnect.de [79.231.243.201]) by mail.messagingengine.com (Postfix) with ESMTPA id 408CF240054; Fri, 2 Apr 2021 12:11:40 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 2D47C584; Fri, 2 Apr 2021 16:11:39 +0000 (UTC) From: Alyssa Ross To: Jamie McClymont Subject: Re: [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches In-Reply-To: <0100017891d37f9f-9a88c2a4-d5a3-4f89-94f1-f86a9a8c383f-000000@email.amazonses.com> References: <20210402090042.2020627-1-jamie@kwiius.com> <0100017891d37f9f-9a88c2a4-d5a3-4f89-94f1-f86a9a8c383f-000000@email.amazonses.com> Date: Fri, 02 Apr 2021 16:11:37 +0000 Message-ID: <87im548y4m.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: TXQA2CHWE57HFNA4B3IDT74JC65WMWUX X-Message-ID-Hash: TXQA2CHWE57HFNA4B3IDT74JC65WMWUX X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Jamie McClymont writes: > The xdg-shell thing has been integrated upstream, and the demos seem to > no longer exist. > --- > ...melier-use-stable-xdg-shell-protocol.patch | 1748 ----------------- > ...mmelier-make-building-demos-optional.patch | 100 - > .../linux/chromium-os/sommelier/default.nix | 2 - > 3 files changed, 1850 deletions(-) > delete mode 100644 pkgs/os-specific/linux/chromium-os/sommelier/0005-sommelier-use-stable-xdg-shell-protocol.patch > delete mode 100644 pkgs/os-specific/linux/chromium-os/sommelier/0006-sommelier-make-building-demos-optional.patch This patch didn't apply for me. Looking at the message, it looks like unlike your other patches this has been encoded as base64. I wouldn't be surprised if this confuses things. Perhaps your mail provider re-encodes outgoing mail that isn't 7-bit. It also got held up for moderation by the mailing list because it was such a big message. For big deletions like this, you might want to consider using git-format-patch's --irreversible-delete option, that will omit the actual content being deleted from the patch. I think this might mean a little more work on my end when applying it (because the man page suggests I can't just feed it to git am), but that's fine by me if it'll mean messages don't get held up. Anyway, I just redid the patch by hand since it's such a simple change, and it looks like it does the job. If the demos are gone, I think we should remove this line too: gnArgs.use_demos = false; since we get a warning that it now has no effect: WARNING at the command-line "--args":1:400: Build argument has no effect. ar="ar" cc="cc" cxx="c++" libdir="/nix/store/gn09lnn0v3nssy1xw8m2r3vm2iyanmay-sommelier-89.13729.0.0-rc1" pkg_config="pkg-config" platform2_root="." platform_subdir="vm_tools/sommelier" use={amd64=true arm=false asan=false coverage=false cros_host=false crypto=false dbus=false device_mapper=false fuzzer=false mojo=false profiling=false tcmalloc=false test=false timers=false udev=false} use_demos=false ^---- The variable "use_demos" was set as a build argument but never appeared in a declare_args() block in any buildfile. To view all possible args, run "gn args --list " The build continued as if that argument was unspecified. LGTM other than that. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBnQjoACgkQ+dvtSFmy ccCdVBAAnyae8q/4QtQXiTFMfiWcdsWi/s7m43BhTwoG1Yn3ut9bJuEli7Z0h0St pPTIWrsCBOkVENwfbdbrd1W53kR794pWQatEz6IR4UYbPKtSdPLCk2i4jaeRJfnX gt+JvlgfzIFskrTfsaYFvfruxGtKbcnh2mgla1P01jbtAby3JDwo6geAEGi5k6PF G2lHHrAAzNEk42RVUQ3upTtb7a97D9QDEVPmqxvWJBPi3e1OPZuwWmhdEQ0M5bQ4 +ZWwhsVgHZ/aT1KRxxBAhiwVAMpHNCuUo3jvNsof3Rg42Y+3LKcmApKXcIvqTb8a KDtfiIZzuvOxbROj1WNrL3QUCA9V2ieQ3+YjbeFHFcg857uyb5vMLz8pB2q4UfKm mbwRScSwsMJNrQIcaAv3tauqhsA05TY+Y17VBubL8dgge0Pnlje801lyeqjFWANI F2wKhzZuuPIbwUvlxxnpv6CvbbmKrmVyYHGTw5Lqxw7bXZ+UGP9K5awkoDBFGuIf uyjFPpC5cQM174nYNhBx3QE8e4LHYBaXooHbOj8QWk86RUlyNTlCcu3VovsophPn ggdc6RxSgimWDMxEXZY6Gr07SxQCdvC8eZ9G2psnNRdqnX5huAGNUd2rOw/EXHhQ lDX4pjILlxLFOlkBb+i1FD0ue/aAKE5rF4oHDCBLLSKLoTbgSn8= =NTsV -----END PGP SIGNATURE----- --=-=-=--