From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id EEEA71BF78; Fri, 2 Apr 2021 17:28:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id C6A5B1BF61; Fri, 2 Apr 2021 17:28:44 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id C19D11BF4C; Fri, 2 Apr 2021 17:28:42 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by atuin.qyliss.net (Postfix) with ESMTPS id 08B5A1BF4A for ; Fri, 2 Apr 2021 17:28:38 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 499505C0085; Fri, 2 Apr 2021 13:28:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 02 Apr 2021 13:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=6YwNZHWgDMUloZSlZzg2wGT2hY H9XkK2358NcpW/1v0=; b=otOEUvF3Na7gSHXK01BpgZW3GyZHq87lpspkXooixo 4dR3BNb4LUY1GbDpms+c/QdTsPgiGMLdi/pqiw70oyOw2BpBkOYjJyen4TAzrVsg gvJNyoCmr+i9JEQaJQRrzgbgr+skYRF7F6BOf4ctmagecPkmxKnQ35r3pRQ0V8X1 CaNkYOhR6IUgC0Y9A12PSQB+0VJ5leRFB9kkm6Z8+v+Ni5zj+8Vx9EwJrO6usHbB brQIIYTheG0KOY60CCTW6PMUpGoZcwzjo5+9ndaOg+JlJ9WhIbJxQGDxQN+0iZP6 0Yyx0O9Z4O9T3V0QF70RpSry2Vz1BlOCC2gUHtWM04wA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=6YwNZH WgDMUloZSlZzg2wGT2hYH9XkK2358NcpW/1v0=; b=BfZyQI1n4P+N6yQbQqOZO0 tLzb8MYMy6uyIiJidDCBuoAJsAUqN+7jPaUWKlQH7hTlF2C5Ky2mGUnbrn18nUKM W2hKQzdm6m0w4IH+GFG/B3sbwyMcjtl97t1RNMEVYBI/0IUiE4V5XKiHkiWCYhh2 Pv9pxktU2VAoIARrhkWXjckxivhgHhxANahcr7+mclrUTDgrV3jczIWt3/ppMMnB Afr7lLJ2ZdEThU6PBE0QNnj8OqIFqF67ibkHvm4NMo9pX4AOUFMFeHtO2iZYECs6 Uet1tPe/HNW2iOos6HwV/RZgXYqOS4zRz8XNTwQjlI2yWFEaTV8OrN+o3dYhJ3ZA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeiiedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpefhtd egtdetjeeuhfehjeeghfetgeelkeetvdfhheeuveefhfefgedtvdeljeffudenucffohhm rghinhepghhoohhglhgvshhouhhrtggvrdgtohhmpdgthhhrohhmihhumhdrohhrghenuc fkphepjeelrddvfedurddvgeefrddvtddunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhs X-ME-Proxy: Received: from x220.qyliss.net (p4fe7f3c9.dip0.t-ipconnect.de [79.231.243.201]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E0B924005B; Fri, 2 Apr 2021 13:28:37 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id E8604523; Fri, 2 Apr 2021 17:28:35 +0000 (UTC) From: Alyssa Ross To: Jamie McClymont Subject: Re: [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches In-Reply-To: <87im548y4m.fsf@alyssa.is> References: <20210402090042.2020627-1-jamie@kwiius.com> <0100017891d37f9f-9a88c2a4-d5a3-4f89-94f1-f86a9a8c383f-000000@email.amazonses.com> <87im548y4m.fsf@alyssa.is> Date: Fri, 02 Apr 2021 17:28:32 +0000 Message-ID: <87wntkwq7z.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: CDRVOVV6UEAVOVTEBFVQBJUKPROALW3E X-Message-ID-Hash: CDRVOVV6UEAVOVTEBFVQBJUKPROALW3E X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org, Puck Meerburg , Thomas Leonard X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >> The xdg-shell thing has been integrated upstream, and the demos seem to >> no longer exist. Actually, is this true? Looking through the sommelier git log[1] I see 32050c0ea6c00c16999915856b40a6a6b8b41bb9: > Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell" > > This reverts commit be4e16feb380360cabbb5d6199a09592ecaf4a42. > > Reason for revert: Breaks the version of gtk3 shipped with stretch [1]: https://chromium.googlesource.com/chromiumos/platform2/+log/refs/heads= /main/vm_tools/sommelier The relevant Chromium bugs[2][3] are: Issue 1022716: Sommelier does not support the stable xdg-shell Issue 1120277: GTK3 broken on stretch in M86 [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=3D1022716 [3]: https://bugs.chromium.org/p/chromium/issues/detail?id=3D1120277 It doesn't look like it's been reintroduced since, and there's no further activity on the bug, so I think current Sommelier doesn't support stable xdg-shell after all. From=20what I can tell, they backed out stable xdg-shell because their Debian version is too old to support it. So we probably still need this patch. It doesn't still apply cleanly, though. It would probably be better to just revert their revert than to keep carrying around Puck's version so that we're closer to upstream while still supporting stable xdg-shell. Also CCing Thomas, with whom I've previously talked about stable xdg-shell in Sommelier, in case he hasn't seen that it was reverted upstream. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBnVEEACgkQ+dvtSFmy ccBJMw//RGWQD8EiAce0jmBNeAXQ8Z6cUS4M0/6ZUqhY0r1lc4EaBRYx//TnudZ4 e6g5iqhb0mTEvR40PNK3jb9xs2Ax5gW0O+wO49Z3uAGIJRrS0IB3snT8Co6sJt+z EgEYNMd5TsEOmo3KBo35J0ACT59E1IA51xORrXH1nukrpwEf4hWXwmxAjyTV7TDR BsaB1il8XLIClc3ebiztZV1WENf2izc9rQUvgIy4uDNYdworEe8KoDZeUb0urXxL yjl+W/e6xG4NTq4PFwi9hdoEJMe8d6G/2ClK6k+VSVupTuhQ1X4RAhsY9ofemztG ptOOHDZCFNNSb/G2G8ZJxbPt9MyRbqVmcS2tKW2mjZH7Y/bgse78Ws8866dRQLvG 2vSs8TbtQVrlG01w7YmLkhm0Ri3dfy6oygsqJlM4DufEoCp7FHdZHZnVQYEEp5K4 EbaAnzD5gsH6kDfdG4EbBSw9x3IbLNHtWfxDnE7moZhjOsJDMNHYJvcWLuthbx2R Hvlk3DAKmLS9gmwNWw4Tif4jo9PR4+1NwCYQGOSnFxNMaJpvoUaEToOPGw7RnAlX if0VyiWtKZ/XEH+2uZi1Dm1mRQJD5irKlu/g9GN9Yv0bN11ChAeoVBuGpLmqPm7Q Z7upOmRjQhxyUxELRN9goBVgRTnX0lgS5LXdn4bmE7rvGQoVDGw= =fw6B -----END PGP SIGNATURE----- --=-=-=--