From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 767011ABF1; Fri, 2 Apr 2021 09:04:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 878C51A9F0; Fri, 2 Apr 2021 09:04:26 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 2D56E1A9CA; Fri, 2 Apr 2021 09:04:24 +0000 (UTC) Received: from a8-86.smtp-out.amazonses.com (a8-86.smtp-out.amazonses.com [54.240.8.86]) by atuin.qyliss.net (Postfix) with ESMTPS id 647D41AA18 for ; Fri, 2 Apr 2021 09:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1617354256; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Feedback-ID; bh=gHgW/9mKjBtJImYP07IPm/YLufuyULiU+rGTdPg6DS4=; b=ZoCk2NNU7hZ6R/wVE+8N8cMNpY+jDbhbsPn0HWTnMt1GFi6dsv/QLTKD969hdoU1 8a/SLU+AnFW2AoFD6VDlGjOpoIRz8cauf6vNrhy4jvwn/xsXuvHIJ+1Occr/MFlf/bH Hbj4yu/KM2meTGtQBEqmNBDJQ6mloet6LwnSMvjk= From: Jamie McClymont To: devel@spectrum-os.org Subject: [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch Date: Fri, 2 Apr 2021 09:04:16 +0000 Message-ID: <0100017891d37021-77171648-c191-43da-b065-6eabe8fd7842-000000@email.amazonses.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210402090042.2020627-1-jamie@kwiius.com> References: <20210402090042.2020627-1-jamie@kwiius.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SES-Outgoing: 2021.04.02-54.240.8.86 Feedback-ID: 1.us-east-1.9pXRggpcNqPasnyFcFNFQXAg6PTGO6hwgAZOzryQyDc=:AmazonSES Message-ID-Hash: LGCRJBKQX5OEFZ2BUEPM4L6TBIL3XKXV X-Message-ID-Hash: LGCRJBKQX5OEFZ2BUEPM4L6TBIL3XKXV X-MailFrom: 0100017891d37021-77171648-c191-43da-b065-6eabe8fd7842-000000@amazonses.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Jamie McClymont X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: The missing dependency has been added upstream --- ...03-vm_tools-proto-fix-parallel-build.patch | 39 ------------------- .../linux/chromium-os/vm_protos/default.nix | 2 - 2 files changed, 41 deletions(-) delete mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_to= ols-proto-fix-parallel-build.patch diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-pro= to-fix-parallel-build.patch b/pkgs/os-specific/linux/chromium-os/vm_protos/= 0003-vm_tools-proto-fix-parallel-build.patch deleted file mode 100644 index 93fa535ac7e..00000000000 --- a/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-= parallel-build.patch +++ /dev/null @@ -1,39 +0,0 @@ -From dfed9458bf7abc1dc8f33a3e16ee179cde88e4e2 Mon Sep 17 00:00:00 2001 -From: Alyssa Ross -Date: Tue, 2 Jun 2020 00:21:08 +0000 -Subject: [PATCH 3/6] vm_tools: proto: fix parallel build - -fuzzer-protos depends on vm-crash-rpcs, but this dependency wasn't -declared, causing build failures like the following: - -[26/52] CXX obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer= -protos.fuzzer.grpc.pb.o -FAILED: obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-pro= tos.fuzzer.grpc.pb.o -c++ -MMD -MF obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzze= r-protos.fuzzer.grpc.pb.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FI= LE_OFFSET_BITS=3D64 -Igen/include -I../../common-mk -I/usr/include -Igen -I= gen -Igen -Igen -Wall -Wunused -Wno-unused-parameter -Wunreachable-code -gg= db3 -fstack-protector-strong -Wformat=3D2 -fvisibility=3Dinternal -Wa,--noe= xecstack -Wimplicit-fallthrough -Werror --sysroot=3D -fPIE -fvisibility=3Dd= efault -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/i= nclude -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/inc= lude -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -= pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -= I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/= nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -Wno-unre= achable-code -std=3Dgnu++14 -fno-exceptions -fno-unwind-tables -fno-asynchr= onous-unwind-tables -Wno-psabi -c gen/include/vm_protos/proto_bindings/fuzz= er.grpc.pb.cc -o obj/out/Release/gen/include/vm_protos/proto_bindings/libfu= zzer-protos.fuzzer.grpc.pb.o -In file included from gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.= cc:5: -gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal error: vm_cr= ash.pb.h: No such file or directory - 38 | #include "vm_crash.pb.h" - | ^~~~~~~~~~~~~~~ -compilation terminated. -ninja: build stopped: subcommand failed. - -Reported-by: Cole Helbling -Reviewed-by: Cole Helbling ---- - vm_tools/proto/BUILD.gn | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/vm_tools/proto/BUILD.gn b/vm_tools/proto/BUILD.gn -index 713b81853..a25265cab 100644 ---- a/vm_tools/proto/BUILD.gn -+++ b/vm_tools/proto/BUILD.gn -@@ -70,6 +70,7 @@ proto_library("fuzzer-protos") { - deps =3D [ - ":container-rpcs", - ":tremplin-rpcs", -+ ":vm-crash-rpcs", - ] - sources =3D [ - "${proto_in_dir}/fuzzer.proto", ---=20 -2.26.2 - diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix b/pkg= s/os-specific/linux/chromium-os/vm_protos/default.nix index 4f0aae3be38..e87d0c57e78 100644 --- a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix +++ b/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix @@ -12,8 +12,6 @@ common-mk { "-Wno-error=3Ddeprecated-declarations" ]; =20 - platform2Patches =3D [ ./0003-vm_tools-proto-fix-parallel-build.patch ]; - postPatch =3D '' substituteInPlace common-mk/proto_library.gni \ --replace /usr/bin/grpc_cpp_plugin ${grpc}/bin/grpc_cpp_plugin --=20 2.31.1