From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 434811BA77; Fri, 2 Apr 2021 15:36:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 1B4601BAB0; Fri, 2 Apr 2021 15:36:29 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 5BDA61BA2E; Fri, 2 Apr 2021 15:36:27 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by atuin.qyliss.net (Postfix) with ESMTPS id 248651BA2C for ; Fri, 2 Apr 2021 15:36:23 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 36D8D5C010A; Fri, 2 Apr 2021 11:36:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 02 Apr 2021 11:36:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=Cp0UNoIDLVNP98iCTHPfuzjICW syqMrhe+/MYvzWcuA=; b=Nm2SU0JIXcC7ajCjr7oZJCPSp78YaSH+lL1kwfoWN4 SFhqEGvgg0uuxky+mR5EPUp9hpRwMmb92VL5j04C5qZoYYtRH0n1PyuTukUJ01Ht mQWPferaDbXGWvsJ+A2VyLaNjFj5bnSuzeqmMAIqbj1C9wktoP86QvpzMwdM9Ebw hfUycQfk6gg126ySri8F8kc+bE15aViKKvXX2c0jIcY5+RNsGLLLMH4cYInWXOkr 1QIyHQThRNbWKB10LJSA/+S3ux37YcUpLVPHOZxdqM9by3jUcYfgp3yZb5qnmsbL w3DX9rOoGEjCDe2pemtagQfykZcN1KpK8DM7wWEDjuNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Cp0UNo IDLVNP98iCTHPfuzjICWsyqMrhe+/MYvzWcuA=; b=fwL3dedUUBocVx3YptNf4r om3qiTpbus6GrbK+stWjznuz6bt/7+eoLNCVp+Bd9hwGrJUQqawAn9iR6DQj3/UV AMFLWiZekHp4YxLQ34oes0jh/8wJJOSIpwmeXE60B809Yk/sjza/XZYZb+8bp0yD sNYX6xV8+NjqyvwLQJMphGBzNX+pDfTG+ln4efkTJrNc5fTvYLySCwPe5v/qXPk6 22EBeiyIYtfGLrUhhPTzTY/aFF5ZTIfZehu2OIkdAW5r+bISqbWKXmMo28aUI70D IGHFr+J+iv5IW8yEKIL8z5qr5DyC1oqK5SceDSpeCXHfO2ZjpieV27y/xhYoR5NQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeiiedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepvdeuvd eivdehhfeikedtvddvhefgheffleevueeigffgtdffffeujedujeejkeejnecukfhppeej ledrvdefuddrvdegfedrvddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhish X-ME-Proxy: Received: from x220.qyliss.net (p4fe7f3c9.dip0.t-ipconnect.de [79.231.243.201]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D30F240057; Fri, 2 Apr 2021 11:36:21 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 884C54D0; Fri, 2 Apr 2021 15:36:20 +0000 (UTC) From: Alyssa Ross To: Jamie McClymont Subject: Re: [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config In-Reply-To: <0100017891d36eab-b33cd88c-2b79-4848-8f7b-29cf7ea42e93-000000@email.amazonses.com> References: <20210402090042.2020627-1-jamie@kwiius.com> <0100017891d36eab-b33cd88c-2b79-4848-8f7b-29cf7ea42e93-000000@email.amazonses.com> Date: Fri, 02 Apr 2021 15:35:58 +0000 Message-ID: <87y2e08zs1.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: LKTMHPRNFQM3DPODLW27I5RQZRJZL6A3 X-Message-ID-Hash: LKTMHPRNFQM3DPODLW27I5RQZRJZL6A3 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jamie McClymont writes: > The ANALOGIX_ANX7625 option no longer exists, but VIDEO_INTEL_IPU6 is > now a source of build errors. > --- > pkgs/os-specific/linux/kernel/linux-cros.nix | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/pkgs/os-specific/linux/kernel/linux-cros.nix b/pkgs/os-speci= fic/linux/kernel/linux-cros.nix > index 789a9fb6fd2..d292fe2c54a 100644 > --- a/pkgs/os-specific/linux/kernel/linux-cros.nix > +++ b/pkgs/os-specific/linux/kernel/linux-cros.nix > @@ -29,6 +29,10 @@ buildLinux (args // rec { > # Enabling this (the default) caused a build failure. If you can > # archieve a successful build with this enabled, go ahead and > # enable it. > - ANALOGIX_ANX7625 =3D no; > + VIDEO_INTEL_IPU6 =3D no; > + > + # RTW88_8822*E were being selected as Y when N/m/? are the only vali= d options > + RTW88_8822BE =3D lib.mkForce no; > + RTW88_8822CE =3D lib.mkForce no; What do you think about setting these to "modules" instead of "no"? It looks like that's what we do in Nixpkgs for more recent kernels that behave the same way (not allowing Y). > } // (args.structuredExtraConfig or {}); > } // (args.argsOverride or {})) > --=20 > 2.31.1 Patch LGTM other than that. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBnOd4ACgkQ+dvtSFmy ccA3yg//doG/DcTXQJDivlk7f2ZzKzXOcIERjltPk+gP8djnUCz9dpkK509BgVb+ J8ZArNU3iTInJb121kK1y+C9PaL76UX+IIZVVB8mhEnBTrl8DG6fAkWlxkQEJYwM daW4sNGC/2tQ1K4g8hNn0o9RvFJoKxnJDY6gPduj6BsKFN7B07YqptXrgP1NYiRf 6E4yhndpk+OdyaOsGO01bY7e7fBpjgmnbspmF3ohaWDIwc4XC9z5Uqel6Q9iFWpb f7fjjFOx8zHkJKLZW+xu8mM7R/6Z43aiuit/gnKGdsyo23Bf68SzpvAFti8Od2iS rvJpyH9GPeS202YcrsyGSdKhWhwPtJmaMKciwcovoZBE3rj5V29kCf+FH4h3PZ44 RMKM3oSA6Up1CofKbhJr9IzHwrjxu+YauOUTuAmLYfNaVNJQdlKtTwFEh+4AcEhx uh5QTMByUosLM0bHeFslPn9CTHGlpihTN3DtRavT80J5ysiNoJYi5fQEhHwgDc+n Ad9ufNf4naAIYj8vH1r4mymRP64MqNhQQ5vQMEaNgcWAbuGNd16kzt5yLYNfMWHW h5wmBSvQue3PVQHHeX7RzfMj7W9JMjtl3Cha1wLMc3DoFz+yKWM68/P51PDpR6qC II53uUm3vdnOUpHDAGi22cRkAaY9i1MU8igXDssUsDTP0IIuXCo= =8bow -----END PGP SIGNATURE----- --=-=-=--