From: Alyssa Ross <hi@alyssa.is>
To: Jamie McClymont <jamie@kwiius.com>
Cc: devel@spectrum-os.org
Subject: Re: [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings
Date: Fri, 02 Apr 2021 15:54:51 +0000 [thread overview]
Message-ID: <87mtug8ywk.fsf@alyssa.is> (raw)
In-Reply-To: <0100017891d37b4d-f47bcb1b-a616-4aaa-967e-c242084f7ced-000000@email.amazonses.com>
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
Jamie McClymont <jamie@kwiius.com> writes:
> ---
> pkgs/os-specific/linux/chromium-os/common-mk/default.nix | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Alyssa Ross <hi@alyssa.is>
Tested-by: Alyssa Ross <hi@alyssa.is>
> diff --git a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix b/pkgs/os-specific/linux/chromium-os/common-mk/default.nix
> index cc72aab5d15..d617401138f 100644
> --- a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix
> +++ b/pkgs/os-specific/linux/chromium-os/common-mk/default.nix
> @@ -64,7 +64,11 @@ stdenv.mkDerivation ({
> patchShebangs common-mk
> '' + (lib.optionalString (!stdenv.cc.isClang) ''
> substituteInPlace common-mk/BUILD.gn \
> - --replace '"-Wno-c99-designator",' ""
> + --replace '"-Wno-c99-designator",' "" \
> + --replace '"-Wstring-compare",' "" \
> + --replace '"-Wstring-plus-int",' "" \
> + --replace '"-Wxor-used-as-pow",' "" \
> + --replace '"-Wunreachable-code-return",' ""
> '') + postPatch;
>
> nativeBuildInputs = [ gn pkgconfig python3 ninja ] ++ nativeBuildInputs;
> --
> 2.31.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-04-02 15:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210402090042.2020627-1-jamie@kwiius.com>
2021-04-02 9:04 ` [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch Jamie McClymont
2021-04-02 15:53 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches Jamie McClymont
2021-04-02 15:47 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 1/8] chromiumOSPackages: update 83->89 Jamie McClymont
2021-04-02 14:58 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config Jamie McClymont
2021-04-02 15:35 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings Jamie McClymont
2021-04-02 15:54 ` Alyssa Ross [this message]
2021-04-02 9:04 ` [RFC PATCH 7/8] chromiumOSPackages.crosvm: add platform2 dep Jamie McClymont
2021-04-02 9:04 ` [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches Jamie McClymont
2021-04-02 16:11 ` Alyssa Ross
2021-04-02 17:28 ` Alyssa Ross
2021-04-02 17:18 ` Thomas Leonard
2021-04-02 21:00 ` [PATCH platform2] Revert "Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell"" Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 8/8] chromiumOSPackages.crosvm: bump cargoSha256 Jamie McClymont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtug8ywk.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=jamie@kwiius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).