From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 944581C0EF; Fri, 2 Apr 2021 18:25:56 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 566BF1C0CE; Fri, 2 Apr 2021 18:25:45 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id D19671C04D; Fri, 2 Apr 2021 18:25:42 +0000 (UTC) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by atuin.qyliss.net (Postfix) with ESMTPS id 4CF631C04B for ; Fri, 2 Apr 2021 18:25:40 +0000 (UTC) Received: by mail-vs1-f43.google.com with SMTP id h11so3151589vsl.2 for ; Fri, 02 Apr 2021 11:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FEvRbfk/zwYI3Fu1MMDS1xKkqylSO/6fc6nesohluZ8=; b=ms7Eo84zAYqv/CWUTrDI1gc4/YxzGgOzJZcemp5wbtipycbjnbG0GcbhXODLc+EwQD om7yiDngAhOGqFg2aX0v5BtkzOq+eeotT127obQmya3GlRngl5jYh51LwCFUyMQx8cgU 2t0O65Oh51FMfprDNfL+s822vefP82h4W1P9wp40Y8v61GTzjDysnlU4/SzWsXsFaAH7 FcCjAft8fCb6vMO57KdAHep97cTdQaCG4t/9IhNTVwYwQpsLptgdl5TMtPRwW2Esy51H 8IX/bUO209zK0XVyY95bRIUOGLs5SatxAL74M6YWGYes9HgbTIEMQEjTlYWEULZz7i0I ZaZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FEvRbfk/zwYI3Fu1MMDS1xKkqylSO/6fc6nesohluZ8=; b=oXfRnrTpeWy40q2S1ZE45iiPkNzOXQkZiJYbHX5vXm+76txnPcHVE795ru81G26GZ4 b9bOgnUOcATLMQ4WN6ECUo8X4UFRP+T33EQKWRypXR4G0f5F4m6034YCm7cg6s06IIWk Cp0xdFI1nOahLkCXT42aNSk9uZp8GH16wsT6VPEo86MQC5jhg5es1Dl6ijrxtVvyxcYk FrxS8bbzuzXmDKO9qMZVFGLTiH0nrBOxo2p6jpIzT+6Mnfstvy8aSNEVeAOg10miGJxW g6EMkau2275B3Y1nKagUU/GN8Ywcs+wEMTXSqQbLWR6lNx41Vnb32dHGDJMUeCunK3dX Qaow== X-Gm-Message-State: AOAM531MsiotcwMM6aw4lFtvUCtDGmmnfaxHlHuu5SY1DYDYXcw3oJKl Zw+MtWvj2D7ZQmLnTfU8ecHcAHJ1EvNR00NeCBU= X-Google-Smtp-Source: ABdhPJx+q9JGQpqA9yd0F+C4r8UKfPRIl0vaX6v+4eqNug1SpabiYulx4l+VmbmIujcjZv2tHN+qizC1byKzhM9wp8g= X-Received: by 2002:a05:6102:238f:: with SMTP id v15mr9894689vsr.45.1617387938906; Fri, 02 Apr 2021 11:25:38 -0700 (PDT) MIME-Version: 1.0 References: <20210402090042.2020627-1-jamie@kwiius.com> <0100017891d37f9f-9a88c2a4-d5a3-4f89-94f1-f86a9a8c383f-000000@email.amazonses.com> <87im548y4m.fsf@alyssa.is> <87wntkwq7z.fsf@alyssa.is> In-Reply-To: <87wntkwq7z.fsf@alyssa.is> From: Thomas Leonard Date: Fri, 2 Apr 2021 17:18:38 +0000 Message-ID: Subject: Re: [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches To: Alyssa Ross Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: FVXWV7L62MVZIWOCOCP5ABAZYRI32OLR X-Message-ID-Hash: FVXWV7L62MVZIWOCOCP5ABAZYRI32OLR X-MailFrom: talex5@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Jamie McClymont , devel@spectrum-os.org, Puck Meerburg X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 2 Apr 2021 at 17:28, Alyssa Ross wrote: > > >> The xdg-shell thing has been integrated upstream, and the demos seem to > >> no longer exist. > > Actually, is this true? Looking through the sommelier git log[1] I see > 32050c0ea6c00c16999915856b40a6a6b8b41bb9: > > > Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell" > > > > This reverts commit be4e16feb380360cabbb5d6199a09592ecaf4a42. > > > > Reason for revert: Breaks the version of gtk3 shipped with stretch > > [1]: https://chromium.googlesource.com/chromiumos/platform2/+log/refs/heads/main/vm_tools/sommelier > > The relevant Chromium bugs[2][3] are: > > Issue 1022716: Sommelier does not support the stable xdg-shell > Issue 1120277: GTK3 broken on stretch in M86 > > [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1022716 > [3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1120277 > > It doesn't look like it's been reintroduced since, and there's no > further activity on the bug, so I think current Sommelier doesn't > support stable xdg-shell after all. > > From what I can tell, they backed out stable xdg-shell because their > Debian version is too old to support it. So we probably still need this > patch. It doesn't still apply cleanly, though. It would probably be > better to just revert their revert than to keep carrying around Puck's > version so that we're closer to upstream while still supporting stable > xdg-shell. > > Also CCing Thomas, with whom I've previously talked about stable > xdg-shell in Sommelier, in case he hasn't seen that it was reverted > upstream. Yes, I initially reapplied the sommelier patch switching to the stable xdg-shell version (I had to update it slightly due to the C++ switch). But I've since replaced sommelier with https://github.com/talex5/wayland-virtwl-proxy/, which uses the stable xdg-shell version anyway. -- talex5 (GitHub/Twitter) http://roscidus.com/blog/ GPG: 5DD5 8D70 899C 454A 966D 6A51 7513 3C8F 94F6 E0CC