* [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group
@ 2021-04-22 1:01 Alyssa Ross
2021-04-22 1:35 ` Cole Helbling
0 siblings, 1 reply; 5+ messages in thread
From: Alyssa Ross @ 2021-04-22 1:01 UTC (permalink / raw)
To: devel
/etc/passwd set the messagebus user's primary group to 1, but there
was no group with that id in /etc/group. The messagebus group had id 4.
The 4 comes from NixOS. I think it's probably a good idea to use the
same user and group ids where possible -- there's no particular reason
to diverge -- so let's fix it in /etc/passwd instead of changing the
id in /etc/group to 1.
And while we're here, for consistency, let's change the user id of
messagebus to 4 as well, so that's consistent with NixOS as well.
I don't think the user ID is used anywhere else.
This fixes the DBus "Permission denied" errors that have been showing
up in vm-net since forever (but never seemed to cause any real harm...).
---
pkgs/os-specific/linux/spectrum/rootfs/etc/passwd | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd b/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd
index c76fb8f2a99..ddb1f854a6e 100644
--- a/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd
+++ b/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd
@@ -1,3 +1,3 @@
root:x:0:0:System administrator:/:/bin/sh
-messagebus:x:1:1:D-Bus system message bus daemon user:/run/dbus:/bin/sh
+messagebus:x:4:4:D-Bus system message bus daemon user:/run/dbus:/bin/sh
user:x:1000:1000:User:/:/bin/sh
--
2.31.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group
2021-04-22 1:01 [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group Alyssa Ross
@ 2021-04-22 1:35 ` Cole Helbling
2021-04-22 3:04 ` Josh DuBois
2021-04-22 8:03 ` Alyssa Ross
0 siblings, 2 replies; 5+ messages in thread
From: Cole Helbling @ 2021-04-22 1:35 UTC (permalink / raw)
To: Alyssa Ross, devel
On Wed Apr 21, 2021 at 6:01 PM PDT, Alyssa Ross wrote:
> /etc/passwd set the messagebus user's primary group to 1, but there
> was no group with that id in /etc/group. The messagebus group had id 4.
> The 4 comes from NixOS. I think it's probably a good idea to use the
> same user and group ids where possible -- there's no particular reason
> to diverge -- so let's fix it in /etc/passwd instead of changing the
> id in /etc/group to 1.
>
> And while we're here, for consistency, let's change the user id of
> messagebus to 4 as well, so that's consistent with NixOS as well.
> I don't think the user ID is used anywhere else.
>
> This fixes the DBus "Permission denied" errors that have been showing
> up in vm-net since forever (but never seemed to cause any real harm...).
> ---
> pkgs/os-specific/linux/spectrum/rootfs/etc/passwd | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group
2021-04-22 1:35 ` Cole Helbling
@ 2021-04-22 3:04 ` Josh DuBois
2021-04-22 8:03 ` Alyssa Ross
2021-04-22 8:03 ` Alyssa Ross
1 sibling, 1 reply; 5+ messages in thread
From: Josh DuBois @ 2021-04-22 3:04 UTC (permalink / raw)
To: devel
I love seeing patches come across the mailing list again. :)
(I'm not doing squat with them - literally just reading the subject lines in my email client - but it's still nice. Glad for them!)
> On Apr 21, 2021, at 8:35 PM, Cole Helbling <cole.e.helbling@outlook.com> wrote:
>
> On Wed Apr 21, 2021 at 6:01 PM PDT, Alyssa Ross wrote:
>> /etc/passwd set the messagebus user's primary group to 1, but there
>> was no group with that id in /etc/group. The messagebus group had id 4.
>> The 4 comes from NixOS. I think it's probably a good idea to use the
>> same user and group ids where possible -- there's no particular reason
>> to diverge -- so let's fix it in /etc/passwd instead of changing the
>> id in /etc/group to 1.
>>
>> And while we're here, for consistency, let's change the user id of
>> messagebus to 4 as well, so that's consistent with NixOS as well.
>> I don't think the user ID is used anywhere else.
>>
>> This fixes the DBus "Permission denied" errors that have been showing
>> up in vm-net since forever (but never seemed to cause any real harm...).
>> ---
>> pkgs/os-specific/linux/spectrum/rootfs/etc/passwd | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group
2021-04-22 1:35 ` Cole Helbling
2021-04-22 3:04 ` Josh DuBois
@ 2021-04-22 8:03 ` Alyssa Ross
1 sibling, 0 replies; 5+ messages in thread
From: Alyssa Ross @ 2021-04-22 8:03 UTC (permalink / raw)
To: Cole Helbling; +Cc: devel
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
>> /etc/passwd set the messagebus user's primary group to 1, but there
>> was no group with that id in /etc/group. The messagebus group had id 4.
>> The 4 comes from NixOS. I think it's probably a good idea to use the
>> same user and group ids where possible -- there's no particular reason
>> to diverge -- so let's fix it in /etc/passwd instead of changing the
>> id in /etc/group to 1.
>>
>> And while we're here, for consistency, let's change the user id of
>> messagebus to 4 as well, so that's consistent with NixOS as well.
>> I don't think the user ID is used anywhere else.
>>
>> This fixes the DBus "Permission denied" errors that have been showing
>> up in vm-net since forever (but never seemed to cause any real harm...).
>> ---
>> pkgs/os-specific/linux/spectrum/rootfs/etc/passwd | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Pushed as 5ebae3db48b. :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-22 8:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 1:01 [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group Alyssa Ross
2021-04-22 1:35 ` Cole Helbling
2021-04-22 3:04 ` Josh DuBois
2021-04-22 8:03 ` Alyssa Ross
2021-04-22 8:03 ` Alyssa Ross
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).