From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id B09DE170B6; Thu, 22 Apr 2021 03:04:33 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 7F9FE17054; Thu, 22 Apr 2021 03:04:27 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 11B591709B; Thu, 22 Apr 2021 03:04:25 +0000 (UTC) Received: from jax4mhob10.registeredsite.com (jax4mhob10.myregisteredsite.com [64.69.218.90]) by atuin.qyliss.net (Postfix) with ESMTPS id 5CAFC17037 for ; Thu, 22 Apr 2021 03:04:22 +0000 (UTC) Received: from mailpod.hostingplatform.com ([10.30.71.113]) by jax4mhob10.registeredsite.com (8.14.4/8.14.4) with ESMTP id 13M34CBx028491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 21 Apr 2021 23:04:12 -0400 Received: (qmail 4529 invoked by uid 0); 22 Apr 2021 03:04:12 -0000 X-TCPREMOTEIP: 50.93.248.134 X-Authenticated-UID: josh@joshdubois.com Received: from unknown (HELO ?192.168.1.4?) (josh@joshdubois.com@50.93.248.134) by 0 with ESMTPA; 22 Apr 2021 03:04:12 -0000 From: Josh DuBois Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group Date: Wed, 21 Apr 2021 22:04:12 -0500 References: To: devel@spectrum-os.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3608.80.23.2.2) Message-ID-Hash: 5XD4OIKX6OZUPJNF26LXWCYJOMH7APQZ X-Message-ID-Hash: 5XD4OIKX6OZUPJNF26LXWCYJOMH7APQZ X-MailFrom: josh@joshdubois.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I love seeing patches come across the mailing list again. :) (I'm not doing squat with them - literally just reading the subject = lines in my email client - but it's still nice. Glad for them!) > On Apr 21, 2021, at 8:35 PM, Cole Helbling = wrote: >=20 > On Wed Apr 21, 2021 at 6:01 PM PDT, Alyssa Ross wrote: >> /etc/passwd set the messagebus user's primary group to 1, but there >> was no group with that id in /etc/group. The messagebus group had id = 4. >> The 4 comes from NixOS. I think it's probably a good idea to use the >> same user and group ids where possible -- there's no particular = reason >> to diverge -- so let's fix it in /etc/passwd instead of changing the >> id in /etc/group to 1. >>=20 >> And while we're here, for consistency, let's change the user id of >> messagebus to 4 as well, so that's consistent with NixOS as well. >> I don't think the user ID is used anywhere else. >>=20 >> This fixes the DBus "Permission denied" errors that have been showing >> up in vm-net since forever (but never seemed to cause any real = harm...). >> --- >> pkgs/os-specific/linux/spectrum/rootfs/etc/passwd | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Reviewed-by: Cole Helbling