From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group
Date: Thu, 22 Apr 2021 08:03:04 +0000 [thread overview]
Message-ID: <87h7jyiw5j.fsf@alyssa.is> (raw)
In-Reply-To: <SJ0PR03MB55818DE7E2AA4BD6F7FFA821B3469@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
>> /etc/passwd set the messagebus user's primary group to 1, but there
>> was no group with that id in /etc/group. The messagebus group had id 4.
>> The 4 comes from NixOS. I think it's probably a good idea to use the
>> same user and group ids where possible -- there's no particular reason
>> to diverge -- so let's fix it in /etc/passwd instead of changing the
>> id in /etc/group to 1.
>>
>> And while we're here, for consistency, let's change the user id of
>> messagebus to 4 as well, so that's consistent with NixOS as well.
>> I don't think the user ID is used anywhere else.
>>
>> This fixes the DBus "Permission denied" errors that have been showing
>> up in vm-net since forever (but never seemed to cause any real harm...).
>> ---
>> pkgs/os-specific/linux/spectrum/rootfs/etc/passwd | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Pushed as 5ebae3db48b. :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2021-04-22 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 1:01 Alyssa Ross
2021-04-22 1:35 ` Cole Helbling
2021-04-22 3:04 ` Josh DuBois
2021-04-22 8:03 ` Alyssa Ross
2021-04-22 8:03 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7jyiw5j.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).