From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: Re: [PATCH ucspi-vsock 0/7] Extract vsockserver-socketbinder and vsockserverd
Date: Fri, 19 Mar 2021 03:19:16 +0000 [thread overview]
Message-ID: <87lfajakzv.fsf@alyssa.is> (raw)
In-Reply-To: <20210319025349.8839-1-hi@alyssa.is>
[-- Attachment #1: Type: text/plain, Size: 2283 bytes --]
Alyssa Ross <hi@alyssa.is> writes:
> This series breaks vsockserver apart into two smaller programs,
> vsockserver-socketbinder and vsockserverd. vsockserver-socketbinder
> binds and listens on an AF_VSOCK socket and then execs into another
> program with the socket as stdin. vsockserverd accepts connections to
> a socket provided on stdin, and for each connection runs a program
> with the connection socket on stdin and stdout. vsockserver is
> replaced with a program that builds an argv that just combines these
> two smaller programs and execs into it.
>
> This design is based on s6[1]'s s6-ipcserver,
> s6-ipcserver-socketbinder, and s6-ipcserverd programs.
>
> [1]: https://skarnet.org/software/s6/
> [2]: https://skarnet.org/software/s6-rc/
>
> Alyssa Ross (7):
> vsock: get cid and port instead of just cid
> vsock: check socket family before reading sockaddr
> vsockserver: switch to a non-blocking socket
> configure: create, to generate config.h
> log: add die function
> exec: add execzp()
> Extract vsockserver-socketbinder and vsockserverd
>
> .gitignore | 7 +-
> Makefile | 33 --------
> Makefile.in | 47 +++++++++++
> configure | 49 ++++++++++++
> exec.c | 22 +++++
> exec.h | 7 ++
> log.c | 10 +++
> log.h | 8 +-
> vsock.c | 32 ++++++--
> vsock.h | 14 +++-
> vsockserver-socketbinder.c | 86 ++++++++++++++++++++
> vsockserver.c | 137 +++++++++++++++-----------------
> vsockserver.c => vsockserverd.c | 73 +++++++++--------
> 13 files changed, 368 insertions(+), 157 deletions(-)
> delete mode 100644 Makefile
> create mode 100644 Makefile.in
> create mode 100755 configure
> create mode 100644 exec.c
> create mode 100644 exec.h
> create mode 100644 vsockserver-socketbinder.c
> copy vsockserver.c => vsockserverd.c (55%)
>
> --
> 2.30.0
Whoops, I messed up the threading. Implementation begins here:
https://spectrum-os.org/lists/archives/spectrum-devel/20210319025648.17925-1-hi@alyssa.is/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-03-19 3:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 3:23 Broken threading fix Alyssa Ross
2021-03-19 2:56 ` [PATCH ucspi-vsock 1/7] vsock: get cid and port instead of just cid Alyssa Ross
2021-03-19 2:53 ` [PATCH ucspi-vsock 0/7] Extract vsockserver-socketbinder and vsockserverd Alyssa Ross
2021-03-19 3:19 ` Alyssa Ross [this message]
2021-03-19 2:56 ` [PATCH ucspi-vsock 2/7] vsock: check socket family before reading sockaddr Alyssa Ross
2021-03-19 2:56 ` [PATCH ucspi-vsock 3/7] vsockserver: switch to a non-blocking socket Alyssa Ross
2021-03-19 2:56 ` [PATCH ucspi-vsock 4/7] configure: create, to generate config.h Alyssa Ross
2021-03-19 2:56 ` [PATCH ucspi-vsock 5/7] log: add die function Alyssa Ross
2021-03-19 2:56 ` [PATCH ucspi-vsock 6/7] exec: add execzp() Alyssa Ross
2021-03-19 3:17 ` [PATCH ucspi-vsock 7/7] Extract vsockserver-socketbinder and vsockserverd Alyssa Ross
2021-03-19 3:39 ` Cole Helbling
2021-03-20 20:24 ` Alyssa Ross
2021-03-21 2:52 ` Cole Helbling
2021-03-21 14:33 ` Alyssa Ross
2021-03-21 14:38 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfajakzv.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).