From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id A901E864E; Fri, 19 Mar 2021 03:19:36 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 9BAEF86A8; Fri, 19 Mar 2021 03:19:25 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 597598693; Fri, 19 Mar 2021 03:19:23 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by atuin.qyliss.net (Postfix) with ESMTPS id C70EE8691 for ; Fri, 19 Mar 2021 03:19:20 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 14E6C5C01A0 for ; Thu, 18 Mar 2021 23:19:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 18 Mar 2021 23:19:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=l8ZQVM0hJbqhUF4jB9tBqAcY0t sDGaadn1cS9v/BzMs=; b=e8+pyuyOWdKvMWMAZdtVDkbekX7hXaMVdM8WgzGzxW 0WtS9SE4eEK+opuGaR11ICsnUpHgMpk3JOwcH4rej6qGd8DJZRhcVuJ3XFq7IUtQ vnqOPyTJl/gcBdnqXS0u9JRyQ1YX8FYSLnFErzyfIsz4Cja0JnRzNdf3nvSn3E9+ hO+QhWpl7kfC6omG0f6R17UJLR/5elYG9pN436ANS0TeskwShe45K5N9lfq+j5T3 WmWIg+5d1ZfFYaiE+ZBfqcz2udjaQ9S5fzkc81kU6LD1v3vhAaxFtDokV5MNOvlC 7MFzslqV2ncGwyy7j+KEdIL534tldY6jyvKGLLPOtd5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=l8ZQVM 0hJbqhUF4jB9tBqAcY0tsDGaadn1cS9v/BzMs=; b=OfMaWxO9FjIHkyF0PHE2J2 ylYb2/YKpfwj2FKGOX7hJwY+uHHfr/5xbF5i62CDGFZzGvM75qZzBGg2HfU7oxim CtbFoevYNNRmcTYd/EKuQtc60g7mCsMwZ7uEipJT2y/tj7VHBqFDlIU0ldvVv/ev Us5+i3jy7ywDMF8bXEkW1cD7JG3PlZNUnehSPE9SjjIyI762jBYmv1eG6FxAkzD8 gQglugZdpk/Xkh/iUPno0DxixKwl0Z8U7IF6M4Y++4wYtxg9l6SPX/+gCfLbwghj HJ6IfpoIA/z64LtAlZqpFRaaLY41ZIJy6lVi7k4IzOE073MmbxFSaiLA0sHOeu9Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefjedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffffkgggtsehgtderre dttddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhs qeenucggtffrrghtthgvrhhnpefhtdeitedtveelhefghfehvdegudegueelleduudekue ethfejffekgeeihfduhfenucffohhmrghinhepshhkrghrnhgvthdrohhrghdpshhpvggt thhruhhmqdhoshdrohhrghenucfkphepkeegrddukeegrddvfedvrddukedtnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhs rgdrihhs X-ME-Proxy: Received: from x220.qyliss.net (p54b8e8b4.dip0.t-ipconnect.de [84.184.232.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F22C1080057 for ; Thu, 18 Mar 2021 23:19:19 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 8BF312002; Fri, 19 Mar 2021 03:19:18 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: Re: [PATCH ucspi-vsock 0/7] Extract vsockserver-socketbinder and vsockserverd In-Reply-To: <20210319025349.8839-1-hi@alyssa.is> References: <20210319025349.8839-1-hi@alyssa.is> Date: Fri, 19 Mar 2021 03:19:16 +0000 Message-ID: <87lfajakzv.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: LOD2CO2NAQQ3Q52ZNOSAVTFG4HI3N5EX X-Message-ID-Hash: LOD2CO2NAQQ3Q52ZNOSAVTFG4HI3N5EX X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alyssa Ross writes: > This series breaks vsockserver apart into two smaller programs, > vsockserver-socketbinder and vsockserverd. vsockserver-socketbinder > binds and listens on an AF_VSOCK socket and then execs into another > program with the socket as stdin. vsockserverd accepts connections to > a socket provided on stdin, and for each connection runs a program > with the connection socket on stdin and stdout. vsockserver is > replaced with a program that builds an argv that just combines these > two smaller programs and execs into it. > > This design is based on s6[1]'s s6-ipcserver, > s6-ipcserver-socketbinder, and s6-ipcserverd programs. > > [1]: https://skarnet.org/software/s6/ > [2]: https://skarnet.org/software/s6-rc/ > > Alyssa Ross (7): > vsock: get cid and port instead of just cid > vsock: check socket family before reading sockaddr > vsockserver: switch to a non-blocking socket > configure: create, to generate config.h > log: add die function > exec: add execzp() > Extract vsockserver-socketbinder and vsockserverd > > .gitignore | 7 +- > Makefile | 33 -------- > Makefile.in | 47 +++++++++++ > configure | 49 ++++++++++++ > exec.c | 22 +++++ > exec.h | 7 ++ > log.c | 10 +++ > log.h | 8 +- > vsock.c | 32 ++++++-- > vsock.h | 14 +++- > vsockserver-socketbinder.c | 86 ++++++++++++++++++++ > vsockserver.c | 137 +++++++++++++++----------------- > vsockserver.c =3D> vsockserverd.c | 73 +++++++++-------- > 13 files changed, 368 insertions(+), 157 deletions(-) > delete mode 100644 Makefile > create mode 100644 Makefile.in > create mode 100755 configure > create mode 100644 exec.c > create mode 100644 exec.h > create mode 100644 vsockserver-socketbinder.c > copy vsockserver.c =3D> vsockserverd.c (55%) > > --=20 > 2.30.0 Whoops, I messed up the threading. Implementation begins here: https://spectrum-os.org/lists/archives/spectrum-devel/20210319025648.17925-= 1-hi@alyssa.is/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBUGDQACgkQ+dvtSFmy ccDK/Q//Rn5zzQwqxf4e73e4JaeFGXXaC41OFDBIcg4SnO/kyGLxyLr/lRRqGBX5 TvZr9dZ7/D1bd2Ca26EDlPxFOzaO4hHp4Myg7XJQjBVClmM38P3t9N89seSGI1dh OGtzHx8NzhjqzB1ugfNPn7bW7EnkqhLfLIb3tzVATWEaTF4FcCo5E7pSjGxXh6uv 7NJwU8CF/btIKv4KgssIQxXLU+poy3cUblBQg4PDZrUqU/3ZqmlUn81Ez3VFy00f e5onwSzDrRE9FJ+pyX4XtBs5wUDysxzIk6IBRPIN4wIGZLgW+ogdTtAxKqIpdDe4 5xpVV9wX3NFDZ5H/LRbD10w/qMBCLEwYrYZixxZiuGRG3Pd0ApxCrTdegZpdYWug nH8gihujzio/hJOJo9mySqYl//T6t/8DzSGGv715AL/XQy6JQw/8Clz7kKkFSZSY S8CsN8MSpzDDpUYS28Lnx1jA0oc51O91udQCpfqTWpXKnMxYqDXbBaQMhsW1Xubp jB2OsuopDbN9voOrWIyFPGNzwVP6wrKC2UCjRRWAHXm6dT31qn9r0m9mKl76Purm wQhiIP1AGeZUpEfWrURhcSvYEAabVRUVJlHCfAPmzU3heq0oahncbeud2QCpMUAE 9KsDkoiQRTFzgjCSs54RVY1jsxsCaiuvkCsE6VK0y4vXdVDbKH4= =8dt3 -----END PGP SIGNATURE----- --=-=-=--