patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: [PATCH ucspi-vsock 5/7] log: add die function
Date: Fri, 19 Mar 2021 02:56:51 +0000	[thread overview]
Message-ID: <20210319025648.17925-5-hi@alyssa.is> (raw)
In-Reply-To: <20210319025349.8839-2-hi@alyssa.is>

This is useful if we want to provide a more specific error message
than strerror can provide.
---
 log.c | 10 ++++++++++
 log.h |  8 ++++----
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/log.c b/log.c
index cdfacd6..8a57105 100644
--- a/log.c
+++ b/log.c
@@ -62,6 +62,16 @@ void ilog(const char *fmt, ...)
 	va_end(ap);
 }
 
+void die(int eval, const char *fmt, ...)
+{
+	va_list ap;
+	va_start(ap, fmt);
+	velog(fmt, ap);
+	va_end(ap);
+
+	exit(eval);
+}
+
 void diee(int eval, const char *fmt, ...)
 {
 	va_list ap;
diff --git a/log.h b/log.h
index 7b40e48..706d42f 100644
--- a/log.h
+++ b/log.h
@@ -11,20 +11,20 @@ enum verbosity {
 
 extern enum verbosity verbosity;
 
+// Functions with an `e' suffix additionally print strerrno(errno).
+
 // If opt is a character that matches a standard UCSPI command line
 // verbosity option, sets the verbosity appropriately and returns
 // true.  Otherwise, returns false.
 _Bool set_verbosity(int opt);
 
-// Log an error message, followed by strerrno(errno), then exit with
-// status eval.
+// Log an error message then exit with status eval.
+_Noreturn void die(int eval, const char *fmt, ...);
 _Noreturn void diee(int eval, const char *fmt, ...);
 
 // Log an error message.
 void elog(const char *fmt, ...);
 void velog(const char *fmt, va_list args);
-
-// Log an error message, followed by strerror(errno).
 void veloge(const char *fmt, va_list args);
 
 // Log an informative message.
-- 
2.30.0

  parent reply	other threads:[~2021-03-19  3:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  3:23 Broken threading fix Alyssa Ross
2021-03-19  2:56 ` [PATCH ucspi-vsock 1/7] vsock: get cid and port instead of just cid Alyssa Ross
2021-03-19  2:53   ` [PATCH ucspi-vsock 0/7] Extract vsockserver-socketbinder and vsockserverd Alyssa Ross
2021-03-19  3:19     ` Alyssa Ross
2021-03-19  2:56 ` [PATCH ucspi-vsock 2/7] vsock: check socket family before reading sockaddr Alyssa Ross
2021-03-19  2:56 ` [PATCH ucspi-vsock 3/7] vsockserver: switch to a non-blocking socket Alyssa Ross
2021-03-19  2:56 ` [PATCH ucspi-vsock 4/7] configure: create, to generate config.h Alyssa Ross
2021-03-19  2:56 ` Alyssa Ross [this message]
2021-03-19  2:56 ` [PATCH ucspi-vsock 6/7] exec: add execzp() Alyssa Ross
2021-03-19  3:17 ` [PATCH ucspi-vsock 7/7] Extract vsockserver-socketbinder and vsockserverd Alyssa Ross
2021-03-19  3:39   ` Cole Helbling
2021-03-20 20:24     ` Alyssa Ross
2021-03-21  2:52       ` Cole Helbling
2021-03-21 14:33         ` Alyssa Ross
2021-03-21 14:38           ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210319025648.17925-5-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).