From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH nixpkgs 0/6] Fix build failures after Nixpkgs update
Date: Tue, 3 Aug 2021 07:57:36 +0000 [thread overview]
Message-ID: <20210803075736.3tfflihw6m5hoew3@eve.qyliss.net> (raw)
In-Reply-To: <SJ0PR03MB55811108147CAB59311CCC07B3EF9@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]
On Mon, Aug 02, 2021 at 01:32:42PM -0700, Cole Helbling wrote:
> On Thu Jul 29, 2021 at 3:09 AM PDT, Alyssa Ross wrote:
> > Alyssa Ross (6):
> > chromiumOSPackages.vm_protos: set full go_package
> > chromiumOSPackages.modemmanager: disable patches
> > chromiumOSPackages.modemmanager-next: add gtk-doc
> > chromiumOSPackages.libqmi: disable QRTR
> > linux_cros: fix build
> > wlroots: update Spectrum patches
> >
> > ...ayland-downgrade-to-wl_compositor-v3.patch | 64 ++++++-----
> > ...til-support-virtio_wl-shm-allocation.patch | 11 +-
> > ...-mk-don-t-leak-source-absolute-paths.patch | 4 +-
> > ...ommon-mk-.gn-don-t-hardcode-env-path.patch | 4 +-
> > .../os-specific/linux/chromium-os/default.nix | 3 +-
> > .../linux/chromium-os/libqmi/default.nix | 4 +-
> > .../chromium-os/modem-manager/default.nix | 2 +
> > .../linux/chromium-os/modem-manager/next.nix | 6 +-
> > ...er-don-t-leak-source-absolute-paths.patch} | 6 +-
> > ...tools-sommelier-Switch-to-the-stabl.patch} | 6 +-
> > .../linux/chromium-os/sommelier/default.nix | 4 +-
> > ...-goproto_library-source_relative-opt.patch | 48 +++++++++
> > ...tools-proto-set-go_package-correctly.patch | 102 ++++++++++++++++++
> > .../linux/chromium-os/vm_protos/default.nix | 5 +
> > 14 files changed, 222 insertions(+), 47 deletions(-)
> > rename pkgs/os-specific/linux/chromium-os/sommelier/{0003-sommelier-don-t-leak-source-absolute-paths.patch => 0005-sommelier-don-t-leak-source-absolute-paths.patch} (82%)
> > rename pkgs/os-specific/linux/chromium-os/sommelier/{0004-Revert-Revert-vm_tools-sommelier-Switch-to-the-stabl.patch => 0006-Revert-Revert-vm_tools-sommelier-Switch-to-the-stabl.patch} (99%)
> > create mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0003-common-mk-add-goproto_library-source_relative-opt.patch
> > create mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0004-vm_tools-proto-set-go_package-correctly.patch
> >
> >
> > base-commit: cab13e087c80c4e7476bb7df432e2b7deb56563d
> > --
> > 2.32.0
>
> Patchset LGTM. I didn't really look at the Spectrum patches updates because I
> don't want to read C at the moment... :P
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Okay, in that case I'll leave off the R-b for the final patch, since
it's just a big C change.
> P.S.: Sorry for the lateness. These days, I work in the mornings and when I'm
> done, I just play video games for the rest of the night, not dedicating any time
> to other things that I should...
No worries! Thanks as always for being a reviewer!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-08-03 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 10:09 Alyssa Ross
2021-07-29 10:09 ` [PATCH nixpkgs 1/6] chromiumOSPackages.vm_protos: set full go_package Alyssa Ross
2021-07-29 10:09 ` [PATCH nixpkgs 2/6] chromiumOSPackages.modemmanager: disable patches Alyssa Ross
2021-07-29 10:09 ` [PATCH nixpkgs 3/6] chromiumOSPackages.modemmanager-next: add gtk-doc Alyssa Ross
2021-07-29 10:09 ` [PATCH nixpkgs 4/6] chromiumOSPackages.libqmi: disable QRTR Alyssa Ross
2021-07-29 10:09 ` [PATCH nixpkgs 5/6] linux_cros: fix build Alyssa Ross
2021-07-29 10:09 ` [PATCH nixpkgs 6/6] wlroots: update Spectrum patches Alyssa Ross
2021-08-02 20:32 ` [PATCH nixpkgs 0/6] Fix build failures after Nixpkgs update Cole Helbling
2021-08-03 7:57 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803075736.3tfflihw6m5hoew3@eve.qyliss.net \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).