On Mon, Aug 02, 2021 at 01:32:42PM -0700, Cole Helbling wrote:
> On Thu Jul 29, 2021 at 3:09 AM PDT, Alyssa Ross wrote:
> > Alyssa Ross (6):
> >   chromiumOSPackages.vm_protos: set full go_package
> >   chromiumOSPackages.modemmanager: disable patches
> >   chromiumOSPackages.modemmanager-next: add gtk-doc
> >   chromiumOSPackages.libqmi: disable QRTR
> >   linux_cros: fix build
> >   wlroots: update Spectrum patches
> >
> >  ...ayland-downgrade-to-wl_compositor-v3.patch |  64 ++++++-----
> >  ...til-support-virtio_wl-shm-allocation.patch |  11 +-
> >  ...-mk-don-t-leak-source-absolute-paths.patch |   4 +-
> >  ...ommon-mk-.gn-don-t-hardcode-env-path.patch |   4 +-
> >  .../os-specific/linux/chromium-os/default.nix |   3 +-
> >  .../linux/chromium-os/libqmi/default.nix      |   4 +-
> >  .../chromium-os/modem-manager/default.nix     |   2 +
> >  .../linux/chromium-os/modem-manager/next.nix  |   6 +-
> >  ...er-don-t-leak-source-absolute-paths.patch} |   6 +-
> >  ...tools-sommelier-Switch-to-the-stabl.patch} |   6 +-
> >  .../linux/chromium-os/sommelier/default.nix   |   4 +-
> >  ...-goproto_library-source_relative-opt.patch |  48 +++++++++
> >  ...tools-proto-set-go_package-correctly.patch | 102 ++++++++++++++++++
> >  .../linux/chromium-os/vm_protos/default.nix   |   5 +
> >  14 files changed, 222 insertions(+), 47 deletions(-)
> >  rename pkgs/os-specific/linux/chromium-os/sommelier/{0003-sommelier-don-t-leak-source-absolute-paths.patch => 0005-sommelier-don-t-leak-source-absolute-paths.patch} (82%)
> >  rename pkgs/os-specific/linux/chromium-os/sommelier/{0004-Revert-Revert-vm_tools-sommelier-Switch-to-the-stabl.patch => 0006-Revert-Revert-vm_tools-sommelier-Switch-to-the-stabl.patch} (99%)
> >  create mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0003-common-mk-add-goproto_library-source_relative-opt.patch
> >  create mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0004-vm_tools-proto-set-go_package-correctly.patch
> >
> >
> > base-commit: cab13e087c80c4e7476bb7df432e2b7deb56563d
> > --
> > 2.32.0
>
> Patchset LGTM. I didn't really look at the Spectrum patches updates because I
> don't want to read C at the moment... :P
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>

Okay, in that case I'll leave off the R-b for the final patch, since
it's just a big C change.

> P.S.: Sorry for the lateness. These days, I work in the mornings and when I'm
> done, I just play video games for the rest of the night, not dedicating any time
> to other things that I should...

No worries!  Thanks as always for being a reviewer!