From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id A5D47248CC; Tue, 3 Aug 2021 07:57:55 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id F1D45248A7; Tue, 3 Aug 2021 07:57:47 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 4650924914; Tue, 3 Aug 2021 07:57:45 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by atuin.qyliss.net (Postfix) with ESMTPS id 3B8942489C for ; Tue, 3 Aug 2021 07:57:41 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 19BFE5C00AA; Tue, 3 Aug 2021 03:57:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 03 Aug 2021 03:57:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=121FDw/2S9TqQQ5m6F0ZBYftAL+ i8cJpCRng5gZv+Ro=; b=y4clRRGjTMiqp6DI2lu7Q1rAwb2Q1kwJzRthn92dND2 TFzRvy4dwSlx7FWDOybq6I0SD1BgQ51yRDmkNPkaMdRXl/bx/anCVMVNfe07PW6a MjIO0h8zJ+xgQU8vWGiECSC5bwPO8DktD59Dcr1cxMgew9MulpZjulTrESawN8OX aKU/czQkbiU9JYwvuXKEo0rqmATTqJT8dbgE/LscF2dhv8j+nfRakcjD4pNla+Jh duQenPZtLBq3HEg4eUpf+FU7jDA7CDe3RcWZXKDrPMz23v3+I6QMVq8nfyT472gd ulLPXXra0a+ejo4CPqLk5eG56p2Ad5yZmtk6G/hJDLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=121FDw /2S9TqQQ5m6F0ZBYftAL+i8cJpCRng5gZv+Ro=; b=XHaOMyTlJ6RFV3PP1FtnTE XKjEr/hVyji0y1kNhKXuSmnoLLVdJZhUNQ5FaFVhdcaYsSGEsSl+wcNToWkIEll2 ket1scceU8LtHOT93di0YcOJHOCZJQ8EI8JfOuz1rlzqC50cowxbVliT3zh3gxKD 6OaJOaKMXiBWk1VQVV/y69MgltGuUnshR3DOfsbfejnmOCNCYy7jENRoxI9r0vm5 XJGl5EHCmjO8e6nHQtek+hhGDzR4cjCs44XtdoR3ui8qoEtXz36GoMH7CCbv95hd tui+iTHB0eGmEgO/WJH0wQFEUkRSjIjzXLbv5Z+5kyNJchF7eo9SfkvU8TaEAfUg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieefgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtddtredttddvnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeuff egffdtvdffiedttefggfehtdfgudfhfffgteefgfdugeegveffieffudduvdenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhsshesvg hvvgdrqhihlhhishhsrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Aug 2021 03:57:39 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id DFF3713E5; Tue, 3 Aug 2021 07:57:36 +0000 (UTC) Date: Tue, 3 Aug 2021 07:57:36 +0000 From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH nixpkgs 0/6] Fix build failures after Nixpkgs update Message-ID: <20210803075736.3tfflihw6m5hoew3@eve.qyliss.net> References: <20210729100928.1965341-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3s7buh6pkkw37klb" Content-Disposition: inline In-Reply-To: Message-ID-Hash: O2M2J2ZKTRMO3BNUNOBITCB4NUX7KOBS X-Message-ID-Hash: O2M2J2ZKTRMO3BNUNOBITCB4NUX7KOBS X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3s7buh6pkkw37klb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 02, 2021 at 01:32:42PM -0700, Cole Helbling wrote: > On Thu Jul 29, 2021 at 3:09 AM PDT, Alyssa Ross wrote: > > Alyssa Ross (6): > > chromiumOSPackages.vm_protos: set full go_package > > chromiumOSPackages.modemmanager: disable patches > > chromiumOSPackages.modemmanager-next: add gtk-doc > > chromiumOSPackages.libqmi: disable QRTR > > linux_cros: fix build > > wlroots: update Spectrum patches > > > > ...ayland-downgrade-to-wl_compositor-v3.patch | 64 ++++++----- > > ...til-support-virtio_wl-shm-allocation.patch | 11 +- > > ...-mk-don-t-leak-source-absolute-paths.patch | 4 +- > > ...ommon-mk-.gn-don-t-hardcode-env-path.patch | 4 +- > > .../os-specific/linux/chromium-os/default.nix | 3 +- > > .../linux/chromium-os/libqmi/default.nix | 4 +- > > .../chromium-os/modem-manager/default.nix | 2 + > > .../linux/chromium-os/modem-manager/next.nix | 6 +- > > ...er-don-t-leak-source-absolute-paths.patch} | 6 +- > > ...tools-sommelier-Switch-to-the-stabl.patch} | 6 +- > > .../linux/chromium-os/sommelier/default.nix | 4 +- > > ...-goproto_library-source_relative-opt.patch | 48 +++++++++ > > ...tools-proto-set-go_package-correctly.patch | 102 ++++++++++++++++++ > > .../linux/chromium-os/vm_protos/default.nix | 5 + > > 14 files changed, 222 insertions(+), 47 deletions(-) > > rename pkgs/os-specific/linux/chromium-os/sommelier/{0003-sommelier-don-t-leak-source-absolute-paths.patch => 0005-sommelier-don-t-leak-source-absolute-paths.patch} (82%) > > rename pkgs/os-specific/linux/chromium-os/sommelier/{0004-Revert-Revert-vm_tools-sommelier-Switch-to-the-stabl.patch => 0006-Revert-Revert-vm_tools-sommelier-Switch-to-the-stabl.patch} (99%) > > create mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0003-common-mk-add-goproto_library-source_relative-opt.patch > > create mode 100644 pkgs/os-specific/linux/chromium-os/vm_protos/0004-vm_tools-proto-set-go_package-correctly.patch > > > > > > base-commit: cab13e087c80c4e7476bb7df432e2b7deb56563d > > -- > > 2.32.0 > > Patchset LGTM. I didn't really look at the Spectrum patches updates because I > don't want to read C at the moment... :P > > Reviewed-by: Cole Helbling Okay, in that case I'll leave off the R-b for the final patch, since it's just a big C change. > P.S.: Sorry for the lateness. These days, I work in the mornings and when I'm > done, I just play video games for the rest of the night, not dedicating any time > to other things that I should... No worries! Thanks as always for being a reviewer! --3s7buh6pkkw37klb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmEI9u8ACgkQ+dvtSFmy ccCxmhAAnyQ4OYoYAiMPvrUBs/pir8Ee1VIdyTuSujaDy7EA/rBzUjZqaazkrqUo tPkJ6Ia4PI6lKxo46yquA33wcF7x2noHu0skYygb6bARmJUSMWQ+tYJmSeEt7LLf ZJo1cthgmDqQWs1QOjUoE0oX5xFKpoKZFsMRkxSXtTinaedAr4VwVuxFZnAQfBAK QPzerOATVH/bVV/vm/RxuCj1r+Oe9cTuUVen8GrdBh2RDKXxHBT+zbRfKeeGRxjo K1V+bscB5J4ZE7rAEiWDMrhftyeRSadOBef3zwaP/fr3fwaBAJsz+ve/0az/xKYX Ar0HuO2Mx9dLPYAY4evjR/NJ3+4swXgPMazlC79e0/S1JPgO+m56RjiE2TSDK4Lk dGSCclyPJx1r4zY7hb8JhCimqC0klApEHLJ9wvh5EFq+4Dq6xn+GbM98zQaNKlC2 Zcisy/MqNHTgwzWORxnJThwF098ptQGTppgLUeHSLUuwiJmE6a5uuFnhfdWyS1HS Vp9kqjOnnUBW7k4UK8xe/BIGbxEwipHmNb+xGHxeKgzdwl7Hw4gP0q+A1TnOU9h3 /XAipTqxXuL+WPSDYZKy5Lsan6g4HzKkNCUGpteovmD+iQetCUbMWU2mqzPT9d4S pn+3SIIVAPG3iz6zvX0JPm5OqhZQW54RdmXRs7XKd41FliiQ2VI= =paTn -----END PGP SIGNATURE----- --3s7buh6pkkw37klb--