From: Ville Ilvonen <ville.ilvonen@unikie.com>
To: Alyssa Ross <hi@alyssa.is>, devel@spectrum-os.org
Subject: Re: [PATCH] Documentation: clarify value of spectrum-config
Date: Thu, 22 Sep 2022 15:33:26 +0300 [thread overview]
Message-ID: <fa92131f-d6ed-944e-93a0-022abfbac943@unikie.com> (raw)
In-Reply-To: <20220921133341.3120867-1-hi@alyssa.is>
On 9/21/22 16:33, Alyssa Ross wrote:
> Before, it was not clear that spectrum-config should be set to a file
> path, rather than a directory — i.e. whether it override the root of
> the source tree, or the config.nix path within it. This change
> clarifies that spectrum-config should be set to a full
> configuration.nix file path, not the directory that contains it.
Thanks, got it working with your clarification on #spectrum
My 2 cents for example newer hurts, like adding:
export NIX_PATH=$NIX_PATH:spectrum-config=$(pwd)/path/to/config.nix
Also, outside the scope of this review - changing the default x86 build
to use the build config.nix structure and work as reference would be
nice development and help further board enabled / architecture porting
effort as board-specific configs are preferred out-of-tree.
Best,
-Ville
Reviewed-by: Ville Ilvonen <ville.ilvonen@unikie.com>
> Reported-by: Ville Ilvonen <ville.ilvonen@unikie.com>
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
> Documentation/build-configuration.adoc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/build-configuration.adoc b/Documentation/build-configuration.adoc
> index db68c34..b89575f 100644
> --- a/Documentation/build-configuration.adoc
> +++ b/Documentation/build-configuration.adoc
> @@ -8,8 +8,9 @@
> Some aspects of a Spectrum build can be customised using a build
> configuration file. By default, this configuration file should be
> called config.nix and located in the root of the Spectrum source tree,
> -but this path can be overridden by setting `spectrum-config` in the
> -https://nixos.org/manual/nix/stable/command-ref/env-common.html#env-NIX_PATH[NIX_PATH].
> +but this can be overridden by setting `spectrum-config` in the
> +https://nixos.org/manual/nix/stable/command-ref/env-common.html#env-NIX_PATH[NIX_PATH]
> +to the path of the configuration file.
>
> The configuration file should contain an attribute set. The only
> currently allowed attribute name is `pkgs`, which allows using a
next prev parent reply other threads:[~2022-09-22 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 13:33 Alyssa Ross
2022-09-22 12:33 ` Ville Ilvonen [this message]
2022-09-23 12:16 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa92131f-d6ed-944e-93a0-022abfbac943@unikie.com \
--to=ville.ilvonen@unikie.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).