From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 2A06D6E95A; Thu, 22 Sep 2022 12:33:36 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 2284E6E8C6; Thu, 22 Sep 2022 12:33:33 +0000 (UTC) Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by atuin.qyliss.net (Postfix) with ESMTPS id 5D7416E8C4 for ; Thu, 22 Sep 2022 12:33:29 +0000 (UTC) Received: by mail-lf1-x131.google.com with SMTP id i26so14378557lfp.11 for ; Thu, 22 Sep 2022 05:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=BO/kCuBgOkD8NOnXT0haMYipJAQ6RvojjN544AfROsI=; b=b+xc7tIFJzCdUIZWvFEjCFPEBpbHjyRK/WMaSruMIXjSBlkLmh30Nd2QBjVWAEPPiV I6kGG1wC82BFdwPidcUIo7gut1F/i2dv3AMCRLyFSRwN6eOr4ymaH0Y6tEM3Zdx9w3IZ 2i663p8tGISoszYyP9ssddaTMSPDFHbmeIiPxs5dQKp15jRGzIuQINsod/v8vvihbUej ID3lhBqZlB+4gDz1lJGSjGorWQ7OAdJkajyOMBdw8ZEN4Ws6HWwW9H2/c1g0Bbt/NS7y TXYFMI7Jq2j/aoAAD92NKvpVb5UW1hiHNAJ4s+IAXS5e8FlBQFkIM2JyJznEulXN9vG1 x7mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=BO/kCuBgOkD8NOnXT0haMYipJAQ6RvojjN544AfROsI=; b=U/dpRi4oAnqELnKSD2QgGkbOCj22YISAKIuEhui+1y02qpWN4bdX8ZIzX//hr1n6q7 6T5NT+ro2MkwjNz5jGkes7RS5sn6KHcjXiV+y933HTXKKLf0Rp/BioOR7/y//M6SneL0 bONhbmnsUADcNkfLmcCh4q743tYid4xXicPtihCq2wRpRm7XHLCYzFrCirvEErG2M03e AH7fju0BDa68mG6K92Os+Y4dj/XHnJIA1VeXuXSmVAVYqgMDfDQ1jlrpDByqzGVfg9Az P0AyzJ0Py2D6QytNDe0vWcNSFZV8oeOEEDk54w0KwVxFFcuRfYdRQxHGJV2bkPTw13dG P1ew== X-Gm-Message-State: ACrzQf1swtkHp9IvhhhGuYmqX7cNIHxV9GHY3ua5oOzx0robbmZ1Ue9j XFCxCTfI9q0iiW6Ugo7PdomEQg== X-Google-Smtp-Source: AMsMyM7sxwCOak0ZrAB+i0lMYPQNHLWhI/Lwn8+PqP8P3VvqZtkkS3hu/HhHhX1+kUyXtPwAPHjN7Q== X-Received: by 2002:a05:6512:b8e:b0:497:fef2:80e2 with SMTP id b14-20020a0565120b8e00b00497fef280e2mr1043158lfv.257.1663850008378; Thu, 22 Sep 2022 05:33:28 -0700 (PDT) Received: from [192.168.1.26] (mobile-access-6df023-175.dhcp.inet.fi. [109.240.35.175]) by smtp.gmail.com with ESMTPSA id n22-20020a2e8796000000b00261df847ab0sm896852lji.21.2022.09.22.05.33.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:33:27 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 15:33:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] Documentation: clarify value of spectrum-config Content-Language: en-US To: Alyssa Ross , devel@spectrum-os.org References: <20220921133341.3120867-1-hi@alyssa.is> From: Ville Ilvonen In-Reply-To: <20220921133341.3120867-1-hi@alyssa.is> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Message-ID-Hash: OGLY57LLHSQZS6CU7EOUTU2GUJTHRSON X-Message-ID-Hash: OGLY57LLHSQZS6CU7EOUTU2GUJTHRSON X-MailFrom: ville.ilvonen@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/21/22 16:33, Alyssa Ross wrote: > Before, it was not clear that spectrum-config should be set to a file > path, rather than a directory — i.e. whether it override the root of > the source tree, or the config.nix path within it. This change > clarifies that spectrum-config should be set to a full > configuration.nix file path, not the directory that contains it. Thanks, got it working with your clarification on #spectrum My 2 cents for example newer hurts, like adding: export NIX_PATH=$NIX_PATH:spectrum-config=$(pwd)/path/to/config.nix Also, outside the scope of this review - changing the default x86 build to use the build config.nix structure and work as reference would be nice development and help further board enabled / architecture porting effort as board-specific configs are preferred out-of-tree. Best, -Ville Reviewed-by: Ville Ilvonen > Reported-by: Ville Ilvonen > Signed-off-by: Alyssa Ross > --- > Documentation/build-configuration.adoc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/build-configuration.adoc b/Documentation/build-configuration.adoc > index db68c34..b89575f 100644 > --- a/Documentation/build-configuration.adoc > +++ b/Documentation/build-configuration.adoc > @@ -8,8 +8,9 @@ > Some aspects of a Spectrum build can be customised using a build > configuration file. By default, this configuration file should be > called config.nix and located in the root of the Spectrum source tree, > -but this path can be overridden by setting `spectrum-config` in the > -https://nixos.org/manual/nix/stable/command-ref/env-common.html#env-NIX_PATH[NIX_PATH]. > +but this can be overridden by setting `spectrum-config` in the > +https://nixos.org/manual/nix/stable/command-ref/env-common.html#env-NIX_PATH[NIX_PATH] > +to the path of the configuration file. > > The configuration file should contain an attribute set. The only > currently allowed attribute name is `pkgs`, which allows using a