From: Alyssa Ross <hi@alyssa.is>
To: "Philipp Steinpaß" <philipp@xndr.de>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] Add and clarify matrix workarounds.
Date: Wed, 12 Aug 2020 13:34:08 +0000 [thread overview]
Message-ID: <87wo247zu7.fsf@alyssa.is> (raw)
In-Reply-To: <871rkcalwh.fsf@xndr.de>
Philipp Steinpaß <philipp@xndr.de> writes:
> Thank you for the remarks, they were all very helpfull.
> If you want to include me in the copyright, you are free to use my full
> name. It's in the mail header now.
Cool, so I'll add the following if that's okay:
<!-- SPDX-FileCopyrightText: 2020 Philipp Steinpaß <philipp@xndr.de> -->
> P.S. Please feel free to comment on any potential problems with the
> formatting of these patch mails, if you want to. It's my first time
> using git via mail and I'd like todo it the proper way right away.
Okay! Well, what you've done here has pretty much worked, but there's a
couple of things that were a little unusual:
- When I apply a patch with git am, it expects to find the commit
message at the start of the email. So usually, when you're sending v2
of a patch, you repeat the message from v1, because that's usually
what makes sense to be recorded in the commit log. If you want to
include stuff like you did here, describing what's changed in this
version of the patch, you can include that after the "---" (above the
diffstat), and it won't become part of the commit message.
- Often people indicate which version of a patch they're sending using
the subject, like "[PATCH v2] Add and clarify Matrix workarounds".
Thanks for your patch! I appreciate it -- I know it's not easy getting
up to speed with a new workflow.
next prev parent reply other threads:[~2020-08-12 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 16:32 Philipp
2020-08-11 18:31 ` Alyssa Ross
2020-08-11 21:54 ` Philipp Steinpaß
2020-08-12 13:34 ` Alyssa Ross [this message]
2020-08-15 13:15 ` [PATCH www v2] " Philipp Steinpaß
2020-08-21 18:10 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo247zu7.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=philipp@xndr.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).