patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Philipp <philipp+spectrum@xndr.de>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] Add and clarify matrix workarounds.
Date: Tue, 11 Aug 2020 18:31:45 +0000	[thread overview]
Message-ID: <877du5owz2.fsf@alyssa.is> (raw)
In-Reply-To: <874kp99m8v.fsf@xndr.de>

Philipp <philipp+spectrum@xndr.de> writes:

> I'm a matrix user and fiddled around with the room there a bit. My
> findings were that the room itself seems to be fine, but the pretty
> alias is broken in some way that I don't understand. I came up with two
> ways to join the room via the internal ID and I also took the liberty to
> modify the old workaround a little and made it more precise.
> ---
>  participating.html | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

Thanks for the patch!  This should be very helpful.  I have a couple of
comments, but I'm happy to just fix them up myself if you prefer.

> diff --git a/participating.html b/participating.html
> index 811fcf4..58f2ff3 100644
> --- a/participating.html
> +++ b/participating.html
> @@ -78,13 +78,15 @@ the web.
>  <h3>Note for Matrix users</h3>
>  
>  <p>
> -There appears to be an issue with Matrix's IRC bridge that prevents
> -Matrix users from joining #spectrum.  The workaround is as follows:
> +There appears to be an issue with Matrix's IRC bridged room that prevents
> +Matrix users from joining the channel with the normal alias <q>#freenode_#spectrum:matrix.org</q>.  There are the following workarounds:

Text should be wrapped as it is everywhere else (I wrap at 70 because
it's the default in Emacs but it doesn't have to be exact).

The room name also isn't really a quotation, so probably doesn't really
make sense to be a <q>.  (I think I'd just not mark it up at all.)

> +
> +<ul>
> +  <li>Join the room via it's internal name: <q>/join !ZsIiqZmCTSWHpTQWaw:matrix.org</q>.
> +  <li>Join the room via <a href="https://matrix.to/#/!ZsIiqZmCTSWHpTQWaw:matrix.org">matrix.to link</a>.</li>
> +  <li>Ask the bridges appservice to invite you to the room: <q>/msg @appservice-irc:matrix.org !join #spectrum</q> and accept the invite.</li>

The messages probably make more sense as <kbd> than <q>.
The </li> can also be omitted.

> +</ul>
>  
> -<ol>
> -  <li>Post <q>!join #spectrum</q> in your "Freenode IRC Bridge" chat.</li>
> -  <li>Accept the invitation you are sent.</li>
> -</ol>
>  
>  <p>
>  If you experience this issue, kindly report it to the people who run
> -- 
> 2.28.0

As I said above, I'm happy to just fix up the patch myself and apply it if
you'd prefer.

One more thing -- this probably makes you a (minor) copyright holder in
this file.  Are you happy if I add "SPDX-FileCopyrightText: 2020
Philipp" to the copyright header at the top of the file?  (You can give
me a surname if you want, or not -- up to you.)  And would you prefer
your email address be included in the notice, or not (either is fine)?

  reply	other threads:[~2020-08-11 18:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 16:32 Philipp
2020-08-11 18:31 ` Alyssa Ross [this message]
2020-08-11 21:54   ` Philipp Steinpaß
2020-08-12 13:34     ` Alyssa Ross
2020-08-15 13:15       ` [PATCH www v2] " Philipp Steinpaß
2020-08-21 18:10         ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877du5owz2.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    --cc=philipp+spectrum@xndr.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).