From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH crosvm] crosvm: support setting guest MAC from tap-fd
Date: Wed, 14 Apr 2021 23:46:07 +0000 [thread overview]
Message-ID: <87fszse8g0.fsf@alyssa.is> (raw)
In-Reply-To: <SJ0PR03MB55819B82815D0423DF318A6CB34E9@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
"Cole Helbling" <cole.e.helbling@outlook.com> writes:
> On Fri Apr 9, 2021 at 3:20 PM PDT, Alyssa Ross wrote:
>> This adds a mac= option to crosvm's --tap-fd option. The virtio-net
>> driver in the guest will read the desired MAC from virtio
>> configuration space.
>>
>> See the documentation for VIRTIO_NET_F_MAC in the Virtio spec[1].
>>
>> [1]: https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html
>>
>> ---
>> This will be important for host-based networking in Spectrum.
>>
>> devices/src/virtio/net.rs | 31 ++++++++++++++++---
>> src/crosvm.rs | 8 +++--
>> src/linux.rs | 20 +++++++-----
>> src/main.rs | 64 ++++++++++++++++++++++++++++++---------
>> 4 files changed, 96 insertions(+), 27 deletions(-)
>
> Probably should have reviewed this one first... :P Oh well.
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Thanks, I've added your r-b to the patch file in the inter-guest
networking series.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2021-04-14 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 22:20 Alyssa Ross
2021-04-09 22:26 ` Alyssa Ross
2021-04-14 18:55 ` Cole Helbling
2021-04-14 23:46 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fszse8g0.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).