From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id CF2DDC295; Wed, 14 Apr 2021 23:46:32 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 3EB65C20D; Wed, 14 Apr 2021 23:46:24 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 6948CC208; Wed, 14 Apr 2021 23:46:21 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by atuin.qyliss.net (Postfix) with ESMTPS id 6749AC1BA for ; Wed, 14 Apr 2021 23:46:17 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1CC8312D4; Wed, 14 Apr 2021 19:46:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 14 Apr 2021 19:46:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=KLWcLYlidBLD1d0e4y9rVs7cL+ jP8Q0y9G+lPlEkMiE=; b=O6HvaNoBCOfrWfcOer11Uwy0gEUqYzhAxb3jh9qWtA smZrIprsm8cL766DpLbsBCixowXCRQHiYnn98Asn3myj0kMB5diKYbiNnX29HO2o Wuw7wUphhGGXXs5s1je2X1uffWBUE3foOjg/BKbIJxwzNxzV1c9cLdsGacbxBELQ OBgKLlesVXt+QSmiu9x74vVeGz11aA6mYP/jiWRUcpzCkfLCjUvwEjdZkWep/EiZ HPzuf3ld9WCXce+/Xsl4D32Enpsr8O1gzPMy6omwzX9EPpDUP7MqRcnuhJ6eNT9J J8qe5tmQxkKmh0OBlI21Oq+x8bsuQg3tA/ATx2CjoPSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KLWcLY lidBLD1d0e4y9rVs7cL+jP8Q0y9G+lPlEkMiE=; b=jwGFCAPNZOznPKslsCPMy9 /yEHbpWzYDpjm8bfrEFcVMEcxbDmCG7CKtEXJUqbabXaoRuTHG+hKnRsqXN/bOdK 0B8OM2T7p/pTunfyRNXp26d3mbZhjZfoG1VCLt0FUN0tGXkTt14Bev4gcTNWcj40 xb4F5GM/9Z1j8BEoCmjDI/rkh8ZixR9JqcMaS/s2WJaSoQQ4bDOW154J9S1AYuxZ wXj8oLMsuHtVngMf4jebVDyyAF7pdKSo3HoJlndRcNdh3O/w5XomKruBfZJBckGC yakgijQ3+exDtpEy3vj3X2E7jXWCmx+IuX3r3j3SjtsEwzofCoxpHwugBuQPZVOA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelvddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepkeffke elkeeigeetiedvudfffedvvdffhfekheegkeeiledvveegteevjeffueefnecuffhomhgr ihhnpehorghsihhsqdhophgvnhdrohhrghenucfkphepkeegrddukeegrddvvdeirdekud enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihes rghlhihsshgrrdhish X-ME-Proxy: Received: from x220.qyliss.net (p54b8e251.dip0.t-ipconnect.de [84.184.226.81]) by mail.messagingengine.com (Postfix) with ESMTPA id 7382824005E; Wed, 14 Apr 2021 19:46:13 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 39BDF1EB; Wed, 14 Apr 2021 23:46:12 +0000 (UTC) From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH crosvm] crosvm: support setting guest MAC from tap-fd In-Reply-To: References: Date: Wed, 14 Apr 2021 23:46:07 +0000 Message-ID: <87fszse8g0.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: ZSOSQ6A4WAYZIGEBJDXSOAYJBQQXPTBW X-Message-ID-Hash: ZSOSQ6A4WAYZIGEBJDXSOAYJBQQXPTBW X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain "Cole Helbling" writes: > On Fri Apr 9, 2021 at 3:20 PM PDT, Alyssa Ross wrote: >> This adds a mac= option to crosvm's --tap-fd option. The virtio-net >> driver in the guest will read the desired MAC from virtio >> configuration space. >> >> See the documentation for VIRTIO_NET_F_MAC in the Virtio spec[1]. >> >> [1]: https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html >> >> --- >> This will be important for host-based networking in Spectrum. >> >> devices/src/virtio/net.rs | 31 ++++++++++++++++--- >> src/crosvm.rs | 8 +++-- >> src/linux.rs | 20 +++++++----- >> src/main.rs | 64 ++++++++++++++++++++++++++++++--------- >> 4 files changed, 96 insertions(+), 27 deletions(-) > > Probably should have reviewed this one first... :P Oh well. > > Reviewed-by: Cole Helbling Thanks, I've added your r-b to the patch file in the inter-guest networking series. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmB3fsEACgkQ+dvtSFmy ccAkhQ/+NT/3L8jb+32WXrW62qM2CfCwIQZ9a+utIq1b/fLvK9OiAq11JrNfK3jD SkJyMERt1cOOVSRFX2kZwrMTKLmVMruIHnbgJ1X75aIK4KAjX1F6rmPnoOLH1RiW W8G4Zhj7MTAti1LzB1ZtcLQKzbUw3oMkDFNlwGuIB2MfX6Ty4tnVxFqz+yOzbv+B qmXaF+ljVqm9XKTjgg3MRhAtopVq6DLfFuRh1pUiSs13AzofxXPIrN/6ozMVWNg8 2zqwaJzx2NTe5r/DEWRy9wLy91QhD56N7K9ypQfoBo7sKZmTEyTU52Dc4l95p1yU 4TizMLLcOKIxEvp6zis5X4zRLHCLdaUBaN+VSYzAnPv76fiLBnqmRHphhnzRc5FA C2PyXWmreXQiFMzV66ih2PX2YoWu9aC9wOEYPJ+lpuM3ri1qon3VOhe27I5npbxb x4CQtfc+y7p/eaxdhPq8Di7X2ju6AOKuverF16SYCnt7c0dPUcuU2elnXIKNQNDh /rEKUXI5z/V7SIfgml+Xv8I4Ct24syiT4AHP5a2f/MpNCHFeozioWCMEcUcFhP9N wCAtGfnhjbqe8Vjv61UMXCa3gy0oJ0bJ3gYN8+gtbcARiIBCJW8FY6pacM1vWEGw tKDgfKHSa5nEXoLociHx31zgQmm/nL3JSoUaySaClBKOtX+s1g0= =F9em -----END PGP SIGNATURE----- --=-=-=--