From: Alyssa Ross <hi@alyssa.is>
To: Ville Ilvonen <ville.ilvonen@unikie.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] fix: config support with vms
Date: Tue, 20 Sep 2022 11:42:20 +0000 [thread overview]
Message-ID: <87bkramfvn.fsf@alyssa.is> (raw)
In-Reply-To: <1263b0d5-14f7-9650-7823-70da02f42c5d@unikie.com>
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
Ville Ilvonen <ville.ilvonen@unikie.com> writes:
> On 9/20/22 14:31, Alyssa Ross wrote:
>> Ville Ilvonen <ville.ilvonen@unikie.com> writes:
>>
>>> with config.nix, the build of vms fails with
>>> error: undefined variable 'pkgs'
>>> ..
>>> 49|
>>> 50| kernel = pkgs.linux_latest.override {
>>> | ^
>>>
>>> This fixes the issue for all default vms
>>>
>>> Signed-off-by: Ville Ilvonen <ville.ilvonen@unikie.com>
>>> ---
>>
>> Hi Ville, I was wondering how I'd have missed something like the default
>> VMs not evaluating, but indeed I'm not able to reproduce this. And when
>> I look at the default.nix files for the default VMs, I see:
>>
>> 50 kernel = buildPackages.linux.override {
>>
>> So unless I've missed something, I don't think this issue exists in the
>> current upstream. (I checked commit 3aa2f8a.)
>
> I'm not testing with default but with new config.nix support.
> Have you tested with any config.nix?
I'm not sure I understand what you mean. config.nix support is already
present in the commit I tested.
I created a simple config.nix file that just set "pkgs" to "import <nixpkgs> {}"
in case the presence of the config file made a difference, and ran:
nix-instantiate vm/*/* img/live
To test evaluating VMs both directly and as part of the whole system,
and it worked fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2022-09-20 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 11:09 Ville Ilvonen
2022-09-20 11:31 ` Alyssa Ross
2022-09-20 11:34 ` Ville Ilvonen
2022-09-20 11:42 ` Alyssa Ross [this message]
2022-09-20 11:46 ` Ville Ilvonen
2022-09-20 11:59 ` Alyssa Ross
2022-09-20 12:17 ` Ville Ilvonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkramfvn.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=ville.ilvonen@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).