From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 25986611C4; Tue, 20 Sep 2022 11:42:38 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id B86F46124C; Tue, 20 Sep 2022 11:42:35 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 0BD2C61237 for ; Tue, 20 Sep 2022 11:42:34 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 31DFF5C00AF; Tue, 20 Sep 2022 07:42:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 20 Sep 2022 07:42:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663674153; x=1663760553; bh=XVZn9RtcOC ibnoUj4C8d3OXFZDbQzsvZFnwTl/l4Lfw=; b=P3R9Gd38qbdDFqA+gTSWnoF3l7 6viYGE3WLjDJlK+2NUwmsDkZwi9hHfrdunw6sGLKl9btBe3dRa8wpDz+9ZMu/oNj kZ8c1ivZwSlCOdQo8J/69qD9p8KKRXVM3Gzd3RTBZjWXfyx0Q2IbVTiEOE2Z6iWT GFTEJH15zcWYwPdsE8ce8MCyfDPjjKA0ComRi4ZV7YRfb8f5mE5+nI/LMi52PaUC 2QZe5qZgqvADDFsw96L3PCiIetjs+djSrnkHtY2JoERhsrB/UIxhiFkRUhFSx+iC 8dlltwvBZHB25bl8nGrLv3WGhB9q8tgE/zmKkJJIQyMe6ji8eSDHZWZKvXbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663674153; x=1663760553; bh=XVZn9RtcOCibnoUj4C8d3OXFZDbQ zsvZFnwTl/l4Lfw=; b=M3/k1GoNcS+nIUHTDdSMFu6FRoFIsXX1s8AjVgOnX9q8 Q+K0wgY2FJgQaR1xT+k6bPU3NXk/+j5fha7geki9/DYTZK6yuE1p3h+SB6QSxfbI vu/XcCWZvZlud7ZKaU/909dZr/68nC8NTUs2wbhAnxw00ay1SifPO2SaKgJjNEpI vPeGrO3vxZJf7cS+veSEzGdux3wIY4biyRWXOmos9BG97kssAe5UqzqObpLbSAqH eOPhFU3jN/EjV6TCscu1q+GH3jpH0BG85lrz6nhopgWNE0e+0D/4YrBEn826YMmb 875w7CbOGf9jpF/tc43LTTTlJ6a7kW0YfUzTMWnjTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvledggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiud ffueeilefgtefgtddttdekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihssh grrdhish X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Sep 2022 07:42:32 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 5BA2B985C; Tue, 20 Sep 2022 11:42:31 +0000 (UTC) From: Alyssa Ross To: Ville Ilvonen Subject: Re: [PATCH] fix: config support with vms In-Reply-To: <1263b0d5-14f7-9650-7823-70da02f42c5d@unikie.com> References: <20220920110958.2548848-1-ville.ilvonen@unikie.com> <87fsgmmgdf.fsf@alyssa.is> <1263b0d5-14f7-9650-7823-70da02f42c5d@unikie.com> Date: Tue, 20 Sep 2022 11:42:20 +0000 Message-ID: <87bkramfvn.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: PG7NY74FPT5I4JAEQMRNNM64LRQ3KPQM X-Message-ID-Hash: PG7NY74FPT5I4JAEQMRNNM64LRQ3KPQM X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Ville Ilvonen writes: > On 9/20/22 14:31, Alyssa Ross wrote: >> Ville Ilvonen writes: >>=20 >>> with config.nix, the build of vms fails with >>> error: undefined variable 'pkgs' >>> .. >>> 49| >>> 50| kernel =3D pkgs.linux_latest.override { >>> | ^ >>> >>> This fixes the issue for all default vms >>> >>> Signed-off-by: Ville Ilvonen >>> --- >>=20 >> Hi Ville, I was wondering how I'd have missed something like the default >> VMs not evaluating, but indeed I'm not able to reproduce this. And when >> I look at the default.nix files for the default VMs, I see: >>=20 >> 50 kernel =3D buildPackages.linux.override { >>=20 >> So unless I've missed something, I don't think this issue exists in the >> current upstream. (I checked commit 3aa2f8a.) > > I'm not testing with default but with new config.nix support. > Have you tested with any config.nix? I'm not sure I understand what you mean. config.nix support is already present in the commit I tested. I created a simple config.nix file that just set "pkgs" to "import {}" in case the presence of the config file made a difference, and ran: nix-instantiate vm/*/* img/live To test evaluating VMs both directly and as part of the whole system, and it worked fine. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmMppx0ACgkQ+dvtSFmy ccAjBw/8DLgTWfGIROSD33QNUCnqqIkO5jVkjHvOKT7H4OxTTg8wKrQw1wrrT1Ef WlqQuCP7R7MJHwQ/hz2clIhd2OH/PC9/vtBlHafVl7FiF2r1h8LRH2cQWHutY7Kw lon1P+gvHpKc0c2Stum7pfDX0Iqgk8QY6gq9AB7+KJQ7edVfBYYzITGXtz/IFSES yDGUdP260kM2DZmW5YwhyIqfWIKcfDiW0yP4HDFNF/IyA7bfxhrrj8iHAaUOWb+4 JxEeEfkppfbnmbLoW6arH7N+yAPXWZCFe6xCMnbvaQGqKvNEpmOwAQQo8lfoRcaC ZUn9EexeIpMo99j0i1z1UabG1lF1olGksU1GAdNT+i0dVHLaAynlujvPZgnMKdS+ qUh13DviBMuIsEfALMOHDx+At8G6HkilznfWp2nCkf4aWTh7sTTn7Iopevog3jUo kw0mATMx4QX4zPu/38J6oLl/viRX4keeB7DwmbbsXHofM3I4BeLoFNkz/pK+CoWC 8ZD88HUVs7GCmK3o8oEcsiiI1yyBityzTYzM4RMkGsKDjs9EOZ/3T3w6sapajWKr TA5Mk2DemH9CQkBBkly7V2LhCygMkVqegC+fbbf5CDEeZidVqzCep2iDNuwLeDdN ek5U8yJDgDA0zinOmy8yzLrevDp4b87makD9XBCKyl5aNgjJjB4= =2i+v -----END PGP SIGNATURE----- --=-=-=--