* [PATCH ucspi-vsock] vsockserver: consistently use {STDIN,STDOUT}_FILENO
@ 2021-03-18 0:35 Alyssa Ross
2021-03-18 6:54 ` Cole Helbling
0 siblings, 1 reply; 3+ messages in thread
From: Alyssa Ross @ 2021-03-18 0:35 UTC (permalink / raw)
To: devel
---
vsockserver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vsockserver.c b/vsockserver.c
index 8f809ec..03d9838 100644
--- a/vsockserver.c
+++ b/vsockserver.c
@@ -110,7 +110,7 @@ int main(int argc, char *argv[])
diee(EX_OSERR, "dup2");
if (dup2(conn, STDOUT_FILENO) == -1)
diee(EX_OSERR, "dup2");
- if (conn != 0 && conn != 1)
+ if (conn != STDIN_FILENO && conn != STDOUT_FILENO)
close(conn);
execvp(argv[optind], &argv[optind]);
diee(EX_OSERR, "exec");
--
2.30.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ucspi-vsock] vsockserver: consistently use {STDIN,STDOUT}_FILENO
2021-03-18 0:35 [PATCH ucspi-vsock] vsockserver: consistently use {STDIN,STDOUT}_FILENO Alyssa Ross
@ 2021-03-18 6:54 ` Cole Helbling
2021-03-18 13:11 ` Alyssa Ross
0 siblings, 1 reply; 3+ messages in thread
From: Cole Helbling @ 2021-03-18 6:54 UTC (permalink / raw)
To: Alyssa Ross, devel
On Wed Mar 17, 2021 at 5:35 PM PDT, Alyssa Ross wrote:
> ---
> vsockserver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ucspi-vsock] vsockserver: consistently use {STDIN,STDOUT}_FILENO
2021-03-18 6:54 ` Cole Helbling
@ 2021-03-18 13:11 ` Alyssa Ross
0 siblings, 0 replies; 3+ messages in thread
From: Alyssa Ross @ 2021-03-18 13:11 UTC (permalink / raw)
To: Cole Helbling; +Cc: devel
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
>> ---
>> vsockserver.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Committed as f96c782.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-18 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 0:35 [PATCH ucspi-vsock] vsockserver: consistently use {STDIN,STDOUT}_FILENO Alyssa Ross
2021-03-18 6:54 ` Cole Helbling
2021-03-18 13:11 ` Alyssa Ross
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).