patches and low-level development discussion
 help / color / mirror / code / Atom feed
* [PATCH www] CONTRIBUTING: ask people to add copyright headers
@ 2020-08-11 14:04 Alyssa Ross
  2020-08-12  6:27 ` Cole Helbling
  0 siblings, 1 reply; 3+ messages in thread
From: Alyssa Ross @ 2020-08-11 14:04 UTC (permalink / raw)
  To: devel

I want to make sure we're collecting copyright information right from
the start, because it's much easier to keep track of this as content
is created, rather than try to piece it together after the fact should
we ever need to.
---
 CONTRIBUTING | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/CONTRIBUTING b/CONTRIBUTING
index b2941cf..6cbc106 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -17,6 +17,14 @@ self-close?), and CSS to a minimum.  We want to optimise for the
 website being as nice as possible to navigate in a text editor, to
 encourage people to edit and improve the website.
 
+For any changes that are likely to be copyrightable (i.e. those that
+involve any amount of creative input from you), please add an
+SPDX-FileCopyrightText header to the file so we can keep track of
+copyright holders.  Every file should already have at least one
+example of these that you can use as a template.  If you'd rather not
+list your email address in the copyright notice, it's fine to omit
+that.
+
 Please send patches to devel@spectrum-os.org.  Instructions for how to
 do this are provided in the contributing.html file.
 
-- 
2.27.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH www] CONTRIBUTING: ask people to add copyright headers
  2020-08-11 14:04 [PATCH www] CONTRIBUTING: ask people to add copyright headers Alyssa Ross
@ 2020-08-12  6:27 ` Cole Helbling
  2020-08-12 12:45   ` Alyssa Ross
  0 siblings, 1 reply; 3+ messages in thread
From: Cole Helbling @ 2020-08-12  6:27 UTC (permalink / raw)
  To: Alyssa Ross, devel

On Tue Aug 11, 2020 at 7:04 AM PDT, Alyssa Ross wrote:
> I want to make sure we're collecting copyright information right from
> the start, because it's much easier to keep track of this as content
> is created, rather than try to piece it together after the fact should
> we ever need to.

+1, and it's also nice to see individuals being attributed, rather than
"Spectrum Contributors," as many other projects have turned to (not that
this is any less valid -- it's just nice to see your name called out
somewhere).

> ---
> CONTRIBUTING | 8 ++++++++
> 1 file changed, 8 insertions(+)

Overall SGTM. However, I don't think I'll refer to the contributing
document everytime I post a patch, so I hope you'll gently remind
me/people as they post patches (or offer to do it yourself, as you did
in the recent Matrix instructions patch).

Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH www] CONTRIBUTING: ask people to add copyright headers
  2020-08-12  6:27 ` Cole Helbling
@ 2020-08-12 12:45   ` Alyssa Ross
  0 siblings, 0 replies; 3+ messages in thread
From: Alyssa Ross @ 2020-08-12 12:45 UTC (permalink / raw)
  To: Cole Helbling; +Cc: devel

"Cole Helbling" <cole.e.helbling@outlook.com> writes:

> On Tue Aug 11, 2020 at 7:04 AM PDT, Alyssa Ross wrote:
>> I want to make sure we're collecting copyright information right from
>> the start, because it's much easier to keep track of this as content
>> is created, rather than try to piece it together after the fact should
>> we ever need to.
>
> +1, and it's also nice to see individuals being attributed, rather than
> "Spectrum Contributors," as many other projects have turned to (not that
> this is any less valid -- it's just nice to see your name called out
> somewhere).

IKR!

>> ---
>> CONTRIBUTING | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> Overall SGTM. However, I don't think I'll refer to the contributing
> document everytime I post a patch, so I hope you'll gently remind
> me/people as they post patches (or offer to do it yourself, as you did
> in the recent Matrix instructions patch).

Yeah, of course!  I think in general it's often way easier for a
maintainer to fix up a patch and apply it themselves, and maintainers
should do that more often.

> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>

Thanks for the review.  Applied as
9e1415ed1ad0bc6e1071d988c73dd0fdc8b4e894.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-12 12:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 14:04 [PATCH www] CONTRIBUTING: ask people to add copyright headers Alyssa Ross
2020-08-12  6:27 ` Cole Helbling
2020-08-12 12:45   ` Alyssa Ross

Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).