From: Alyssa Ross <alyssa.ross@unikie.com>
To: Henri Rosten <henri.rosten@unikie.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH v3] Remove bashisms from spectrum shell scripts
Date: Thu, 10 Nov 2022 08:18:02 +0000 [thread overview]
Message-ID: <20221110081802.onz24ajk6mwgsd33@x220> (raw)
In-Reply-To: <20221109132730.941054-1-henri.rosten@unikie.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On Wed, Nov 09, 2022 at 03:27:30PM +0200, Henri Rosten wrote:
> This commit removes bashisms from spectrum shell scripts. This change is
> needed to be able to use the scripts from POSIX-compliant shells which
> are not bash compatible - such as dash.
>
> Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
> ---
> Documentation/scripts/undocumented-uuids.sh | 9 +++++++--
> scripts/format-uuid.sh | 15 ++++++++++++++-
> scripts/make-gpt.sh | 4 +++-
> 3 files changed, 24 insertions(+), 4 deletions(-)
Applied as 8e28cc80b14b613247d953c35dc76ef0b864eb33, thank you!
And thanks for fixing the path in undocumented-uuids.sh.
One small thing for next time: I'd rather fixes like that were part of
their own commit, with their own explanation.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-11-10 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 13:27 Henri Rosten
2022-11-10 8:18 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110081802.onz24ajk6mwgsd33@x220 \
--to=alyssa.ross@unikie.com \
--cc=devel@spectrum-os.org \
--cc=henri.rosten@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).