From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 7C224276A2; Thu, 10 Nov 2022 08:18:11 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id E5E442769C; Thu, 10 Nov 2022 08:18:09 +0000 (UTC) Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by atuin.qyliss.net (Postfix) with ESMTPS id 4722627626 for ; Thu, 10 Nov 2022 08:18:06 +0000 (UTC) Received: by mail-ej1-x644.google.com with SMTP id y14so2992312ejd.9 for ; Thu, 10 Nov 2022 00:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vnn+MV0jXhw3y+xK0g2oCNsOREF8lSr8w9cH1maiTkk=; b=QuGXql2/78wljnrgeX0opMLdaK2w1zt0sMdPDRjdw33SjESKQlcUxi2MpOWntzWtvw kDtRmW461NNQISIJR3iePyRqQKhTh9oWOCWsLXe2JrLMRIV3y1Ou7xos1LNUUqMpYHze nVJA13o5DtjMzAvM7FrIn1iqDePyBO+YGHPuxNjP7bSkrqujT0OpktHij+H1aMzZAJJy m6oRPArhRI7aVXZFZYXtGKnWkoCFStUux9OkHdj/jtFH+0Z1wXmkaha9P+m2y/aOpkQ4 +IcBrvEboGVjOK9Vsi/USxnX9zI68/1b69p00+eggEx5CzR6cQHOPx8hHuyrLZueT/Uv iRQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vnn+MV0jXhw3y+xK0g2oCNsOREF8lSr8w9cH1maiTkk=; b=lZLluRxDXdUcnGe55yEaW1azl99n4qIHhMASYkJ2tth49RdE6uBpOBfRXsxLs2k4oQ yLoIMz9tTNm3hIuCzTGJe1i7I5BdpQv7tegB0jhZ7MEtfAkDaTutYA+EdyUFuPNFYQHK B9u0Xb7iUuE6QNBGQ042Nr+fuvQEGmMPnADpzaK9mo7l+dm3gaNq16RE/hxUBQjJToCE YPhdQS0CxsO/Qr9f5IGKTNcodxtiv3UCSMYDjVkWEomC0kdBnayymokD9Il+gmygdzev VXtR8J4IB2cHTD95ChQP8m83Scvy2TyxUc3VRaumfU7di6cMyEi6GlfmGPV9nutWhCVo pA9g== X-Gm-Message-State: ACrzQf2L9aXqyTiDlMBenIZ7DIsBi1WW241w+i4NyzFjum5NQLVHHNkj hrThrBAfcOuYA0TxkZyCMqNbjudf2IuSUxsV X-Google-Smtp-Source: AMsMyM5gok0Ah0i0z2oj2gbZLteIbsaZ+8i/RM3EEZl9x8hIzckEn/lMzEF3JK2sxU41ZyGpynI6Sw== X-Received: by 2002:a17:906:7cc8:b0:7ad:d051:538f with SMTP id h8-20020a1709067cc800b007add051538fmr2445856ejp.401.1668068285664; Thu, 10 Nov 2022 00:18:05 -0800 (PST) Received: from x220.qyliss.net (p200300ed671d2d010000000000000001.dip0.t-ipconnect.de. [2003:ed:671d:2d01::1]) by smtp.gmail.com with ESMTPSA id f1-20020a05640214c100b00461816beef9sm8169336edx.14.2022.11.10.00.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 00:18:04 -0800 (PST) Received: by x220.qyliss.net (Postfix, from userid 1000) id D0440BDF; Thu, 10 Nov 2022 08:18:02 +0000 (UTC) Date: Thu, 10 Nov 2022 08:18:02 +0000 From: Alyssa Ross To: Henri Rosten Subject: Re: [PATCH v3] Remove bashisms from spectrum shell scripts Message-ID: <20221110081802.onz24ajk6mwgsd33@x220> References: <20221109132730.941054-1-henri.rosten@unikie.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nvanttzr5vsc5rvv" Content-Disposition: inline In-Reply-To: <20221109132730.941054-1-henri.rosten@unikie.com> Message-ID-Hash: 72RRASR2QABLZSHSWKMNK6D3JKF5OR3I X-Message-ID-Hash: 72RRASR2QABLZSHSWKMNK6D3JKF5OR3I X-MailFrom: alyssa.ross@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --nvanttzr5vsc5rvv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 09, 2022 at 03:27:30PM +0200, Henri Rosten wrote: > This commit removes bashisms from spectrum shell scripts. This change is > needed to be able to use the scripts from POSIX-compliant shells which > are not bash compatible - such as dash. > > Signed-off-by: Henri Rosten > --- > Documentation/scripts/undocumented-uuids.sh | 9 +++++++-- > scripts/format-uuid.sh | 15 ++++++++++++++- > scripts/make-gpt.sh | 4 +++- > 3 files changed, 24 insertions(+), 4 deletions(-) Applied as 8e28cc80b14b613247d953c35dc76ef0b864eb33, thank you! And thanks for fixing the path in undocumented-uuids.sh. One small thing for next time: I'd rather fixes like that were part of their own commit, with their own explanation. --nvanttzr5vsc5rvv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmNss6sACgkQ+dvtSFmy ccAozw//Rz0QksOrI3Bnc6/yAr24H9MfqdcBw6Qw3FMeZ4uyaJ0riP9Oif+FhJG5 x+w5H7KOSNigW1u0ydn5vrORJSWkdbpX6fPN0OOuTweDEs/z+wu7mYEUf4cGeba+ wtlNJFvk0fqt884r4/yOax2iwmE06BeswdtduNJTwaiTzz7IhaC+XAothfZPQcl4 gA9bzM522aJVeO3ZQKBd8h9oxGXYNOKDuib4QkANvOcv4h9Gqxgy5BKz69qCMeHr KtkybtBW+zlTnox5Z5Cm/ENNArDfEvCuHSiOpEqYZRjtO1BihvRhfZ8AJCcThTCo DXFfM9LaqfdrOiuwUqGtClejez/Wo1VElLvTY0Moo7c+XoDWsJ07wYLpbpn800pQ JlHuwliDudwh8O6xfBPv2PFIXHmO2P7GnKvt0X5b1qIG1NpbTHPkqqrRoRprS5MD vOMwS+v09h6lgVpbrbCtFO0HCgLVZLuuzcJBzF1qtZZc8WmMddRoUeKZOuCNUXxw 3uZMI9bVgQ5VNPOJUU1NJgC7FzL4HeEbicrRzsnJQplLInDs1kd12JzqWobbHAvl w1NxyUr0YWc5acUXghzqCUaYNwkUVTmLL1s665DMefCInUjsV5KoxYnXOtcNdz15 j/dUGKMqfZOOn69VOv4nlTmSk8jC/ssSpqccUqwvEAcEYrkciqY= =RS8u -----END PGP SIGNATURE----- --nvanttzr5vsc5rvv--