From: Alyssa Ross <hi@alyssa.is>
To: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] Fix valgrind build with Musl
Date: Wed, 18 May 2022 13:43:09 +0000 [thread overview]
Message-ID: <20220518134309.xnu67leikaiwjodb@eve> (raw)
In-Reply-To: <20220518121924.3806023-1-ivan.nikolaenko@unikie.com>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On Wed, May 18, 2022 at 03:19:24PM +0300, Ivan Nikolaenko wrote:
> Musl does not support __THROW macro, so need to define
> this empty.
>
> Signed-off-by: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
Thanks for the patch!
Would you mind submitting it to upstream Nixpkgs? [1] It's a small
change, so shouldn't be difficult to get upstream. (I can probably just
merge it myself.) Once it's accepted upstream, we can cherry-pick it
into Spectrum's nixpkgs, or update Spectrum's nixpkgs to a version that
includes the fix. This way, we minimize how much Spectrum's nixpkgs is
diverged from upstream. If it ends up being more difficult to upstream
than I expect (e.g. if somebody objects for some reason), then I'll
happily just commit it to Spectrum nixpkgs.
When you open the Nixpkgs PR, please CC me. My GitHub username is
@alyssais. Nixpkgs is quite picky about commit message format, so make
sure to look at the examples in the documentation linked below.
[1]: https://nixos.org/manual/nixpkgs/unstable/#chap-submitting-changes
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-05-18 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 12:19 Ivan Nikolaenko
2022-05-18 13:43 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518134309.xnu67leikaiwjodb@eve \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=ivan.nikolaenko@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).