From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 7474E229BC; Wed, 18 May 2022 13:43:20 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 7A370229B7; Wed, 18 May 2022 13:43:17 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by atuin.qyliss.net (Postfix) with ESMTPS id 835352294C for ; Wed, 18 May 2022 13:43:14 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9B2E95C00D0; Wed, 18 May 2022 09:43:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 18 May 2022 09:43:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1652881393; x=1652967793; bh=3TL3vTx4W5 jmAOIK4UAtBwRg/OWp8UcfX7r+bwHzZBc=; b=MWjiK/rMAOJku1dOHyUC7DCVQ7 SaNlkNyTedbS2WvvF5gMU5KC9NYF4GRLjLNWiawL2dE0L8ODqXfmbCrLHAXuDMPc it6kNIXNIa/CfmtHqNvRXvLjS4J6Gz1wzxeTlHpoEcLHe8opuMM2aYl9DhEekw9C w9LxdFn1qS2QmystWkWmqu1/0MIj1WvH343rc3yTlMlKkCMJlcmS+nrIhVeFzsph OV3dtohQg98R+pbuMkg2Tj27esi1xhSo6ylJytfS7/SWaDBhY16MPkhJe7PKbsij fln1oIfYeRX67jXec4uSn9TTX9LlLD3xpuj9WIBIszDlorP6nI2Swoyr4HEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652881393; x=1652967793; bh=3TL3vTx4W5jmAOIK4UAtBwRg/OWp 8UcfX7r+bwHzZBc=; b=ZWg1Vr272+koQlBVgvmEseLt+5TQj+PED6nrJr0Eug75 x+mZlrrD6yYOinWc4YrJSziPwRMhZbyIDEwXKUNfbzIqRmp/PDawW8mCODwL3u/R BxRhOYGXoSkVbMX9NlNq4rY3aLZ1qCumpc8sSL8zB2FwVsvspZjbDWR7k5d1da0J gW8+qTFetrJvxi741u0cxkTjBDxSZuXVfPEW44RSVDAgPRi6U1vuTvrU5GiHhtoq bLh4DFDcOKOMA9oWLLhDhUDx7r5/1zclK37tP77Rb3mNcPI6q6Fh5PXkXXl2XxN1 GVOGRAEkOUcBnhbSLuRbCWfN96SwWrHIa5HdL0pHPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheelgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeejie fftdegvdevgfeuhfeujeehudejveeikeehvedufffhgeeffefhueetteevvdenucffohhm rghinhepnhhigihoshdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehqhihlihhsshesvghvvgdrqhihlhhishhsrdhnvght X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 May 2022 09:43:11 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id ACD11348; Wed, 18 May 2022 13:43:09 +0000 (UTC) Date: Wed, 18 May 2022 13:43:09 +0000 From: Alyssa Ross To: Ivan Nikolaenko Subject: Re: [PATCH] Fix valgrind build with Musl Message-ID: <20220518134309.xnu67leikaiwjodb@eve> References: <20220518121924.3806023-1-ivan.nikolaenko@unikie.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wlyc25dfgsiawu2g" Content-Disposition: inline In-Reply-To: <20220518121924.3806023-1-ivan.nikolaenko@unikie.com> Message-ID-Hash: II5D4YQHOMORW2D6IDASEXSPR72YE6ZI X-Message-ID-Hash: II5D4YQHOMORW2D6IDASEXSPR72YE6ZI X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --wlyc25dfgsiawu2g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 18, 2022 at 03:19:24PM +0300, Ivan Nikolaenko wrote: > Musl does not support __THROW macro, so need to define > this empty. > > Signed-off-by: Ivan Nikolaenko Thanks for the patch! Would you mind submitting it to upstream Nixpkgs? [1] It's a small change, so shouldn't be difficult to get upstream. (I can probably just merge it myself.) Once it's accepted upstream, we can cherry-pick it into Spectrum's nixpkgs, or update Spectrum's nixpkgs to a version that includes the fix. This way, we minimize how much Spectrum's nixpkgs is diverged from upstream. If it ends up being more difficult to upstream than I expect (e.g. if somebody objects for some reason), then I'll happily just commit it to Spectrum nixpkgs. When you open the Nixpkgs PR, please CC me. My GitHub username is @alyssais. Nixpkgs is quite picky about commit message format, so make sure to look at the examples in the documentation linked below. [1]: https://nixos.org/manual/nixpkgs/unstable/#chap-submitting-changes --wlyc25dfgsiawu2g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmKE9+YACgkQ+dvtSFmy ccDLmQ//Z/9UITmOdHmjLe8oImJlwABlR/p+ZNFNYtBPN3vSt4L69tHhXtdm5TWK ckKKZOPm91CZcqf0siMyip2N+RbDahJ026vwq5ZEn6rl/x8gip8OkUztkF0Zfp/P HGFXK/QLgKJCf6c+YZq0CoehhL2xsXe6BhGosqFKY/2eakzFGEjh9mhgAap+qv6Y 75edCCwucVbC4TnCGsmNKblwwhMwmOpofR0SoVPvSRFFN8N1fvcYFf3gA3s2k9vy s0HUjQLOqTyeKZPPj3M8mV0Yl3mINOhpoPGvf50ojhetDwLp8uaazNp9zXsaBTOg 0h+Z0DZ7Mj+LS3zwKIQm0Z71JzQcUbftcSjEIoECakR3QO0vowwneqINYmjTHhH+ 5/jPeztVzW4jUHXTe0G9Bw5kNvFfBq60/eB0ZK9k8GIyyQcXp0ob1ZBh+bOptq6L N25itOK8OgFe7qg7MKNrBNx63XtejCgU6sAvX0XEtVLxmJCEc4gFs1K50LjYlea2 JKJHggSf2Dx5SYNbuOULiAsXOoqxYZz8b7qJ0TlZzDNu0hqgoiZTtrsAfwXKPXWK rxwo2CM0b2OcsHHDYau6azKO4wczCMJku3Rfw6exyfbirXw/6SzVba1mNFTkAxh7 7xfsCFr18e756cKQC4CNWP7SDg0YbOEK7QpsEVBW8ZlSBs/HvUw= =dRLo -----END PGP SIGNATURE----- --wlyc25dfgsiawu2g--