* [PATCH ucspi-vsock] num: rename from util
@ 2021-03-18 0:35 Alyssa Ross
2021-03-18 6:56 ` Cole Helbling
0 siblings, 1 reply; 3+ messages in thread
From: Alyssa Ross @ 2021-03-18 0:35 UTC (permalink / raw)
To: devel
I don't want to have anything called "util", because that will
inevitably become a dumping ground for all sorts of unrelated stuff.
---
Makefile | 14 +++++++-------
util.c => num.c | 2 +-
util.h => num.h | 0
vsockclient.c | 2 +-
vsockserver.c | 2 +-
5 files changed, 10 insertions(+), 10 deletions(-)
rename util.c => num.c (97%)
rename util.h => num.h (100%)
diff --git a/Makefile b/Makefile
index 07ff09b..1a4bb10 100644
--- a/Makefile
+++ b/Makefile
@@ -18,15 +18,15 @@ install: vsockclient vsockserver
$(INSTALL_PROGRAM) vsockclient vsockserver $(DESTDIR)$(bindir)
.PHONY: install
-vsockclient: vsockclient.o env.o log.o util.o vsock.o
- $(CC) $(LDFLAGS) -o vsockclient vsockclient.o env.o log.o util.o vsock.o $(LDLIBS)
-vsockserver: vsockserver.o env.o log.o util.o vsock.o
- $(CC) $(LDFLAGS) -o vsockserver vsockserver.o env.o log.o util.o vsock.o $(LDLIBS)
+vsockclient: vsockclient.o env.o log.o num.o vsock.o
+ $(CC) $(LDFLAGS) -o vsockclient vsockclient.o env.o log.o num.o vsock.o $(LDLIBS)
+vsockserver: vsockserver.o env.o log.o num.o vsock.o
+ $(CC) $(LDFLAGS) -o vsockserver vsockserver.o env.o log.o num.o vsock.o $(LDLIBS)
-vsockclient.o: env.h log.h util.h vsock.h
-vsockserver.o: env.h log.h util.h vsock.h
+vsockclient.o: env.h log.h num.h vsock.h
+vsockserver.o: env.h log.h num.h vsock.h
clean:
- rm -f env.o log.o util.o vsock.o \
+ rm -f env.o log.o num.o vsock.o \
vsockclient.o vsockclient vsockserver.o vsockserver
.PHONY: clean
diff --git a/util.c b/num.c
similarity index 97%
rename from util.c
rename to num.c
index 2b39df1..ac7f0a4 100644
--- a/util.c
+++ b/num.c
@@ -3,7 +3,7 @@
#define _GNU_SOURCE
-#include "util.h"
+#include "num.h"
#include <ctype.h>
#include <stdlib.h>
diff --git a/util.h b/num.h
similarity index 100%
rename from util.h
rename to num.h
diff --git a/vsockclient.c b/vsockclient.c
index d25ab13..fbdd20e 100644
--- a/vsockclient.c
+++ b/vsockclient.c
@@ -16,7 +16,7 @@
#include "env.h"
#include "log.h"
-#include "util.h"
+#include "num.h"
#include "vsock.h"
noreturn static void ex_usage(void)
diff --git a/vsockserver.c b/vsockserver.c
index 4c251b0..df9d334 100644
--- a/vsockserver.c
+++ b/vsockserver.c
@@ -19,7 +19,7 @@
#include "env.h"
#include "log.h"
-#include "util.h"
+#include "num.h"
#include "vsock.h"
noreturn static void ex_usage(void)
--
2.30.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ucspi-vsock] num: rename from util
2021-03-18 0:35 [PATCH ucspi-vsock] num: rename from util Alyssa Ross
@ 2021-03-18 6:56 ` Cole Helbling
2021-03-18 13:13 ` Alyssa Ross
0 siblings, 1 reply; 3+ messages in thread
From: Cole Helbling @ 2021-03-18 6:56 UTC (permalink / raw)
To: Alyssa Ross, devel
On Wed Mar 17, 2021 at 5:35 PM PDT, Alyssa Ross wrote:
> I don't want to have anything called "util", because that will
> inevitably become a dumping ground for all sorts of unrelated stuff.
> ---
> Makefile | 14 +++++++-------
> util.c => num.c | 2 +-
> util.h => num.h | 0
> vsockclient.c | 2 +-
> vsockserver.c | 2 +-
> 5 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ucspi-vsock] num: rename from util
2021-03-18 6:56 ` Cole Helbling
@ 2021-03-18 13:13 ` Alyssa Ross
0 siblings, 0 replies; 3+ messages in thread
From: Alyssa Ross @ 2021-03-18 13:13 UTC (permalink / raw)
To: Cole Helbling; +Cc: devel
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
>> I don't want to have anything called "util", because that will
>> inevitably become a dumping ground for all sorts of unrelated stuff.
>> ---
>> Makefile | 14 +++++++-------
>> util.c => num.c | 2 +-
>> util.h => num.h | 0
>> vsockclient.c | 2 +-
>> vsockserver.c | 2 +-
>> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Committed as c5d9bfe.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-18 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 0:35 [PATCH ucspi-vsock] num: rename from util Alyssa Ross
2021-03-18 6:56 ` Cole Helbling
2021-03-18 13:13 ` Alyssa Ross
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).