From: "Cole Helbling" <cole.e.helbling@outlook.com>
To: "Alyssa Ross" <hi@alyssa.is>, <devel@spectrum-os.org>
Cc: Alyssa Ross <hi@alyssa.is>, impaqt <impaqt@vendek.net>,
Cole@atuin.qyliss.net
Subject: Re: [PATCH doc v2] Document crosvm memfd server
Date: Fri, 29 May 2020 11:49:25 -0700 [thread overview]
Message-ID: <CH2PR14MB3579D91942F9FE12F9A2EA62B38F0@CH2PR14MB3579.namprd14.prod.outlook.com> (raw)
In-Reply-To: <20200527232709.22211-1-hi@alyssa.is>
On Wed May 27, 2020 at 11:27 PM, Alyssa Ross wrote:
> ---
> Thanks for the comments. Should be addressed now.
>
> Please take a(nother) look. If you think it looks good, I'd
> appreciate a Reviewed-by tag from you. :)
>
> (Last bit is just something nice for me to put in the git log,
> e.g. Reviewed-by: Alyssa Ross <hi@alyssa.is>, and means that you had a
> look and don't see anything wrong with the changes. By convention
> those should be sent by the reviewer rather than just made up by
> me. :))
>
> developer-manual.adoc | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
LGTM. Sorry for the late response!
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
next prev parent reply other threads:[~2020-05-29 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:37 [PATCH doc] " Alyssa Ross
2020-05-27 0:13 ` impaqt
2020-05-27 23:27 ` [PATCH doc v2] " Alyssa Ross
2020-05-28 0:40 ` impaqt
2020-05-29 18:12 ` Alyssa Ross
2020-05-29 18:49 ` Cole Helbling [this message]
2020-05-29 18:59 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR14MB3579D91942F9FE12F9A2EA62B38F0@CH2PR14MB3579.namprd14.prod.outlook.com \
--to=cole.e.helbling@outlook.com \
--cc=Cole@atuin.qyliss.net \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
--cc=impaqt@vendek.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).