From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH ucspi-vsock] vsockclient: allow null application
Date: Wed, 24 Mar 2021 19:52:24 +0000 [thread overview]
Message-ID: <87r1k4xrbb.fsf@alyssa.is> (raw)
In-Reply-To: <SJ0PR03MB5581B87C3CB542C110E75C49B3639@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
> On Wed Mar 24, 2021 at 11:24 AM PDT, Alyssa Ross wrote:
>> I found myself running
>>
>> vsockclient 2 1024 true
>>
>> in a situation where it just mattered that a connection was made, and
>> no data needed to be exchanged of it. That I found myself doing this
>> is quite a strong indicator that the program to exec into should be
>> optional.
>>
>> UCSPI-1996[1] doesn't specify what should happen if no application is
>> provided, so I think this is a reasonable interpretation. I'm not
>> sure if I feel the same for vsockserver(d), so I haven't made the
>> corresponding change there. I'll wait to see if there's ever a need
>> for it.
>>
>> [1]: https://cr.yp.to/proto/ucspi.txt
>> ---
>> vsockclient.c | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Committed as d24ff2d. :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-03-24 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 18:24 Alyssa Ross
2021-03-24 18:44 ` Cole Helbling
2021-03-24 19:52 ` Alyssa Ross [this message]
2021-03-24 19:53 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1k4xrbb.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).