From: Alyssa Ross <alyssa.ross@unikie.com>
To: Henri Rosten <henri.rosten@unikie.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH 2/2] nix/checks.nix: shellcheck more files
Date: Wed, 16 Nov 2022 10:40:11 +0000 [thread overview]
Message-ID: <20221116104011.gnavjqmr7jws2q7z@x220> (raw)
In-Reply-To: <20221116085618.GA1412553@buamix>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Wed, Nov 16, 2022 at 10:56:18AM +0200, Henri Rosten wrote:
> On Tue, Nov 15, 2022 at 10:56:37AM +0000, Alyssa Ross wrote:
> > I didn't realise that bash's ** feature (which matches any depth of
> > directories) wasn't enabled by default, because it appeared to work,
> > just didn't find all scripts.
>
> I'm getting shellcheck warnings from
> host/rootfs/build/etc/mdev/modalias.sh. Did you intentionally include
> scripts under 'build' too, or should those be excluded?
They should indeed be excluded. Thanks for catching!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-11-16 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 10:56 [PATCH 1/2] Documentation/scripts: fix shellcheck issues Alyssa Ross
2022-11-15 10:56 ` [PATCH 2/2] nix/checks.nix: shellcheck more files Alyssa Ross
2022-11-16 8:56 ` Henri Rosten
2022-11-16 10:40 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116104011.gnavjqmr7jws2q7z@x220 \
--to=alyssa.ross@unikie.com \
--cc=devel@spectrum-os.org \
--cc=henri.rosten@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).