From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH ucspi-vsock] Set up clang-format
Date: Mon, 22 Mar 2021 12:16:23 +0000 [thread overview]
Message-ID: <20210322121623.y6wpj4m5dcpieybf@eve.qyliss.net> (raw)
In-Reply-To: <SJ0PR03MB55815CF5307A786A5E07F0C3B3659@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Sun, Mar 21, 2021 at 05:15:19PM -0700, Cole Helbling wrote:
> On Sun Mar 21, 2021 at 12:39 PM PDT, Alyssa Ross wrote:
> > ---
> > I'm not entirely happy with the automatic formatting, but I think it's
> > worth it.
> >
> > .clang-format | 10 ++++++++++
> > num.c | 2 +-
> > vsock.c | 4 ++--
> > vsockclient.c | 5 +++--
> > vsockserver-socketbinder.c | 8 ++++----
> > vsockserver.c | 27 +++++++++++++++------------
> > vsockserverd.c | 9 +++++----
> > 7 files changed, 40 insertions(+), 25 deletions(-)
> > create mode 100644 .clang-format
>
> I wish every C / C++ repo used (something like) this, so I wouldn't have
> to guess on the code style. Major +1.
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Committed as d9e8ea9. :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-03-22 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 19:39 Alyssa Ross
2021-03-22 0:15 ` Cole Helbling
2021-03-22 12:16 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322121623.y6wpj4m5dcpieybf@eve.qyliss.net \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).