From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: Cole Helbling <cole.e.helbling@outlook.com>
Subject: [PATCH ucspi-vsock 1/2] exec: free argv if exec fails
Date: Sun, 21 Mar 2021 14:51:17 +0000 [thread overview]
Message-ID: <20210321145118.27783-1-hi@alyssa.is> (raw)
In-Reply-To: <20210321144700.24024-1-hi@alyssa.is>
Identified by clang-tidy:
exec.c:21:2: warning: Potential leak of memory pointed to by 'argv' [clang-analyzer-unix.Malloc]
return execvp(file, argv);
^
exec.c:15:16: note: Memory is allocated
char **argv = calloc(argz_count(argz, len) + 1, sizeof(char *));
^
exec.c:16:6: note: Assuming 'argv' is non-null
if (!argv)
^
exec.c:16:2: note: Taking false branch
if (!argv)
^
exec.c:21:2: note: Potential leak of memory pointed to by 'argv'
return execvp(file, argv);
---
I'm not used to thinking about allocations around exec, since usually
if it fails the program just terminates. But in a function like this,
the rules are a bit different.
exec.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index cc55200..75b1980 100644
--- a/exec.c
+++ b/exec.c
@@ -18,5 +18,8 @@ int execzp(const char *file, const char *argz, size_t len)
argz_extract(argz, len, argv);
- return execvp(file, argv);
+ execvp(file, argv);
+
+ free(argv);
+ return -1;
}
--
2.30.0
next prev parent reply other threads:[~2021-03-21 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 14:46 [PATCH ucspi-vsock 0/2] Fix clang-tidy warnings Alyssa Ross
2021-03-21 14:51 ` Alyssa Ross [this message]
2021-03-21 14:54 ` [PATCH ucspi-vsock 2/2] vsockserver: fix uninitialized variable Alyssa Ross
2021-03-21 16:30 ` [PATCH ucspi-vsock 0/2] Fix clang-tidy warnings Cole Helbling
2021-03-21 19:37 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210321145118.27783-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).