From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: [PATCH ucspi-vsock] Makefile: stop repeating program list
Date: Thu, 18 Mar 2021 00:36:04 +0000 [thread overview]
Message-ID: <20210318003604.13621-1-hi@alyssa.is> (raw)
Using a wildcard with rm -f means that if there are no object files to
remove, rm will try to remove a non-existent file named '*.c', and
then ignore the failure it gets by trying to do that. Which is fine.
---
Makefile | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index 1a4bb10..2045cdd 100644
--- a/Makefile
+++ b/Makefile
@@ -10,12 +10,14 @@ INSTALL_PROGRAM = $(INSTALL)
prefix = /usr/local
bindir = $(prefix)/bin
-all: vsockclient vsockserver
+PROGRAMS = vsockclient vsockserver
+
+all: $(PROGRAMS)
.PHONY: all
-install: vsockclient vsockserver
+install: $(PROGRAMS)
mkdir -p $(DESTDIR)$(bindir)
- $(INSTALL_PROGRAM) vsockclient vsockserver $(DESTDIR)$(bindir)
+ $(INSTALL_PROGRAM) $(PROGRAMS) $(DESTDIR)$(bindir)
.PHONY: install
vsockclient: vsockclient.o env.o log.o num.o vsock.o
@@ -27,6 +29,5 @@ vsockclient.o: env.h log.h num.h vsock.h
vsockserver.o: env.h log.h num.h vsock.h
clean:
- rm -f env.o log.o num.o vsock.o \
- vsockclient.o vsockclient vsockserver.o vsockserver
+ rm -f $(PROGRAMS) *.o
.PHONY: clean
--
2.30.0
next reply other threads:[~2021-03-18 0:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 0:36 Alyssa Ross [this message]
2021-03-18 6:57 ` Cole Helbling
2021-03-18 12:57 ` Alyssa Ross
2021-03-18 16:30 ` Cole Helbling
2021-03-18 19:06 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318003604.13621-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).