From: Thomas Leonard <talex5@gmail.com>
To: Alyssa Ross <hi@alyssa.is>
Cc: Jamie McClymont <jamie@kwiius.com>,
devel@spectrum-os.org, Puck Meerburg <puck@puckipedia.com>
Subject: Re: [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches
Date: Fri, 2 Apr 2021 17:18:38 +0000 [thread overview]
Message-ID: <CAG4opy_km0iO0rFy-P+bBdYx6NfsapZbU3gO_vWbMg+G-6p_Mw@mail.gmail.com> (raw)
In-Reply-To: <87wntkwq7z.fsf@alyssa.is>
On Fri, 2 Apr 2021 at 17:28, Alyssa Ross <hi@alyssa.is> wrote:
>
> >> The xdg-shell thing has been integrated upstream, and the demos seem to
> >> no longer exist.
>
> Actually, is this true? Looking through the sommelier git log[1] I see
> 32050c0ea6c00c16999915856b40a6a6b8b41bb9:
>
> > Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell"
> >
> > This reverts commit be4e16feb380360cabbb5d6199a09592ecaf4a42.
> >
> > Reason for revert: Breaks the version of gtk3 shipped with stretch
>
> [1]: https://chromium.googlesource.com/chromiumos/platform2/+log/refs/heads/main/vm_tools/sommelier
>
> The relevant Chromium bugs[2][3] are:
>
> Issue 1022716: Sommelier does not support the stable xdg-shell
> Issue 1120277: GTK3 broken on stretch in M86
>
> [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1022716
> [3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1120277
>
> It doesn't look like it's been reintroduced since, and there's no
> further activity on the bug, so I think current Sommelier doesn't
> support stable xdg-shell after all.
>
> From what I can tell, they backed out stable xdg-shell because their
> Debian version is too old to support it. So we probably still need this
> patch. It doesn't still apply cleanly, though. It would probably be
> better to just revert their revert than to keep carrying around Puck's
> version so that we're closer to upstream while still supporting stable
> xdg-shell.
>
> Also CCing Thomas, with whom I've previously talked about stable
> xdg-shell in Sommelier, in case he hasn't seen that it was reverted
> upstream.
Yes, I initially reapplied the sommelier patch switching to the stable
xdg-shell version (I had to update it slightly due to the C++ switch).
But I've since replaced sommelier with
https://github.com/talex5/wayland-virtwl-proxy/, which uses the stable
xdg-shell version anyway.
--
talex5 (GitHub/Twitter) http://roscidus.com/blog/
GPG: 5DD5 8D70 899C 454A 966D 6A51 7513 3C8F 94F6 E0CC
next prev parent reply other threads:[~2021-04-02 18:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210402090042.2020627-1-jamie@kwiius.com>
2021-04-02 9:04 ` [RFC PATCH 1/8] chromiumOSPackages: update 83->89 Jamie McClymont
2021-04-02 14:58 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 2/8] chromiumOSPackages.cros_linux: fix config Jamie McClymont
2021-04-02 15:35 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 4/8] chromiumOSPackages.common-mk: update patches Jamie McClymont
2021-04-02 15:47 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 3/8] chromiumOSPackages.vm_protos: drop GN patch Jamie McClymont
2021-04-02 15:53 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings Jamie McClymont
2021-04-02 15:54 ` Alyssa Ross
2021-04-02 9:04 ` [RFC PATCH 7/8] chromiumOSPackages.crosvm: add platform2 dep Jamie McClymont
2021-04-02 9:04 ` [RFC PATCH 8/8] chromiumOSPackages.crosvm: bump cargoSha256 Jamie McClymont
2021-04-02 9:04 ` [RFC PATCH 6/8] chromiumOSPackages.sommelier: drop unneeded patches Jamie McClymont
2021-04-02 16:11 ` Alyssa Ross
2021-04-02 17:28 ` Alyssa Ross
2021-04-02 17:18 ` Thomas Leonard [this message]
2021-04-02 21:00 ` [PATCH platform2] Revert "Revert "vm_tools: sommelier: Switch to the stable version of xdg-shell"" Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG4opy_km0iO0rFy-P+bBdYx6NfsapZbU3gO_vWbMg+G-6p_Mw@mail.gmail.com \
--to=talex5@gmail.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
--cc=jamie@kwiius.com \
--cc=puck@puckipedia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).