diff options
| author | Robert Hensing <robert@roberthensing.nl> | 2021-11-03 18:16:41 +0100 |
|---|---|---|
| committer | Robert Hensing <robert@roberthensing.nl> | 2021-11-03 18:16:41 +0100 |
| commit | c7043de51d0fa7f450f7cf4793c57600dc0e153d (patch) | |
| tree | f744365e09b5dbdab8de23745a3a5862dd51e5f2 /.github | |
| parent | 883051e1a18988bd2f3c0392072c769d600c7a96 (diff) | |
| download | nixpkgs-c7043de51d0fa7f450f7cf4793c57600dc0e153d.tar nixpkgs-c7043de51d0fa7f450f7cf4793c57600dc0e153d.tar.gz nixpkgs-c7043de51d0fa7f450f7cf4793c57600dc0e153d.tar.bz2 nixpkgs-c7043de51d0fa7f450f7cf4793c57600dc0e153d.tar.lz nixpkgs-c7043de51d0fa7f450f7cf4793c57600dc0e153d.tar.xz nixpkgs-c7043de51d0fa7f450f7cf4793c57600dc0e153d.tar.zst nixpkgs-c7043de51d0fa7f450f7cf4793c57600dc0e153d.zip | |
PULL_REQUEST_TEMPLATE.md: ticks to bullets
As suggested by 06kellyjac.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5bbb2700aec..168d40f16a9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -22,10 +22,10 @@ Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing- - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested, as applicable: - - [ ] [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - - [ ] and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - - [ ] or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - - [ ] made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages + - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) + - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) + - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) + - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) |