diff options
| author | Robert Hensing <robert@roberthensing.nl> | 2021-11-01 00:15:21 +0100 |
|---|---|---|
| committer | Robert Hensing <robert@roberthensing.nl> | 2021-11-01 00:15:21 +0100 |
| commit | 883051e1a18988bd2f3c0392072c769d600c7a96 (patch) | |
| tree | 82fef3b56ab861b977a985a38cc6bbf594298e17 /.github | |
| parent | 93c54e06bc53e849f7206b122d71e6e8ef2206c9 (diff) | |
| download | nixpkgs-883051e1a18988bd2f3c0392072c769d600c7a96.tar nixpkgs-883051e1a18988bd2f3c0392072c769d600c7a96.tar.gz nixpkgs-883051e1a18988bd2f3c0392072c769d600c7a96.tar.bz2 nixpkgs-883051e1a18988bd2f3c0392072c769d600c7a96.tar.lz nixpkgs-883051e1a18988bd2f3c0392072c769d600c7a96.tar.xz nixpkgs-883051e1a18988bd2f3c0392072c769d600c7a96.tar.zst nixpkgs-883051e1a18988bd2f3c0392072c769d600c7a96.zip | |
PULL_REQUEST_TEMPLATE.md: execution -> basic functionality
As suggested by Artturin.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2a17c416073..5bbb2700aec 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -27,7 +27,7 @@ Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing- - [ ] or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - [ ] made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` -- [ ] Tested execution of all binary files (usually in `./result/bin/`) +- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant |