summary refs log tree commit diff
path: root/src/linux.rs
diff options
context:
space:
mode:
authorDaniel Verkamp <dverkamp@chromium.org>2019-09-24 11:06:58 -0700
committerCommit Bot <commit-bot@chromium.org>2019-10-17 00:17:05 +0000
commit04a82c7be173b2068c4254ed4a129e24e9e3a2e4 (patch)
tree253fdffb4299b8ed379cec420c54b81c8b0d5865 /src/linux.rs
parenta7b75c8a219eb98e49d995ea58e33e1832533e1b (diff)
downloadcrosvm-04a82c7be173b2068c4254ed4a129e24e9e3a2e4.tar
crosvm-04a82c7be173b2068c4254ed4a129e24e9e3a2e4.tar.gz
crosvm-04a82c7be173b2068c4254ed4a129e24e9e3a2e4.tar.bz2
crosvm-04a82c7be173b2068c4254ed4a129e24e9e3a2e4.tar.lz
crosvm-04a82c7be173b2068c4254ed4a129e24e9e3a2e4.tar.xz
crosvm-04a82c7be173b2068c4254ed4a129e24e9e3a2e4.tar.zst
crosvm-04a82c7be173b2068c4254ed4a129e24e9e3a2e4.zip
devices: vfio: fix clippy warnings
Fix boxed_local, const_static_lifetime, useless_format, and
redundant_closure clippy warnings in the VFIO code.

This fixes all clippy warnings except a single instance of
let_and_return in VfioPciDevice::keep_fds(), since that code is modified
in an upcoming patch.

BUG=None
TEST=./build_test.py
TEST=bin/clippy

Change-Id: I548adbc6b92448fc0db82ed72214d73b0eabaf5c
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1822697
Reviewed-by: Xiong  Zhang <xiong.y.zhang@intel.corp-partner.google.com>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Tested-by: Xiong  Zhang <xiong.y.zhang@intel.corp-partner.google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Diffstat (limited to 'src/linux.rs')
-rw-r--r--src/linux.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/linux.rs b/src/linux.rs
index c761240..6de02e9 100644
--- a/src/linux.rs
+++ b/src/linux.rs
@@ -990,7 +990,7 @@ fn create_devices(
     if cfg.vfio.is_some() {
         let vfio_path = cfg.vfio.as_ref().unwrap().as_path();
         let vfiodevice =
-            Box::new(VfioDevice::new(vfio_path, vm, mem.clone()).map_err(Error::CreateVfioDevice)?);
+            VfioDevice::new(vfio_path, vm, mem.clone()).map_err(Error::CreateVfioDevice)?;
         let vfiopcidevice = Box::new(VfioPciDevice::new(vfiodevice));
         pci_devices.push((vfiopcidevice, simple_jail(&cfg, "vfio_device.policy")?));
     }