diff options
author | David Tolnay <dtolnay@chromium.org> | 2019-04-15 16:58:42 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-18 19:51:01 -0700 |
commit | dc4effa72b214bc3bd14ca2f7772ab1b728aef5b (patch) | |
tree | 61c308a8c165a6fbe65f947da4abd241a9dd265d /gpu_renderer/src | |
parent | 64cd5eae5778b86f6e498a6fa1b1962693aa5a46 (diff) | |
download | crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.gz crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.bz2 crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.lz crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.xz crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.zst crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.zip |
clippy: Iterate without calling .iter()
See: https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop https://rust-lang.github.io/rust-clippy/master/index.html#explicit_into_iter_loop Before: for element in slice.iter() {...} After: for element in slice {...} TEST=grep -r '\.iter() {' TEST=grep -r '\.iter_mut() {' TEST=grep -r '\.into_iter() {' TEST=cargo check --all-features TEST=local kokoro Change-Id: I27f0df7cfa1064b2c8b162cba263513926a433a9 Reviewed-on: https://chromium-review.googlesource.com/1568525 Commit-Ready: David Tolnay <dtolnay@chromium.org> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Diffstat (limited to 'gpu_renderer/src')
-rw-r--r-- | gpu_renderer/src/command_buffer.rs | 2 | ||||
-rw-r--r-- | gpu_renderer/src/lib.rs | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/gpu_renderer/src/command_buffer.rs b/gpu_renderer/src/command_buffer.rs index 1f5b98a..b6c7005 100644 --- a/gpu_renderer/src/command_buffer.rs +++ b/gpu_renderer/src/command_buffer.rs @@ -89,7 +89,7 @@ impl CommandBufferBuilder { pub fn e_clear(&mut self, buffers: u32, color: [f32; 4], depth: f64, stencil: u32) { self.push_cmd(VIRGL_CCMD_CLEAR, 0, VIRGL_OBJ_CLEAR_SIZE); self.push(buffers); - for &c in color.iter() { + for c in &color { self.push(c.to_bits()) } self.push_qw(depth.to_bits()); diff --git a/gpu_renderer/src/lib.rs b/gpu_renderer/src/lib.rs index caa9f8e..8d03673 100644 --- a/gpu_renderer/src/lib.rs +++ b/gpu_renderer/src/lib.rs @@ -792,7 +792,7 @@ impl Resource { } self.detach_backing(); self.backing_mem = Some(mem.clone()); - for &(addr, len) in iovecs.iter() { + for &(addr, len) in iovecs { // Unwrap will not panic because we already checked the slices. let slice = mem.get_slice(addr.offset(), len as u64).unwrap(); self.backing_iovecs.push(VirglVec { |