diff options
| author | Artturi <Artturin@artturin.com> | 2023-01-14 19:50:20 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-14 19:50:20 +0200 |
| commit | 1121c8fcb74f53340f044eff6fa47af449617e0d (patch) | |
| tree | 43ce069e0e111134be3801cdba4286b5ba0da814 | |
| parent | b591671a5051f2ae2667f17f225c7ec82e1a666b (diff) | |
| parent | c8a1838d30fc1f7606b74ada544c73e8a868c0eb (diff) | |
| download | nixpkgs-1121c8fcb74f53340f044eff6fa47af449617e0d.tar nixpkgs-1121c8fcb74f53340f044eff6fa47af449617e0d.tar.gz nixpkgs-1121c8fcb74f53340f044eff6fa47af449617e0d.tar.bz2 nixpkgs-1121c8fcb74f53340f044eff6fa47af449617e0d.tar.lz nixpkgs-1121c8fcb74f53340f044eff6fa47af449617e0d.tar.xz nixpkgs-1121c8fcb74f53340f044eff6fa47af449617e0d.tar.zst nixpkgs-1121c8fcb74f53340f044eff6fa47af449617e0d.zip | |
Merge pull request #185005 from amjoseph-nixpkgs/pr/fetchgit/fix-comment
| -rw-r--r-- | pkgs/build-support/fetchgit/default.nix | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkgs/build-support/fetchgit/default.nix b/pkgs/build-support/fetchgit/default.nix index 1fec0c88747..2d0b4b20ef8 100644 --- a/pkgs/build-support/fetchgit/default.nix +++ b/pkgs/build-support/fetchgit/default.nix @@ -34,7 +34,7 @@ in /* NOTE: fetchgit has one problem: git fetch only works for refs. - This is because fetching arbitrary (maybe dangling) commits may be a security risk + This is because fetching arbitrary (maybe dangling) commits creates garbage collection risks and checking whether a commit belongs to a ref is expensive. This may change in the future when some caching is added to git (?) Usually refs are either tags (refs/tags/*) or branches (refs/heads/*) |