From c8a1838d30fc1f7606b74ada544c73e8a868c0eb Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 3 Aug 2022 05:07:34 -0700 Subject: fetchgit: remove "security" from comment about "security risk" Closes #178410 --- pkgs/build-support/fetchgit/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/build-support/fetchgit/default.nix b/pkgs/build-support/fetchgit/default.nix index 84f2278db29..3bc93ce263f 100644 --- a/pkgs/build-support/fetchgit/default.nix +++ b/pkgs/build-support/fetchgit/default.nix @@ -33,7 +33,7 @@ in /* NOTE: fetchgit has one problem: git fetch only works for refs. - This is because fetching arbitrary (maybe dangling) commits may be a security risk + This is because fetching arbitrary (maybe dangling) commits creates garbage collection risks and checking whether a commit belongs to a ref is expensive. This may change in the future when some caching is added to git (?) Usually refs are either tags (refs/tags/*) or branches (refs/heads/*) -- cgit 1.4.1