diff options
author | Alyssa Ross <hi@alyssa.is> | 2023-11-21 14:38:35 +0100 |
---|---|---|
committer | Alyssa Ross <hi@alyssa.is> | 2023-11-21 15:05:16 +0100 |
commit | 5f556f806a70f3787fe725254ccf3d245bd5bebc (patch) | |
tree | 5b0d181d1aed03067e6c0539fff42c8aba255ad3 /host | |
parent | f52039feb89c3414b27036a4ea0554d72d5a2d01 (diff) | |
download | spectrum-5f556f806a70f3787fe725254ccf3d245bd5bebc.tar spectrum-5f556f806a70f3787fe725254ccf3d245bd5bebc.tar.gz spectrum-5f556f806a70f3787fe725254ccf3d245bd5bebc.tar.bz2 spectrum-5f556f806a70f3787fe725254ccf3d245bd5bebc.tar.lz spectrum-5f556f806a70f3787fe725254ccf3d245bd5bebc.tar.xz spectrum-5f556f806a70f3787fe725254ccf3d245bd5bebc.tar.zst spectrum-5f556f806a70f3787fe725254ccf3d245bd5bebc.zip |
vm: build command line into kernels
The kernel command line is policy, and shouldn't be hardcoded in start-vm. We could add a mechanism for customising it at some point (this would probably be helpful for custom VMs), but we don't need that at the moment, since for our built-in VMs we're using custom-configured kernels anyway. Signed-off-by: Alyssa Ross <hi@alyssa.is>
Diffstat (limited to 'host')
-rw-r--r-- | host/start-vm/lib.rs | 1 | ||||
-rw-r--r-- | host/start-vm/tests/vm_command-basic.rs | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/host/start-vm/lib.rs b/host/start-vm/lib.rs index 32ba34d..16d8fe3 100644 --- a/host/start-vm/lib.rs +++ b/host/start-vm/lib.rs @@ -60,7 +60,6 @@ pub fn vm_command(dir: &Path, api_socket_fd: RawFd) -> Result<Command, String> { let mut command = Command::new("cloud-hypervisor"); command.args(["--api-socket", &format!("fd={api_socket_fd}")]); - command.args(["--cmdline", "console=ttyS0 root=PARTLABEL=root"]); command.args(["--memory", "size=128M,shared=on"]); command.args(["--console", "pty"]); command.arg("--kernel"); diff --git a/host/start-vm/tests/vm_command-basic.rs b/host/start-vm/tests/vm_command-basic.rs index 0abe23b..3b8ef0e 100644 --- a/host/start-vm/tests/vm_command-basic.rs +++ b/host/start-vm/tests/vm_command-basic.rs @@ -29,8 +29,6 @@ fn main() -> std::io::Result<()> { let expected_args = vec![ OsStr::new("--api-socket"), OsStr::new("fd=4"), - OsStr::new("--cmdline"), - OsStr::new("console=ttyS0 root=PARTLABEL=root"), OsStr::new("--memory"), OsStr::new("size=128M,shared=on"), OsStr::new("--console"), |