diff options
| author | Matthew Bauer <mjbauer95@gmail.com> | 2020-06-26 16:44:45 -0400 |
|---|---|---|
| committer | Frederik Rietdijk <freddyrietdijk@fridh.nl> | 2020-07-31 08:56:53 +0200 |
| commit | d0677e6d45c4acf9fdd3f09e77f7201794a45a82 (patch) | |
| tree | f1deaee4b39ad422609a6fdb3cfad37c6dbfdb56 /pkgs/tools/compression | |
| parent | f36899e11826b18fdd60496b28af692afbea8b85 (diff) | |
| download | nixpkgs-d0677e6d45c4acf9fdd3f09e77f7201794a45a82.tar nixpkgs-d0677e6d45c4acf9fdd3f09e77f7201794a45a82.tar.gz nixpkgs-d0677e6d45c4acf9fdd3f09e77f7201794a45a82.tar.bz2 nixpkgs-d0677e6d45c4acf9fdd3f09e77f7201794a45a82.tar.lz nixpkgs-d0677e6d45c4acf9fdd3f09e77f7201794a45a82.tar.xz nixpkgs-d0677e6d45c4acf9fdd3f09e77f7201794a45a82.tar.zst nixpkgs-d0677e6d45c4acf9fdd3f09e77f7201794a45a82.zip | |
treewide: add warning comment to “boot” packages
This adds a warning to the top of each “boot” package that reads: Note: this package is used for bootstrapping fetchurl, and thus cannot use fetchpatch! All mutable patches (generated by GitHub or cgit) that are needed here should be included directly in Nixpkgs as files. This makes it clear to maintainer that they may need to treat this package a little differently than others. Importantly, we can’t use fetchpatch here due to using <nix/fetchurl.nix>. To avoid having stale hashes, we need to include patches that are subject to changing overtime (for instance, gitweb’s patches contain a version number at the bottom).
Diffstat (limited to 'pkgs/tools/compression')
| -rw-r--r-- | pkgs/tools/compression/bzip2/default.nix | 5 | ||||
| -rw-r--r-- | pkgs/tools/compression/gzip/default.nix | 5 | ||||
| -rw-r--r-- | pkgs/tools/compression/lzip/default.nix | 5 | ||||
| -rw-r--r-- | pkgs/tools/compression/xz/default.nix | 5 |
4 files changed, 20 insertions, 0 deletions
diff --git a/pkgs/tools/compression/bzip2/default.nix b/pkgs/tools/compression/bzip2/default.nix index 41dcd54ecdb..3e20258cbbe 100644 --- a/pkgs/tools/compression/bzip2/default.nix +++ b/pkgs/tools/compression/bzip2/default.nix @@ -3,6 +3,11 @@ , autoreconfHook }: +# Note: this package is used for bootstrapping fetchurl, and thus +# cannot use fetchpatch! All mutable patches (generated by GitHub or +# cgit) that are needed here should be included directly in Nixpkgs as +# files. + stdenv.mkDerivation rec { pname = "bzip2"; version = "1.0.6.0.1"; diff --git a/pkgs/tools/compression/gzip/default.nix b/pkgs/tools/compression/gzip/default.nix index eb680ff8a06..9628e100c1c 100644 --- a/pkgs/tools/compression/gzip/default.nix +++ b/pkgs/tools/compression/gzip/default.nix @@ -4,6 +4,11 @@ , writeText }: +# Note: this package is used for bootstrapping fetchurl, and thus +# cannot use fetchpatch! All mutable patches (generated by GitHub or +# cgit) that are needed here should be included directly in Nixpkgs as +# files. + stdenv.mkDerivation rec { pname = "gzip"; version = "1.10"; diff --git a/pkgs/tools/compression/lzip/default.nix b/pkgs/tools/compression/lzip/default.nix index 62f57a8cca7..e55af8b94ed 100644 --- a/pkgs/tools/compression/lzip/default.nix +++ b/pkgs/tools/compression/lzip/default.nix @@ -1,5 +1,10 @@ { stdenv, fetchurl, texinfo }: +# Note: this package is used for bootstrapping fetchurl, and thus +# cannot use fetchpatch! All mutable patches (generated by GitHub or +# cgit) that are needed here should be included directly in Nixpkgs as +# files. + stdenv.mkDerivation rec { pname = "lzip"; version = "1.21"; diff --git a/pkgs/tools/compression/xz/default.nix b/pkgs/tools/compression/xz/default.nix index 545384c396d..5cf88288d81 100644 --- a/pkgs/tools/compression/xz/default.nix +++ b/pkgs/tools/compression/xz/default.nix @@ -1,5 +1,10 @@ { stdenv, fetchurl, enableStatic ? false }: +# Note: this package is used for bootstrapping fetchurl, and thus +# cannot use fetchpatch! All mutable patches (generated by GitHub or +# cgit) that are needed here should be included directly in Nixpkgs as +# files. + stdenv.mkDerivation rec { name = "xz-5.2.5"; |