summary refs log tree commit diff
path: root/pkgs/tools/audio/beets
diff options
context:
space:
mode:
authorProfpatsch <mail@profpatsch.de>2017-06-14 11:29:31 +0200
committerJoachim Schiele <js@lastlog.de>2017-06-14 11:29:31 +0200
commit79dd4deda5a5ee44359a88cdcbbc22a15ba26224 (patch)
tree270e42ec5d33fa623f92e352fe9025d14e269bca /pkgs/tools/audio/beets
parentf6fbbabcb70a19428a7adde2e4f1ec477c439654 (diff)
downloadnixpkgs-79dd4deda5a5ee44359a88cdcbbc22a15ba26224.tar
nixpkgs-79dd4deda5a5ee44359a88cdcbbc22a15ba26224.tar.gz
nixpkgs-79dd4deda5a5ee44359a88cdcbbc22a15ba26224.tar.bz2
nixpkgs-79dd4deda5a5ee44359a88cdcbbc22a15ba26224.tar.lz
nixpkgs-79dd4deda5a5ee44359a88cdcbbc22a15ba26224.tar.xz
nixpkgs-79dd4deda5a5ee44359a88cdcbbc22a15ba26224.tar.zst
nixpkgs-79dd4deda5a5ee44359a88cdcbbc22a15ba26224.zip
Ultrastar (#26524)
* ultrastardx-beta: init at 1.3.5

* libbass, libbass_fx: init at 24

* ultrastar-creator: init at 2017-04-12

* buildSupport/plugins.nix: add diffPlugins

Helper function to compare expected plugin lists to the found plugins.

* ultrastar-manager: init at 2017-05-24

The plugins are built in their own derivations, speeding up (re-)compilation.
The `diffPlugins` function from `beets` is reused to test for changes in the
plugin list on updates.

* beets: switch to diffPlugins

The function is basically just extracted for better reusability.
Diffstat (limited to 'pkgs/tools/audio/beets')
-rw-r--r--pkgs/tools/audio/beets/default.nix11
1 files changed, 2 insertions, 9 deletions
diff --git a/pkgs/tools/audio/beets/default.nix b/pkgs/tools/audio/beets/default.nix
index c1418d152dd..35b4557a33c 100644
--- a/pkgs/tools/audio/beets/default.nix
+++ b/pkgs/tools/audio/beets/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, writeScript, glibcLocales
+{ stdenv, fetchFromGitHub, writeScript, glibcLocales, diffPlugins
 , pythonPackages, imagemagick, gobjectIntrospection, gst_all_1
 
 , enableAcousticbrainz ? true
@@ -158,20 +158,13 @@ in pythonPackages.buildPythonApplication rec {
   doCheck = true;
 
   preCheck = ''
-    (${concatMapStrings (s: "echo \"${s}\";") allPlugins}) \
-      | sort -u > plugins_defined
     find beetsplug -mindepth 1 \
       \! -path 'beetsplug/__init__.py' -a \
       \( -name '*.py' -o -path 'beetsplug/*/__init__.py' \) -print \
       | sed -n -re 's|^beetsplug/([^/.]+).*|\1|p' \
       | sort -u > plugins_available
 
-    if ! mismatches="$(diff -y plugins_defined plugins_available)"; then
-      echo "The the list of defined plugins (left side) doesn't match" \
-           "the list of available plugins (right side):" >&2
-      echo "$mismatches" >&2
-      exit 1
-    fi
+     ${diffPlugins allPlugins "plugins_available"}
   '';
 
   checkPhase = ''