summary refs log tree commit diff
path: root/pkgs/tools/audio/beets/alternatives-plugin.nix
diff options
context:
space:
mode:
authoraszlig <aszlig@redmoonstudios.org>2017-09-02 02:03:03 +0200
committeraszlig <aszlig@redmoonstudios.org>2017-09-02 02:36:32 +0200
commit40b76c880943af92f38df406c666e4eea8f758b2 (patch)
tree08505365317cda02ff31d84dc050c37438936e62 /pkgs/tools/audio/beets/alternatives-plugin.nix
parentbd2aeb4883176554214bdf2af404b88eb09d83fa (diff)
downloadnixpkgs-40b76c880943af92f38df406c666e4eea8f758b2.tar
nixpkgs-40b76c880943af92f38df406c666e4eea8f758b2.tar.gz
nixpkgs-40b76c880943af92f38df406c666e4eea8f758b2.tar.bz2
nixpkgs-40b76c880943af92f38df406c666e4eea8f758b2.tar.lz
nixpkgs-40b76c880943af92f38df406c666e4eea8f758b2.tar.xz
nixpkgs-40b76c880943af92f38df406c666e4eea8f758b2.tar.zst
nixpkgs-40b76c880943af92f38df406c666e4eea8f758b2.zip
beets: Run tests for external plugins
In order to run the tests for the external plugins of beets, we need to
have beets itself as a dependency. So in order to do that, we now pass
beets without plugins and tests to the nativeBuildInputs of the plugins
so that we can run them.

As soon as the plugins are built they become part of the final beets,
which also has tests enabled, so disabling the tests for beets
derivation that is used for external plugin tests is a non-issue here
because they're going to be executed anyway.

Enabling tests for the alternatives plugin is pretty straightforward,
but in order to run tests for the copyartifacts plugin, we need to bump
the source code to the latest Git master.

The reason for this is that the version that was in use until now
required to have the beets source directory alongside of the
copyartifacts source code, but we already have beets available as a
normal dependency.

Updating copyartifacts to latest master largely consists of unit test
changes and a few Python 3 compatibility changes. However, one change
has the biggest stat, which is
sbarakat/beets-copyartifacts@1a0c281da0be7251f414397960a83d60dc3a1520.

Fortunately, the last change is just moving the implementation to a
newer API from upstream beets and by the looks of the implementation it
seems to break support for moving files. However, reverting this commit
also reveals that moving files was already broken before, so it wouldn't
matter much whether we have this version bump or not.

Tested with the following command:

nix-build -E '(import ./. {}).beets.override {
  enableAlternatives = true;
  enableCopyArtifacts = true;
}'

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Cc: @domenkozar, @pjones, @Profpatsch, @michalrus
Diffstat (limited to 'pkgs/tools/audio/beets/alternatives-plugin.nix')
-rw-r--r--pkgs/tools/audio/beets/alternatives-plugin.nix6
1 files changed, 5 insertions, 1 deletions
diff --git a/pkgs/tools/audio/beets/alternatives-plugin.nix b/pkgs/tools/audio/beets/alternatives-plugin.nix
index 35562a85a4d..27be81733d3 100644
--- a/pkgs/tools/audio/beets/alternatives-plugin.nix
+++ b/pkgs/tools/audio/beets/alternatives-plugin.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, pythonPackages }:
+{ stdenv, fetchFromGitHub, beets, pythonPackages }:
 
 pythonPackages.buildPythonApplication rec {
   name = "beets-alternatives-${version}";
@@ -16,6 +16,10 @@ pythonPackages.buildPythonApplication rec {
     sed -i -e '/test_suite/d' setup.py
   '';
 
+  nativeBuildInputs = [ beets pythonPackages.nose ];
+
+  checkPhase = "nosetests";
+
   propagatedBuildInputs = with pythonPackages; [ futures ];
 
   meta = {