summary refs log tree commit diff
path: root/pkgs/tools/archivers/gnutar
diff options
context:
space:
mode:
authorShea Levy <shea@shealevy.com>2016-11-04 23:05:26 -0400
committerShea Levy <shea@shealevy.com>2016-11-04 23:05:26 -0400
commitac59e2f184fe0beeec2920dc9d6d9830813d9212 (patch)
treebe6a7346c3757217bf005b14cc54d202ca61c737 /pkgs/tools/archivers/gnutar
parentca4b43d180cb8764155404943b646a6840140341 (diff)
downloadnixpkgs-ac59e2f184fe0beeec2920dc9d6d9830813d9212.tar
nixpkgs-ac59e2f184fe0beeec2920dc9d6d9830813d9212.tar.gz
nixpkgs-ac59e2f184fe0beeec2920dc9d6d9830813d9212.tar.bz2
nixpkgs-ac59e2f184fe0beeec2920dc9d6d9830813d9212.tar.lz
nixpkgs-ac59e2f184fe0beeec2920dc9d6d9830813d9212.tar.xz
nixpkgs-ac59e2f184fe0beeec2920dc9d6d9830813d9212.tar.zst
nixpkgs-ac59e2f184fe0beeec2920dc9d6d9830813d9212.zip
tar: patch for CVE-2016-6321
https://lwn.net/Vulnerabilities/705216/
Diffstat (limited to 'pkgs/tools/archivers/gnutar')
-rw-r--r--pkgs/tools/archivers/gnutar/CVE-2016-6321.patch35
-rw-r--r--pkgs/tools/archivers/gnutar/default.nix2
2 files changed, 36 insertions, 1 deletions
diff --git a/pkgs/tools/archivers/gnutar/CVE-2016-6321.patch b/pkgs/tools/archivers/gnutar/CVE-2016-6321.patch
new file mode 100644
index 00000000000..c53d92891fc
--- /dev/null
+++ b/pkgs/tools/archivers/gnutar/CVE-2016-6321.patch
@@ -0,0 +1,35 @@
+commit 7340f67b9860ea0531c1450e5aa261c50f67165d
+Author: Paul Eggert <eggert@Penguin.CS.UCLA.EDU>
+Date:   Sat Oct 29 21:04:40 2016 -0700
+
+    When extracting, skip ".." members
+    
+    * NEWS: Document this.
+    * src/extract.c (extract_archive): Skip members whose names
+    contain "..".
+
+diff --git a/src/extract.c b/src/extract.c
+index f982433..7904148 100644
+--- a/src/extract.c
++++ b/src/extract.c
+@@ -1629,12 +1629,20 @@ extract_archive (void)
+ {
+   char typeflag;
+   tar_extractor_t fun;
++  bool skip_dotdot_name;
+ 
+   fatal_exit_hook = extract_finish;
+ 
+   set_next_block_after (current_header);
+ 
++  skip_dotdot_name = (!absolute_names_option
++		      && contains_dot_dot (current_stat_info.orig_file_name));
++  if (skip_dotdot_name)
++    ERROR ((0, 0, _("%s: Member name contains '..'"),
++	    quotearg_colon (current_stat_info.orig_file_name)));
++
+   if (!current_stat_info.file_name[0]
++      || skip_dotdot_name
+       || (interactive_option
+ 	  && !confirm ("extract", current_stat_info.file_name)))
+     {
diff --git a/pkgs/tools/archivers/gnutar/default.nix b/pkgs/tools/archivers/gnutar/default.nix
index 16660fea3e7..80c84236b8d 100644
--- a/pkgs/tools/archivers/gnutar/default.nix
+++ b/pkgs/tools/archivers/gnutar/default.nix
@@ -9,7 +9,7 @@ stdenv.mkDerivation rec {
     sha256 = "097hx7sbzp8qirl4m930lw84kn0wmxhmq7v1qpra3mrg0b8cyba0";
   };
 
-  patches = [ ]; # FIXME: remove on another stdenv rebuild
+  patches = [ ./CVE-2016-6321.patch ]; # FIXME: remove on another stdenv rebuild
 
   # avoid retaining reference to CF during stdenv bootstrap
   configureFlags = stdenv.lib.optionals stdenv.isDarwin [