summary refs log tree commit diff
path: root/pkgs/os-specific/linux/kernel/common-config.nix
diff options
context:
space:
mode:
authorJan Malakhovski <oxij@oxij.org>2015-03-24 21:34:54 +0000
committerJan Malakhovski <oxij@oxij.org>2015-03-26 12:43:42 +0000
commit89bfacdf90fff0dde857c5b0e29b73042ec1d4c7 (patch)
tree0bdf401fd723815e2686a720b579ee5ed8dba9ea /pkgs/os-specific/linux/kernel/common-config.nix
parent5990cce95f562ed185f55cb9bc3f230265d2ab9d (diff)
downloadnixpkgs-89bfacdf90fff0dde857c5b0e29b73042ec1d4c7.tar
nixpkgs-89bfacdf90fff0dde857c5b0e29b73042ec1d4c7.tar.gz
nixpkgs-89bfacdf90fff0dde857c5b0e29b73042ec1d4c7.tar.bz2
nixpkgs-89bfacdf90fff0dde857c5b0e29b73042ec1d4c7.tar.lz
nixpkgs-89bfacdf90fff0dde857c5b0e29b73042ec1d4c7.tar.xz
nixpkgs-89bfacdf90fff0dde857c5b0e29b73042ec1d4c7.tar.zst
nixpkgs-89bfacdf90fff0dde857c5b0e29b73042ec1d4c7.zip
kernel: add a warning/note at the top of common-config so that people would hopefully stop breaking the older kernels
Diffstat (limited to 'pkgs/os-specific/linux/kernel/common-config.nix')
-rw-r--r--pkgs/os-specific/linux/kernel/common-config.nix18
1 files changed, 18 insertions, 0 deletions
diff --git a/pkgs/os-specific/linux/kernel/common-config.nix b/pkgs/os-specific/linux/kernel/common-config.nix
index e6d45af7c59..002c2997cd6 100644
--- a/pkgs/os-specific/linux/kernel/common-config.nix
+++ b/pkgs/os-specific/linux/kernel/common-config.nix
@@ -1,3 +1,21 @@
+/*
+
+  WARNING/NOTE: whenever you want to add an option here you need to
+  either
+
+  * mark it as an optional one with `?` suffix,
+  * or make sure it works for all the versions in nixpkgs,
+  * or check for which kernel versions it will work (using kernel
+    changelog, google or whatever) and mark it with `versionOlder` or
+    `versionAtLeast`.
+
+  Then do test your change by building all the kernels (or at least
+  their configs) in nixpkgs or else you will guarantee lots and lots
+  of pain to users trying to switch to an older kernel because of some
+  hardware problems with a new one.
+
+*/
+
 { stdenv, version, kernelPlatform, extraConfig, features }:
 
 with stdenv.lib;